Date:   Sun, 12 Dec 2021 22:51:13 +0100 (CET)
From:   Richard Weinberger <richard@nod.at>
To:     Trond Myklebust <trondmy@hammerspace.com>
Cc:     linux-nfs <linux-nfs@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        anna schumaker <anna.schumaker@netapp.com>,
        david <david@sigma-star.at>
Message-ID: <720365903.160502.1639345873669.JavaMail.zimbra@nod.at>
In-Reply-To: <1812588409.160456.1639344774221.JavaMail.zimbra@nod.at>
References: <20211212210044.16238-1-richard@nod.at> <dd3aec8fed9bab9b3e62fc2093803688b7b71682.camel@hammerspace.com> <1812588409.160456.1639344774221.JavaMail.zimbra@nod.at>
Subject: Re: [RFC PATCH] NFS: Save 4 bytes when re-exporting
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Thread-Topic: Save 4 bytes when re-exporting
Thread-Index: AQHX75ta92YY4WU8k06yTBIDlSm7OawvXNEA1wwF3itcInypJA==
Precedence: bulk

----- Ursprüngliche Mail -----
> Von: "richard" <richard@nod.at>
> ----- Ursprüngliche Mail -----
>> Von: "Trond Myklebust" <trondmy@hammerspace.com>
>> On Sun, 2021-12-12 at 22:00 +0100, Richard Weinberger wrote:
>>> When re-exporting, the whole struct nfs_fh is embedded in the new
>>> fhandle.
>>> But we need only nfs_fh->data[], nfs_fh->size is not needed.
>>> So skip fs_fh->size and save a full word (4 bytes).
>>> The downside is the extra memcpy() in nfs_fh_to_dentry().
>>> 
>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>> ---
>>> While investigating into improving NFS re-export I noticed that
>>> we can already save 4 bytes of overhead.
>>> I don't think we need to embedd the full struct nfs_fh and
>>> can skip ->size.
>>> 
>> 
>> NACK. This will break existing running clients. Any code to change the
>> filehandle format must be accompanied with code to detect and service
>> filehandles that are presented in the old format.
> 
> One possible way to distinguish between old and new formats
> is looking at the length of the data.
> 2 * XDR_UNIT = new format (without ->size).
> 3 * XDR_UNIT = old format.

Never mind. This won't work.

Thanks,
//richard