From:   Chuck Lever III <chuck.lever@oracle.com>
To:     "trondmy@kernel.org" <trondmy@kernel.org>
CC:     Bruce Fields <bfields@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2 09/10] nfsd: allow lockd to be forcibly disabled
Thread-Topic: [PATCH v2 09/10] nfsd: allow lockd to be forcibly disabled
Thread-Index: AQHX9HoJhWnJgEOGdUmX2SRgV5Jy6aw6JRcA
Date:   Sun, 19 Dec 2021 18:34:14 +0000
Message-ID: <12FA08AD-3F5B-4E7B-91F7-E2EFAC680A3E@oracle.com>
References: <20211219013803.324724-1-trondmy@kernel.org>
 <20211219013803.324724-2-trondmy@kernel.org>
 <20211219013803.324724-3-trondmy@kernel.org>
 <20211219013803.324724-4-trondmy@kernel.org>
 <20211219013803.324724-5-trondmy@kernel.org>
 <20211219013803.324724-6-trondmy@kernel.org>
 <20211219013803.324724-7-trondmy@kernel.org>
 <20211219013803.324724-8-trondmy@kernel.org>
 <20211219013803.324724-9-trondmy@kernel.org>
 <20211219013803.324724-10-trondmy@kernel.org>
In-Reply-To: <20211219013803.324724-10-trondmy@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aunY7m33VnUgJ9QUZPdXrAFOKvCbxhHeorT2D1/DZ3UJWBMvK4Nj6df5ChxL?=
 =?us-ascii?Q?8/y0NZ3Shv3pSj+ag3QMh0ullQ5fISdLUPaFIog6vWtiUrpxYNdF6FYu9q2t?=
 =?us-ascii?Q?Q5b0r676rOD2raY6ljaX97pG+5Y/I57PM11XMAarR3zmDFh4GRu+9S3Pcgkk?=
 =?us-ascii?Q?T5pMKtaUx7NsrqkDiMudu7giKYBqudXeY1s5DouMT2kYsooeVIvBCVrXMEAN?=
 =?us-ascii?Q?XG7hDO3JyfeepG0gxVTWdO6F5k2qI9+JEH8lqKtYIQAzPTvQfPUDh3fAQYb7?=
 =?us-ascii?Q?ndDpqSMvgl4ExVjJ9Vy850dEmKlWu6Y17TKpiq5pcVT5jTgBAdv70ys1RMhS?=
 =?us-ascii?Q?a+8fPmFOTC/LbVOTkRcBLy1wQMg0TvzNze5vB+/XsyLrzjmdLNoC+/dqF9Ap?=
 =?us-ascii?Q?o0SqQDZLWXybr7kPua6hbFTvPFCN8R0FT6LK/a0iG3XNOW4t+wUoPG0I0zDr?=
 =?us-ascii?Q?C7hXahw8Jt7o4ZA5+V+ikQD2gQ1FlHoyEeSfIyt1Ns5BSbvrbPeed+cGNxKg?=
 =?us-ascii?Q?NxLJnD0aMi8RJrcCVj2CYLt+s+b/d7EFUDA2tfKqACciL2SjwQz3A2tHbNpk?=
 =?us-ascii?Q?c7h4UHcv+3u0pQ9pH9S+QYPhIh6sZIIldY5zTfXWHUfsU8GWXg/6vJaoSOlD?=
 =?us-ascii?Q?geDGPIJMx4elvTwmw1p4P7VZ+zYZKWqjXS8+eQT+JE0JU95S1WMPFuOAWRn3?=
 =?us-ascii?Q?6eQM42lcGCHjvXJgEpECUqITJeJ/iIDXYVIv3xyxbUqjt3JxiVKB8Z/mXWsX?=
 =?us-ascii?Q?9FPEMl2iMSPERik2L1RhaUZlz+GGXsjfYVO0c/XoNRJ8EIG+HiD8YgHIQJvc?=
 =?us-ascii?Q?2csHe16KDFIbc4wf3JeQfucuE2DuPdkHycrzW2OWGZxy4S9jqQGLOKStAndy?=
 =?us-ascii?Q?fE+NCmmY8t/kRQ9GYW7OOYWZbiVVtQzeFeFLZsJYZYeoXEkpHgBrB+cRgR7z?=
 =?us-ascii?Q?MWeTdeWCGbmCCHvVmw7cu7Xgp65XtvymRfY6C/I/rfjcB3C8FsROubZxGNrB?=
 =?us-ascii?Q?5+SYMfr7eI/DJ9y/OpOoPJw7dwnx7y+BVJMXTXd7bDMTAsGlC+A1VODuJux4?=
 =?us-ascii?Q?aY5zTqvS5SqbiS2vYmSvd+TB2M5yPTN00vBwrN/9UO5i5cvxNdBKzmtvN8Ii?=
 =?us-ascii?Q?RIbQLUayEtvvVBdyrhus4dv4/Q+1/eYV6emCAsL9ZmnD0j2+NsH4h2at58e3?=
 =?us-ascii?Q?Ca9sJzwMA0Xz4e8ppGBVdEF8Xy8THqGiye35bLW83hR9rtMeONs7D1mhgeG5?=
 =?us-ascii?Q?YSe5Uoa7wdqiwaT9YDoRhR5tQsXWbppuec3IlhpDx2ag3zKQGZq9/yVPJU7Q?=
 =?us-ascii?Q?J48RTX9+eHch53ESY2tXccL9rwHEJPtmvPk88+KDnQRJ38FeJd45/weSSzEw?=
 =?us-ascii?Q?L3H6Xqw6EN+j39kKMomMLipWz+tOYDZsys3NZXPokvzP1Y5jTijfWBy62eYl?=
 =?us-ascii?Q?Z5ZFfJkPrfV/LEeGf/JkPQpajaUj6ixoWg0eojXRvqA909GVWKl2DGXxhnjX?=
 =?us-ascii?Q?XQX6WMkMBwdNnSdXmxn7RMgE2i1JalIB5+V07N1gM8ZagoU0MiFsrRngDRFG?=
 =?us-ascii?Q?+ZNLzwBM3n6hWm9gDj748G97gIFPBAf4hHxbCcJUWWn+odZq73Z+d8lRu9TS?=
 =?us-ascii?Q?MDmAb5Mi1G48XNeZEZmkBlw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CFA9F76FF744C243B0B06A6D36254ADC@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB4858.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 250f7d60-cfe3-4d6b-34c4-08d9c31e28dd
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2021 18:34:14.9469
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: erJKtm7npj6NYjUgzwRsjPBGVm1B44i5+aoq8uRi1ycERo6ZNg7FuUm9UNWcp6IIiVzrpLCCCwktOEPpFdrkEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5035
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10203 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0
 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 mlxscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112190115
X-Proofpoint-GUID: VGtfwQdeyuWZClx4E5OvoN-AfKALXRnW
X-Proofpoint-ORIG-GUID: VGtfwQdeyuWZClx4E5OvoN-AfKALXRnW
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Dec 18, 2021, at 8:38 PM, trondmy@kernel.org wrote:
>=20
> From: Jeff Layton <jeff.layton@primarydata.com>
>=20
> In some cases, we may want to use a userland NLM server which will
> require that we turn off lockd.
>=20
> Signed-off-by: Jeff Layton <jeff.layton@primarydata.com>
> Signed-off-by: Lance Shelton <lance.shelton@hammerspace.com>
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
> fs/nfsd/nfssvc.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>=20
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 80431921e5d7..6815c70b06af 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -340,8 +340,19 @@ static void nfsd_shutdown_generic(void)
> 	nfsd_file_cache_shutdown();
> }
>=20
> +/*
> + * Allow admin to disable lockd. This would typically be used to allow (=
e.g.)
> + * a userspace NLM server of some sort to be used.
> + */
> +static bool nfsd_disable_lockd =3D false;
> +module_param(nfsd_disable_lockd, bool, 0644);
> +MODULE_PARM_DESC(nfsd_disable_lockd, "Allow lockd to be manually disable=
d.");
> +
> static bool nfsd_needs_lockd(struct nfsd_net *nn)

                              ^^^^^^^^^^^^^^^^^^^^

An nfsd_net * is passed to nfsd_needs_lockd(), therefore the
availability of the lockd service needs to be aware of net namespaces,
right?

NAK for now, but I'm open to more dialog about how to support the "no
lockd" use case. That's intriguing.


> {
> +	if (nfsd_disable_lockd)
> +		return false;
> +
> 	return nfsd_vers(nn, 2, NFSD_TEST) || nfsd_vers(nn, 3, NFSD_TEST);
> }
>=20
> --=20
> 2.33.1
>=20

--
Chuck Lever