MIME-Version: 1.0
References: <20211217215046.40316-1-trondmy@kernel.org> <20211217215046.40316-2-trondmy@kernel.org>
 <20211217215046.40316-3-trondmy@kernel.org> <20211217215046.40316-4-trondmy@kernel.org>
 <20211217215046.40316-5-trondmy@kernel.org> <20211217215046.40316-6-trondmy@kernel.org>
 <20211217215046.40316-7-trondmy@kernel.org> <20211217215046.40316-8-trondmy@kernel.org>
 <20211217215046.40316-9-trondmy@kernel.org>
In-Reply-To: <20211217215046.40316-9-trondmy@kernel.org>
From:   Bruce Fields <bfields@redhat.com>
Date:   Sun, 19 Dec 2021 17:21:41 -0500
Message-ID: <CAPL3RVHkbVS1Fu=vigWM+0tmyzqCNKLrVz_zWQ6qhZOnoJO+BQ@mail.gmail.com>
Subject: Re: [PATCH 8/9] nfsd: allow lockd to be forcibly disabled
To:     trondmy@kernel.org
Cc:     Chuck Lever <chuck.lever@oracle.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

This seems like a really specialized requirement.  Is anyone outside
hammerspace doing this?

--b.

On Fri, Dec 17, 2021 at 5:02 PM <trondmy@kernel.org> wrote:
>
> From: Jeff Layton <jeff.layton@primarydata.com>
>
> In some cases, we may want to use a userland NLM server which will
> require that we turn off lockd.
>
> Signed-off-by: Jeff Layton <jeff.layton@primarydata.com>
> Signed-off-by: Lance Shelton <lance.shelton@hammerspace.com>
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
>  fs/nfsd/nfssvc.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index ccb59e91011b..7486a6f5fc21 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -340,8 +340,19 @@ static void nfsd_shutdown_generic(void)
>         nfsd_file_cache_shutdown();
>  }
>
> +/*
> + * Allow admin to disable lockd. This would typically be used to allow (e.g.)
> + * a userspace NLM server of some sort to be used.
> + */
> +static bool nfsd_disable_lockd = false;
> +module_param(nfsd_disable_lockd, bool, 0644);
> +MODULE_PARM_DESC(nfsd_disable_lockd, "Allow lockd to be manually disabled.");
> +
>  static bool nfsd_needs_lockd(struct nfsd_net *nn)
>  {
> +       if (nfsd_disable_lockd)
> +               return false;
> +
>         return nfsd_vers(nn, 2, NFSD_TEST) || nfsd_vers(nn, 3, NFSD_TEST);
>  }
>
> --
> 2.33.1
>