From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Trond Myklebust <trondmy@hammerspace.com>
CC:     "trondmy@kernel.org" <trondmy@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Bruce Fields <bfields@redhat.com>
Subject: Re: [PATCH v2 10/10] nfsd: Ignore rpcbind errors on nfsd startup
Thread-Topic: [PATCH v2 10/10] nfsd: Ignore rpcbind errors on nfsd startup
Thread-Index: AQHX9HoJf0UrhpbILEawWnDLCGoAp6w6H74AgAArPACAAT7dAA==
Date:   Mon, 20 Dec 2021 15:51:09 +0000
Message-ID: <316378A4-BCB1-4C8F-A16D-43F8F9DA8FBC@oracle.com>
References: <20211219013803.324724-1-trondmy@kernel.org>
 <20211219013803.324724-2-trondmy@kernel.org>
 <20211219013803.324724-3-trondmy@kernel.org>
 <20211219013803.324724-4-trondmy@kernel.org>
 <20211219013803.324724-5-trondmy@kernel.org>
 <20211219013803.324724-6-trondmy@kernel.org>
 <20211219013803.324724-7-trondmy@kernel.org>
 <20211219013803.324724-8-trondmy@kernel.org>
 <20211219013803.324724-9-trondmy@kernel.org>
 <20211219013803.324724-10-trondmy@kernel.org>
 <20211219013803.324724-11-trondmy@kernel.org>
 <831659F6-3005-459B-92ED-933BBCEE6FE9@oracle.com>
 <3167a9a815ac9c82700bd58d8c421de31eee8b91.camel@hammerspace.com>
In-Reply-To: <3167a9a815ac9c82700bd58d8c421de31eee8b91.camel@hammerspace.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yTvsnIV8U/wcqxaIxGruRopWwhLFh0btc5gRrhBOAzb7I1e+HrQztoiIQU3W?=
 =?us-ascii?Q?tnUYsCFU4AuNLDTobg4UrmsuH0kvOOeObTlow36GRkzu00bvp5U7lRE72D4W?=
 =?us-ascii?Q?Y5zp1kfmP7eAvnvnVziKnRSNYOkDg4Mh/VHf5+/sW+mWl7CVF+fw/55gahYW?=
 =?us-ascii?Q?hTC9vgDor8hQJsk/9SYZhadrw0VVHGTxOGpAXTuB/si3zMdLZ7I4bcRFCNL0?=
 =?us-ascii?Q?zqS9xlPOLHASmIGjJZlX8w27ynM5DvslpPyOLZtimzVJ+s8qpz0glS349suV?=
 =?us-ascii?Q?VORyr5IUHIMYYCjuVyfybW9rm514SbNBIypT7eTX5nrwtvIwVSnnTJalt42A?=
 =?us-ascii?Q?VtM94SlLr3CmqY4XCDYXg9cpH1PVI/1HQLQMzh19HMhhNKwpiHwuvPeJb33N?=
 =?us-ascii?Q?AG2SgAcaVK7hx9aKHb1h3taO4mJ5yNQ6KC92/CXnQYn3cLmWVuLhKrS+MMT4?=
 =?us-ascii?Q?JlzeCD6Tj3/knf7Ot0fmE1t0UzL7XFa7UYxSygO/8X7ot2KdJBRm+Fh8Zxrq?=
 =?us-ascii?Q?S0Xry+Ez+z8noQRxPfFJLA5D5BDK8YXu8aCjBuy/XafCjqUMckXrjycIXQaW?=
 =?us-ascii?Q?T8ooGaHlS+EFYfKpLD6C/huYeZd6Hbn/t5FwLHT48yxDupyTOHigafGOSqmS?=
 =?us-ascii?Q?yMSd4Zos4xiSG8PWk6eVSrWe8cnnR7WzdPmR8NgmYGTqfJCz6Iw9TtJyhWpu?=
 =?us-ascii?Q?m8EcNNpidD1m038/a6iY6+LdpgQ+OqyIyE+ZK42oH+Rmj2Renya0agPSaWo/?=
 =?us-ascii?Q?0UpMYLD8KRzD3pSem1KggoF00mDGgsbeCyIrJ+o8BE/MAqQQqt6AfSq5FLsP?=
 =?us-ascii?Q?vuZe8nydFeBKhbgizAMBGEZJhMD9XdvCi105/yourZ2Avwal2pZ7H4v6Jf2n?=
 =?us-ascii?Q?Aor8h9Zn04JP63ch6MCHl3K7AB5brSxgaM8XdANUSxJDWHENWMGRL9Q8aVim?=
 =?us-ascii?Q?7y+/1MDwenTg4Z8K8cgDnpeaQCY0tfGnENmfkc8Gjc5vzGwzfTbUNdXLeWCO?=
 =?us-ascii?Q?1A0UgyqHpJfMPTD1txYx97C4ISqhP6gshsx3BTJZg1xRHfoVGKFknVSpfhXK?=
 =?us-ascii?Q?HQe1rzZnQiZTlBiOjF2I/f8yJHyMN2s0bt+ng9N0zz4pm94yfX8sa9jo7d7G?=
 =?us-ascii?Q?fQcxXdDA1J2H0zw7akURyFYQG4BjvJbc93Z/eSV1HopVPH8DopKO3W9dTEpg?=
 =?us-ascii?Q?aY+QP8tqUTHDJxkilyFzQfXW2eXZ8V3UNWeA+R4ETqW5BeSfZtgt7NQSjoRC?=
 =?us-ascii?Q?moWhSB0VjTvIO9lkUz3z84QE6ATARahBr9GF/leeU+7BP4lnMus7iOm0ywBm?=
 =?us-ascii?Q?SejWkCbYtOVfKseaVnFPhcD6TNG/4pTW66A714etCu/9nAZZBt1HnGvmdeYW?=
 =?us-ascii?Q?rriwy6NzbyQoQ/waaT/pzcqJds0NX8zkHlslpjQADtRuEGyYfscn9/9Ld6Pw?=
 =?us-ascii?Q?FkO6GZOhYotazTHm66oJjdpSAOOXk+RExKHRXVxQW+fk5Rfp6OTvZbygwYPn?=
 =?us-ascii?Q?YaebZN+j2MvlTYUBs8UD/RsQ3kFqB6rUhaU4zoCdg7ngrcHF72+C++QQ9Gdm?=
 =?us-ascii?Q?lx4iEag0uvZB0tdWqxvd1CK2nRU4Ch+YwR3e5yAPsmqqKpV0FgV4DxQI6yXl?=
 =?us-ascii?Q?llfox0b33tc+4DsUYrHvJCU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <646F4625A7834340B03180E636F26412@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB4858.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a716eb32-9dc5-4b5a-0173-08d9c3d08acf
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2021 15:51:09.8446
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0Ueq/9VhyUv6BRdfWfaTK6ePXyMzFCprzUgEJfv734WckO5hgWH2tpUuxcTf1wagQ8GNGP0ftAw1kwS4Y4qIog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4310
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10203 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0
 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 mlxscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112200090
X-Proofpoint-ORIG-GUID: N4Aarxh2D6VLyArzea9fWybQyYVAwF39
X-Proofpoint-GUID: N4Aarxh2D6VLyArzea9fWybQyYVAwF39
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Dec 19, 2021, at 3:49 PM, Trond Myklebust <trondmy@hammerspace.com> wr=
ote:
>=20
> On Sun, 2021-12-19 at 18:15 +0000, Chuck Lever III wrote:
>>=20
>>> On Dec 18, 2021, at 8:38 PM, trondmy@kernel.org wrote:
>>>=20
>>> From: Trond Myklebust <trond.myklebust@hammerspace.com>
>>>=20
>>> NFSv4 doesn't need rpcbind, so let's not refuse to start up just
>>> because
>>> the rpcbind registration failed.
>>=20
>> Commit 7e55b59b2f32 ("SUNRPC/NFSD: Support a new option for ignoring
>> the result of svc_register") added vs_rpcb_optnl, which is already
>> set for nfsd4_version4. Is that not adequate?
>>=20
>=20
> The other issue is that under certain circumstances, you may also want
> to run NFSv3 without rpcbind support. For instance, when you have a
> knfsd server instance running as a data server, there is typically no
> need to run rpcbind.

So what you are saying is that you'd like this to be a run-time setting
instead of a compile-time setting. Got it.

Note that this patch adds a non-container-aware administrative API. For
the same reasons I NAK'd 9/10, I'm going to NAK this one and ask that
you provide a version that is container-aware (ideally: not a module
parameter).

The new implementation should remove vs_rpcb_optnl, as a clean up.


--
Chuck Lever