From:   Chuck Lever III <chuck.lever@oracle.com>
To:     "trondmy@kernel.org" <trondmy@kernel.org>
CC:     Bruce Fields <bfields@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2 00/10] Assorted patches for knfsd
Thread-Topic: [PATCH v2 00/10] Assorted patches for knfsd
Thread-Index: AQHX9HoG6l7c74yDiUisdre2kgrnXKw9QwuA
Date:   Tue, 21 Dec 2021 18:10:14 +0000
Message-ID: <342ACA13-9F45-43AC-A858-0F1A894458F1@oracle.com>
References: <20211219013803.324724-1-trondmy@kernel.org>
In-Reply-To: <20211219013803.324724-1-trondmy@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qdJgJ1V9txIXLjDvm3U4VC1I7Ob7/ffsr9SUm/KeiEewONh1zq4+BYrsrsXn?=
 =?us-ascii?Q?WHX2QmyKGeQZyBSLPTnfVdOxSPxxGgpSHVIMS2+S3xxpPkzmQ45GbwE/umhe?=
 =?us-ascii?Q?z6DsFjjL/CXeuFb/VtQ2Lg0Er2LS/1dujrhZ/AZfj3bzjvI1PdczTV8yokdm?=
 =?us-ascii?Q?z3RYRRHp5tPqBwXsxNaKxiyBhQyhOOmQFh9L5tNnLJPm448Cykkcvizs/kyU?=
 =?us-ascii?Q?DdWHB7TrlUxsgGj9gbJz1b56jA5z3vDUhh+i33oaDpUruiLBdSgpDpj/wfpv?=
 =?us-ascii?Q?msD5y2JVcrPKEjmL7pUrxo52Gs/1+tjKq02W3GJho+yzz3zKHf8F2TvI9d71?=
 =?us-ascii?Q?Bu5Zfbsr+ypMkePtrwWrZmFrJ3Ie3YmuUB7PFlG69y+E10Oo2QJ6Nwc++NFz?=
 =?us-ascii?Q?hZcv6sYqmVcfufpk0LeUfLTnAcniWqbvHqjPFmyf6vecxSr0F56X4E1wP05k?=
 =?us-ascii?Q?9kqXv2GEpMqEccMgIzmZRG+yXD50u1PuRw9VAPPkE+jSipQ8KhxB4JNdmQri?=
 =?us-ascii?Q?CxXHGhTlEP97TgfGDcbQFNdHLVB5xSEOTd42B1SNse1QRFpwjdjrdAZRWVU1?=
 =?us-ascii?Q?8itcBViO77PzdhIhzJBGS/ua83e/OK4Xp8OTa9F0Dg5LNJpqlkgN+paIPcWt?=
 =?us-ascii?Q?xg6G5MX72wkyCnoE509370CLJ/sc7s1pS0yhLAsxH9FP7XAfcLS69lPWZFqU?=
 =?us-ascii?Q?+6jdyyyhODsLhK2oVle/0CzGr+R014BOIlWDgHxu3G8MDmxCAjAbvOgNDQsO?=
 =?us-ascii?Q?tywl0i/zL/5CR8a8UeiSBRG5W1DU+AdwfOfY9wSd91xDHKP72t9tol3OasWf?=
 =?us-ascii?Q?lBBnUjKpIzTjQ86DeqAVDCDZdYYwgBtvaD+ZgYkLDjf/4Dv1YQvG9skWtm/B?=
 =?us-ascii?Q?ZCY2Cf30e3AeUlfneJ2ZBvdcO9ykjMTkY8whjuN1WeshinQ/QenSWSVN4jMz?=
 =?us-ascii?Q?5jqpiX2iHqamM/6XCY5Fl9BvWmWwoxtq49oluz7yQIZJBETxg7b5L8N8lqV/?=
 =?us-ascii?Q?tMN5AMO+GEOPasgfsWF0wd2lIog+JmQyr1ko9d7+YkoW8mJosIUZ9R4lh5q2?=
 =?us-ascii?Q?fB7IGZZnyDVUUSPJ4mTVahV1eYXwYTVVLb/yBQCib3CwNwyQ+YTpwfipsufR?=
 =?us-ascii?Q?05yvnb4dK+bDTyBx7jJ2bFA/CKO84wGbiPYCOw5SpCakHmQLu1Oa4aVi0Ubl?=
 =?us-ascii?Q?v0AAaWoC5MAZOIeTOO6hmUPzzhJ9CCS411ojLCmqVgaJtMNe/JsMXpuUuL2Y?=
 =?us-ascii?Q?/iqGVzizwY3fbixIs1MD5R60yKPVqhAku+/95Vo4msU2YyBZmxcTjrq6BxVM?=
 =?us-ascii?Q?2SnbWstoA0NAnpjubL9AK7ATuAuLql6QVJgNYtaggE221v87iKIoOIk7ziBA?=
 =?us-ascii?Q?HcZZ9GUweH67YsbBGzql2btdDc1Tz6dS88z1tIHFGS3sxE0Bsj8k9fr27gQk?=
 =?us-ascii?Q?RJnwt8NCRz1OsDkLzACreniOO5vRmGYnhCz44+92EbpJgLZCj7Iy7iAUcDXN?=
 =?us-ascii?Q?CF53F3kuiUKrkbq1cJTUgud21lgyAqy0HES6E+PVv+wFvoHfr5/P+pAD1fZR?=
 =?us-ascii?Q?vgCuRl4wRa2I9nTKRh6l5jd/BJOjne0pOvGygWw+AEevZkHYRQElLw5R1Wme?=
 =?us-ascii?Q?0guUsPItxhvij/Y1EwBhpRM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E5333FA263668F47B2E9661B1C76C845@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB4858.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7268cab4-54d3-4e49-9837-08d9c4ad2348
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2021 18:10:14.9044
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: e4/CdPnckwC5GcYKP05RyLysziKl+jrtLDvaPJTWDxivTPRTDc2t40Uq3O08Dr0XD42Mhg/hxL/v42LH5VHevw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4040
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10205 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 adultscore=0
 phishscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112210089
X-Proofpoint-ORIG-GUID: GzSE4x_5_2MBtfy5U62KmnuDHUKqtfAC
X-Proofpoint-GUID: GzSE4x_5_2MBtfy5U62KmnuDHUKqtfAC
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hi-

> On Dec 18, 2021, at 8:37 PM, trondmy@kernel.org wrote:
>=20
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
>=20
> The following patchset is mainly for improving support for re-exporting
> NFSv4 as NFSv3. However it also includes one generic bugfix for NFSv3 to
> allow zero length writes. It also improves the writeback performance by
> replacing the rwsem with a lock-free errseq_t-based method.
>=20
>=20
> - v2: Split patch adding WCC support
>  v2: Rebase onto v5.16-rc5


I've replaced the following patch. Thank you for the bug report.

>  nfsd: NFSv3 should allow zero length writes

I've provisionally applied the following five to for-next while
tests are in progress:

>  nfsd: map EBADF
>  nfsd: Add errno mapping for EREMOTEIO
>  nfsd: Retry once in nfsd_open on an -EOPENSTALE return
>  nfsd: Add a tracepoint for errors in nfsd4_clone_file_range()
>  nfsd: Replace use of rwsem with errseq_t


The following two are still open for discussion. I get where you
want to go, just a quibble about exactly how to get there.

>  nfsd: Distinguish between required and optional NFSv3 post-op
>    attributes
>  nfs: Add export support for weak cache consistency attributes


The following two are deferred. IMHO they are not ready.

>  nfsd: allow lockd to be forcibly disabled
>  nfsd: Ignore rpcbind errors on nfsd startup

When reposting, you can leave out the patches that have already
been applied.


--
Chuck Lever