Received-SPF: Pass (protection.outlook.com: domain of renesas.com designates
 20.101.26.97 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.101.26.97; helo=mailrelay4.diasemi.com;
From:   Ondrej Valousek <ondrej.valousek.xm@renesas.com>
To:     "bfields@fieldses.org" <bfields@fieldses.org>,
        Ondrej Valousek <ondrej.valousek.xm@renesas.com>
CC:     Trond Myklebust <trondmy@hammerspace.com>,
        "trondmy@kernel.org" <trondmy@kernel.org>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        "anna.schumaker@netapp.com" <anna.schumaker@netapp.com>
Subject: RE: [PATCH 0/8] Support btime and other NFSv4 specific attributes
Thread-Topic: [PATCH 0/8] Support btime and other NFSv4 specific attributes
Thread-Index: AQHYAOOnWznuBWlA7k+POKyqIasZNKxRxaOAgALAoRCAAASbAIAABaVAgAAG2oCAASYa0A==
Date:   Thu, 6 Jan 2022 09:31:15 +0000
Message-ID: <DU2PR10MB5096923D24D76EC264A51EBFE14C9@DU2PR10MB5096.EURPRD10.PROD.OUTLOOK.COM>
References: <20211217204854.439578-1-trondmy@kernel.org>
 <20220103205103.GI21514@fieldses.org>
 <2b27da48604aaa34acce22188bfd429037540a89.camel@hammerspace.com>
 <DU2PR10MB5096010E9570E2718198EDD5E14B9@DU2PR10MB5096.EURPRD10.PROD.OUTLOOK.COM>
 <20220105151008.GB24685@fieldses.org>
 <DU2PR10MB5096501FB8A162D18CF1F1F2E14B9@DU2PR10MB5096.EURPRD10.PROD.OUTLOOK.COM>
 <20220105155451.GA25384@fieldses.org>
In-Reply-To: <20220105155451.GA25384@fieldses.org>
Accept-Language: cs-CZ, en-US
Content-Language: en-US
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=diasemi.com;
X-Microsoft-Antispam-Message-Info-Original: Htn67DFgxR/ngZWcCyQ6Sa9Kc0HH0i3mgFQAFFdh/4lo/oyN50I9802ZWuS3mMk9Dc5Cr1COgeTXbKsfZ1rOWR6O2X4QDxa6fP0mPbLfDr2Qze/tbjD6m2ZtV1pQEhn+GZppJaxKKWGrtJoRsvYSRbeoG3l2BYOwPjZgZoSyRRFFLuG+m0L91AmKy/wH0fJHTamYCABmdCg/G0vRurBW7HYni0GoAUq0DixQTzAM0PbEqKObg3vMnj86FAD11QnWQ7UOOpgMXh+yecgaKpJmWIryjfrG1v9nk82LYXgBGN0ORt8yM3mOOlaa70BhjzwttxGf/CoviWOOf226X2/Z3n0BFF8wv/J1HTKneW3SYUdyDKXMBWj/fsnYZxKfwyWI98HsVMKINgI+h9O6qATueLCQkx71U8NlFqqIkiZTUNkBhrI7r9zPeN2L+U4PSCRgnACQfVhrzeudAMxK/dNWOJ+7y7zM3EE7d5mnpIOljOk3UqFQIofLuVWHdZ+3IMfsa3YWgkLDuKidA9DEEz72t5XNsawOLEuUnTSwX8oqiKrcACbvEedeH5ELEuwUObuigvjncRFLOoMZ5cu4j7qNvlRp482cs4uUbHqwqVGZbU/bAUEGlPseaD7F2q/6glS8ekD5Dk6kO88XI95XdpjouWXda5yUJd8nCHyy4wcmQH0NCrBqw75a9KA36LqoyXkXMIHI2lWgQjeKNIzBhQCpCg==
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR10MB5096.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(4636009)(366004)(64756008)(66946007)(38100700002)(38070700005)(66556008)(110136005)(122000001)(66446008)(26005)(186003)(66476007)(7696005)(2906002)(4326008)(55016003)(5660300002)(66574015)(54906003)(86362001)(33656002)(83380400001)(52536014)(508600001)(53546011)(9686003)(8676002)(55236004)(6506007)(76116006)(316002)(8936002)(71200400001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR10MB5079
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: TYCJPN01FT015.eop-JPN01.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs: 1df276b4-e6a5-4574-ebe6-08d9d0f7492d
X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr,ExtFwd
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: jqwkghWkCvVDFqWdJBvCw1+Wx1OLKCXpuqXNVRkemwY8HiwoGiL7d0mlabaI3d6FWiovWSkcG0rDoK/bPv/91b2qvP3M4mNSJ9W1qM9NYltnamhl2dV1KSmDa2QjplFe8UxMQh7nDyP+vMdg+Dq6j96srSFOOdSpKZWt/VbiBzYVn0/ugvlorxBu9jZQt+PJNooxqhGGtVG5gkO1BRChVnOyv3wmj6NoQfLkgDHFxUcdGL3oKsMPWjdyCRuNPvRJaKog5n1MsYtw4D4k0XNTHVSve38pHVS7bHPofTQksmx3G7CEo2hONRFWIV7uTAjccfOg0u6VoQyj6fTkXGYCD26t0rJ5FqLJgAqaS+f4gQ+g34KrrhKZmosaY/1jprWboLG8by9uRYHMTWEtFKTvSTyP703LsHWw87i2T51sd2700U8PG/gNuKVZGOMlvGBom6M4WhRUnn3PRbQMOOtq2pMxQE5SycvhEdXI/822OJzYz0rHV9bhqVq1kEm8BNuGIfpRAy+ywc4LAbG/ntfzobDyrjkoQtShn9VzNpShHajty0nhDhKXpbAn9NYGpb5xnCyJJotUIWbRzlEmgdOj5DJOveJBKQfMszgr1n8RRiwaUtPNkE9Q6VfJDpA0Sn4ihax+KaKxRh+Qv04TMaHPETttSCk1/W9qslJP/Q2Yh/M5sDT0X88dbfwZGOUB71ziBovMeI76LWLU7Kri2TsmYJOX70E/RRSm5vRJmRx8msnVqoW5ezxhZ/qZfGeeEd7jerLdLR6+rjndS3v7N9fMhL/SQU3WHUV1fwOQ540ALkE=
X-Forefront-Antispam-Report: CIP:20.101.26.97;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mailrelay4.diasemi.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(40470700002)(46966006)(36840700001)(5660300002)(83380400001)(66574015)(356005)(54906003)(8676002)(336012)(8936002)(110136005)(4326008)(81166007)(7696005)(33656002)(26005)(2906002)(70206006)(36906005)(70586007)(6506007)(186003)(508600001)(82310400004)(53546011)(47076005)(55016003)(86362001)(9686003)(36860700001)(52536014)(40460700001)(316002)(36900700001);DIR:OUT;SFP:1102;
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2022 09:31:18.5161
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 07cf1ba7-3202-4134-25fe-08d9d0f74b69
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=53d82571-da19-47e4-9cb4-625a166a4a2a;Ip=[20.101.26.97];Helo=[mailrelay4.diasemi.com]
X-MS-Exchange-CrossTenant-AuthSource: TYCJPN01FT015.eop-JPN01.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB8541
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Looks like this should do I guess...

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 5a93a5db4fb0..be47e1dd6da5 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -3265,6 +3265,14 @@ nfsd4_encode_fattr(struct xdr_stream *xdr, struct sv=
c_fh *fhp,
                p =3D xdr_encode_hyper(p, (s64)stat.mtime.tv_sec);
                *p++ =3D cpu_to_be32(stat.mtime.tv_nsec);
        }
+       /* support for btime here */
+        if (bmval1 & FATTR4_WORD1_TIME_CREATE) {
+                p =3D xdr_reserve_space(xdr, 12);
+                if (!p)
+                        goto out_resource;
+                p =3D xdr_encode_hyper(p, (s64)stat.btime.tv_sec);
+                *p++ =3D cpu_to_be32(stat.btime.tv_nsec);
+        }
        if (bmval1 & FATTR4_WORD1_MOUNTED_ON_FILEID) {
                struct kstat parent_stat;
                u64 ino =3D stat.ino;


-----Original Message-----
From: bfields@fieldses.org <bfields@fieldses.org>
Sent: st=F8eda 5. ledna 2022 16:55
To: Ondrej Valousek <ondrej.valousek.xm@renesas.com>
Cc: Trond Myklebust <trondmy@hammerspace.com>; trondmy@kernel.org; linux-nf=
s@vger.kernel.org; anna.schumaker@netapp.com
Subject: Re: [PATCH 0/8] Support btime and other NFSv4 specific attributes

On Wed, Jan 05, 2022 at 03:40:19PM +0000, Ondrej Valousek wrote:
>
> >> - AFAIK support for RFC8276 in NFS (only version 4.2) server is since =
kernel 5.9, right? NFS client supports these as well?
> >> - The patches below implements the feature in both, nfs client AND ser=
ver, right?
>
> > Client only.
>
> Right, but then it will be only useful if we use non-linux based NFS serv=
er right?
>
> I mean simply:
> 1. $ stat /tmp/foo.txt   --> shows birth date
> 2. # exportfs \*/tmp
> 3. # mount 127.0.0.1:/tmp /mnt
> 4. $ stat /mnt/foo.txt   --> no birth date shown

Right.

Fixing that's likely just a few lines of code added to fs/nfsd/nfs4xdr.c:nf=
sd4_encode_fattr().  Patches welcome.

--b.
Legal Disclaimer: This e-mail communication (and any attachment/s) is confi=
dential and contains proprietary information, some or all of which may be l=
egally privileged. It is intended solely for the use of the individual or e=
ntity to which it is addressed. Access to this email by anyone else is unau=
thorized. If you are not the intended recipient, any disclosure, copying, d=
istribution or any action taken or omitted to be taken in reliance on it, i=
s prohibited and may be unlawful.