Date:   Thu, 6 Jan 2022 13:29:57 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Vasily Averin <vvs@virtuozzo.com>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna.schumaker@netapp.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org, kernel@openvz.org,
        linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfs: local_lock: handle async processing of F_SETLK with
 FL_SLEEP
Message-ID: <202112281211.SsWl4cfI-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6613b17b-43bd-07d0-2ca7-1581a39cdf7b@virtuozzo.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZNGSxBhj1I1s+QWvsjkWYpN1HEVFzkAmwDUe7EqBz0OvKwnaZ2EnjIYZ/Go2?=
 =?us-ascii?Q?xrxeGu1LlXdzLVoYKOQipJoYdo9pKdFF9XWZZyFxFZaSvV4ryRiRFBw7eTYA?=
 =?us-ascii?Q?RaoQP0otjv8tukXXTiPFYx03oRgSsU6Bv67GDTy7Ma7/F0ptVo96EvcrDFwu?=
 =?us-ascii?Q?h5+RkJtYODmosVqF54sm9uMJJ7cX5J/84wYbUEHdRorBCSRedT3L0CB7D+Am?=
 =?us-ascii?Q?7ChiFtyNjs85OvwWJuS+8UgneB6mTYBgLv3opRX8gv3QoUAKOVTe73ON4lOP?=
 =?us-ascii?Q?EjmpELPEpCSy+f+QegHZLcx+a3hmbbsSsqa/gf1OhXyWc4vW9FFMiacUFk1s?=
 =?us-ascii?Q?gHmcMInNBDXmPjeQU4z1ONWRWPzDxtcjsJlE/Y7LXXQfviFgJFCzGYhdQRvA?=
 =?us-ascii?Q?cYlQYndiK78QV/y4bFJafmoTHqcfGjWVeNBM6MpPZuHKbjLZ4fsokYW6Nf2H?=
 =?us-ascii?Q?5/abiwuyoiJVZJuQkdOFBcIyi4jCR9ynqQxHaVlUfcCr9KIHnsIQ6EXl5y40?=
 =?us-ascii?Q?sQDcOA6qKdkSe4G0VLgTmlESA3nxdy6eZ4T1iFtLQ6THKq/wzzL4eThCCaoy?=
 =?us-ascii?Q?wCnQWTPccBmrGLmargO9HBsma+w+qSH/nrsDCCyfiq3P/WFkbmiOrDdeXxo8?=
 =?us-ascii?Q?IDXRRqtSUpmHdKfSYDleMKSx7sDtneeUDE68eOxu9Tz6mqhhb2Sdl3XEkeGa?=
 =?us-ascii?Q?yy1L6VOD/6eV3RAiPQJtJBZHxEgMnJDyy/+lgCf+fIW327mmrXLDbkS+7RkM?=
 =?us-ascii?Q?YBZ3hEPy7DqBmVJAdxn/VMfhfw/DybXbkLwfV8paznA0dCUvO1/AZmPklDp5?=
 =?us-ascii?Q?wNwCUi3dH+0s7JwHToQxT14wyL/gM4xByKsnBJMAZmWk0zzyyXLeaHP4lIMm?=
 =?us-ascii?Q?uUQ7gKt2038GK7Ui94laa91+pHPsrlYgiF3kVWhX0Ojw6goFRYTDRysY6Ta+?=
 =?us-ascii?Q?Ln1aRSKRfDOya17EXUivUfQCTapbXtcazJllASzc6CAGHSiJQ3LwAEpgoRu/?=
 =?us-ascii?Q?Y/o2Jyt8SS/k70smF3KWniwjJhrA64dB8xaiNDjWU+BN3G3hI9ZxzqSepB3M?=
 =?us-ascii?Q?XMiQ7Vqbee7CMvFq6w7CpHMlu7sUd7JsveWpZWxfJKxf9JBkfjO8/uxCyyZg?=
 =?us-ascii?Q?gN363z4dp99aekidpuQ5F1doT+yUbFJSjjnLCcjRO6jOZeqbDm79crckClO8?=
 =?us-ascii?Q?RNVtut71k2AVwKnKBQ6ylsQRoVW6cNRfFqvPTfbMxk8pugUvzqrjMpt7tb9W?=
 =?us-ascii?Q?mE7SB9hPd3ycJet1kDSZdV6hpyZu45MyPnT+Ep3Hw4y6VdwStvmwj7AcfgsW?=
 =?us-ascii?Q?+WOOff/xyD1nU6tVCOZH9/sLRjmgJu7SfxTkfFVBn32hdLdynPtcAO4rNuFe?=
 =?us-ascii?Q?wDTkgY7gi1i/SGlsaT5TNAMB/KNC8ZOBP6HGI1bMpab5TZfuK1Ho6jmgXTFH?=
 =?us-ascii?Q?eGyJo6fddKZV49TlZVgAX58fALbx49gjKskc3LCfar0fA/gviJlth+XtmqEW?=
 =?us-ascii?Q?fkaaOox9FubNcwcrXP4J/jLTlN6u8yFEUwhbz/nySQ5ICw6x/Z5bovjN0pCq?=
 =?us-ascii?Q?4HFKH44I8eAfYsIVUDQGqyHz8jbWaB1qXUZGZVrkxZKZQF1lqxf1hT087YqT?=
 =?us-ascii?Q?1JbWYdOjP7bW9HcZPVN8j5HcZgmNjo6kRR0aIt3CoaUbBsDXJfbbvpAHKGeC?=
 =?us-ascii?Q?aUEk643nCy+yY5AZUtrXRFSt3Fs=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48cdbd5d-f290-418e-4b3c-08d9d0ff8884
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2022 10:30:17.8994
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TY9kybB+1WM/cvsxSkdiWizx1IxEFGfgXS/aYPQ8kEaATU2jNUBoTPE5Mk/pDxIGKLuLtsNLc8DBdmPyY8pRxW/BCJOaT0VSo8U1Pf0jnCM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1885
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10218 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 mlxlogscore=999 phishscore=0 malwarescore=0 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2112160000
 definitions=main-2201060074
X-Proofpoint-GUID: w-csOos1BsLRa7R_bJm4ksyPkLfEHbEU
X-Proofpoint-ORIG-GUID: w-csOos1BsLRa7R_bJm4ksyPkLfEHbEU
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hi Vasily,

url:    https://github.com/0day-ci/linux/commits/Vasily-Averin/nfs-local_lock-handle-async-processing-of-F_SETLK-with-FL_SLEEP/20211227-184705
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: i386-randconfig-m021-20211227 (https://download.01.org/0day-ci/archive/20211228/202112281211.SsWl4cfI-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
fs/nfs/file.c:772 do_setlk() warn: should this be a bitwise op?

vim +772 fs/nfs/file.c

5eebde23223aeb Suresh Jayaraman 2010-09-23  752  static int
5eebde23223aeb Suresh Jayaraman 2010-09-23  753  do_setlk(struct file *filp, int cmd, struct file_lock *fl, int is_local)
^1da177e4c3f41 Linus Torvalds   2005-04-16  754  {
^1da177e4c3f41 Linus Torvalds   2005-04-16  755  	struct inode *inode = filp->f_mapping->host;
^1da177e4c3f41 Linus Torvalds   2005-04-16  756  	int status;
^1da177e4c3f41 Linus Torvalds   2005-04-16  757  
^1da177e4c3f41 Linus Torvalds   2005-04-16  758  	/*
^1da177e4c3f41 Linus Torvalds   2005-04-16  759  	 * Flush all pending writes before doing anything
^1da177e4c3f41 Linus Torvalds   2005-04-16  760  	 * with locks..
^1da177e4c3f41 Linus Torvalds   2005-04-16  761  	 */
29884df0d89c1d Trond Myklebust  2005-12-13  762  	status = nfs_sync_mapping(filp->f_mapping);
29884df0d89c1d Trond Myklebust  2005-12-13  763  	if (status != 0)
^1da177e4c3f41 Linus Torvalds   2005-04-16  764  		goto out;
^1da177e4c3f41 Linus Torvalds   2005-04-16  765  
5eebde23223aeb Suresh Jayaraman 2010-09-23  766  	/*
5eebde23223aeb Suresh Jayaraman 2010-09-23  767  	 * Use local locking if mounted with "-onolock" or with appropriate
5eebde23223aeb Suresh Jayaraman 2010-09-23  768  	 * "-olocal_lock="
5eebde23223aeb Suresh Jayaraman 2010-09-23  769  	 */
5eebde23223aeb Suresh Jayaraman 2010-09-23  770  	if (!is_local)
^1da177e4c3f41 Linus Torvalds   2005-04-16  771  		status = NFS_PROTO(inode)->lock(filp, cmd, fl);
00e7edbaaa914f Vasily Averin    2021-12-27 @772  	else if ((fl->fl_flags && FL_SLEEP) && IS_SETLK(cmd))
                                                                               ^
&& vs &

00e7edbaaa914f Vasily Averin    2021-12-27  773  		status = posix_lock_file(filp, fl, NULL);
c4d7c402b788b7 Trond Myklebust  2008-04-01  774  	else
75575ddf29cbbf Jeff Layton      2016-09-17  775  		status = locks_lock_file_wait(filp, fl);
00e7edbaaa914f Vasily Averin    2021-12-27  776  	if (status)
^1da177e4c3f41 Linus Torvalds   2005-04-16  777  		goto out;
6b96724e507fec Ricardo Labiaga  2010-10-12  778  
^1da177e4c3f41 Linus Torvalds   2005-04-16  779  	/*
779eafab06036f NeilBrown        2017-08-18  780  	 * Invalidate cache to prevent missing any changes.  If
779eafab06036f NeilBrown        2017-08-18  781  	 * the file is mapped, clear the page cache as well so
779eafab06036f NeilBrown        2017-08-18  782  	 * those mappings will be loaded.
6b96724e507fec Ricardo Labiaga  2010-10-12  783  	 *
^1da177e4c3f41 Linus Torvalds   2005-04-16  784  	 * This makes locking act as a cache coherency point.
^1da177e4c3f41 Linus Torvalds   2005-04-16  785  	 */
29884df0d89c1d Trond Myklebust  2005-12-13  786  	nfs_sync_mapping(filp->f_mapping);
779eafab06036f NeilBrown        2017-08-18  787  	if (!NFS_PROTO(inode)->have_delegation(inode, FMODE_READ)) {
442ce0499c0535 NeilBrown        2017-07-24  788  		nfs_zap_caches(inode);
779eafab06036f NeilBrown        2017-08-18  789  		if (mapping_mapped(filp->f_mapping))
779eafab06036f NeilBrown        2017-08-18  790  			nfs_revalidate_mapping(inode, filp->f_mapping);
779eafab06036f NeilBrown        2017-08-18  791  	}
^1da177e4c3f41 Linus Torvalds   2005-04-16  792  out:
^1da177e4c3f41 Linus Torvalds   2005-04-16  793  	return status;
^1da177e4c3f41 Linus Torvalds   2005-04-16  794  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org