Message-ID: <46407a8e-8011-9cdc-4db5-5679e2b59957@oracle.com>
Date:   Fri, 7 Jan 2022 11:15:43 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: pynfs regression with nfs4.1 RNM18, RNM19 and RNM20 with ext4
Content-Language: en-US
To:     "J. Bruce Fields" <bfields@fieldses.org>
Cc:     linux-nfs <linux-nfs@vger.kernel.org>
References: <CAPt2mGNF=iZkXGa93yjKQG5EsvUucun1TMhN5zM-6Gp07Bni2g@mail.gmail.com>
 <20220107171755.GD26961@fieldses.org>
From:   dai.ngo@oracle.com
In-Reply-To: <20220107171755.GD26961@fieldses.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFpjNUtKK0lKUjMwTjI2YlFSeldCWWIrcGVaeHFQclViQmdCUjJFcHljRTFp?=
 =?utf-8?B?NnJqZUhCdEQ4NEt0Qkc2Zm5oK0xkQ1BPSW9OY09Za0dCNEJJL2Q4bjRTcFVp?=
 =?utf-8?B?RGdLRXo2aVRadTFnbTBRYjIvVXVjK0s4SmRVWDVsakRZcmJiZkRWdkVJTGhR?=
 =?utf-8?B?cmV3dlRjbXlUTHprdGFONE5CaERkWXNmWUo1YUs1cVBXUmdoWVR2VldDVmpW?=
 =?utf-8?B?SHRNYkpVTlpPeFg5Mk50aWFCc1NacnN2bkVFSW5qbDl5TmsrTTRaMVc2WVNX?=
 =?utf-8?B?bFBJSlNBNEthT25XKzhzcjJDWWtVMHNMZmJwUnVvMzIxdGtaaFovRk5LcElF?=
 =?utf-8?B?aUR4R0lPNzJhYU1DUVNoZk94NCtlNU94M2thUW1lWU43cHpwZjRUbFpsTWJh?=
 =?utf-8?B?cWp5ekNaTkp5K0FkRXZXaWhPZUVMSEZCRStTMGpjV1phRm5lb2NvQzF1ZWdq?=
 =?utf-8?B?ak5MQlplNXRyTytWTHk0YWVibE5tL2QwaldvbUhmNUUvQVl6QTQ2em85cUZk?=
 =?utf-8?B?WnVGTDgwSmQyUVpVMUpyZzhYTUd0RkFyTHpVcDF6c003M2lVM2dHT3VyVHJh?=
 =?utf-8?B?dG9yRFErMTAyaXFqL1BvQXduMzFFVERrSTR6QWdYMWRJUVpzL1JYQ1AvSDkr?=
 =?utf-8?B?bWpOME5PRkpiTmFGL095NWQ3dmd6N1hZdEE4SUVDMHptRUlmOEg4ekhMY1BQ?=
 =?utf-8?B?WnV5ay9aM2d5Znl4T3N3UVZWczhCRGlYTzFtMU9FR2d1QXNjbXlMcndrWlZT?=
 =?utf-8?B?M3BxV3E1ZC8rUVBXdDhHOFU5VFJoUERJR1IxelRSaU9HSGZibU1pNXFBYTVT?=
 =?utf-8?B?VjQ5aHE1aGpJZlpFcUlCL2J5d1RVcDZ0ckgvU3Z3RkxBdnBKMXFWdlFTSXM2?=
 =?utf-8?B?L2Q3cGN4Y2FUM2htOFhHaVV0UWVwOFMxVk1xOFRUc21qN0ZBS041c3FFSlNs?=
 =?utf-8?B?eVlEdmp1N1I3VUlZcDV0Q0FRUk4zdDByMFNuaFg1ZGhmYUtqQWFxWGtsYmJo?=
 =?utf-8?B?dkdpU1hPWmhRaGFZaFdOYjE0aUNKYUlLMGo0V3ZEVnhYNTYwY0E2bUNybkxr?=
 =?utf-8?B?RHoxRnErQWZuKzN3Y0luejZBQVdjZWJ4dVFrVFhGd3JhNGd6NVdKTzh3YzFR?=
 =?utf-8?B?Q3drUDZwbW1PakRLSmdVNU11b3k1VUtVZjVMcnozZExBc2R3VUswU2Jnb2RS?=
 =?utf-8?B?ekpMbHlhRWVoMmNZWHhiN01mWXBJOW9NeTQxbC84bjlKK2F5R1V6WFVIMTgz?=
 =?utf-8?B?SHJsdUZSSERVYUZqVmU3bEhUZE9CTzhkRUdXeVdrTW0rc29GaklTY1N2S09t?=
 =?utf-8?B?M09HZlNuRnR3cHRYRWhlZXVkek5WSUtiSWx2amdQc3JiRmFpRElUWXRCUXo4?=
 =?utf-8?B?M3NJM0dpeDhIRE5XM2tRSTRrazI1b3E2bUR5RjUrNUdqanZFd0ZwUjhOc1Ux?=
 =?utf-8?B?aVJteVQ5SGFTOUhuSWJRdC9NTG5UeENSYzZPdWc4ZG9xalFmZXJaUk5MUmJs?=
 =?utf-8?B?Z2JSbW5NQ3FxRkpmbnZzZWI0T3V2ZGMrRmlZUyt2b29HNFJzemRIYXZsOHBn?=
 =?utf-8?B?NmttcDJXbUV2Y2k1UmRhQy9UcWw0YnNkU25oK0tuMklRY2VrVkpsNVM0ci9x?=
 =?utf-8?B?K3dOaWNqa0RhT0RiRUppZEFMZUw0YWZrcE95QzlnUjN0cm1RVFgxSFB5SHBG?=
 =?utf-8?B?SzV4K0haL2YxWGRtM3Z0TTF0NGNrTVFkR1E0OFhCeFQwSnRqTDd2MkgrQy9P?=
 =?utf-8?B?UWtRRGdlR3ZuLzRydFRVdlFxSE85Z3hpZ013eUtmejdDdmpnc0FWRmtrTnhY?=
 =?utf-8?B?SGxibk9TU3hDTkduYjhwZ3Bqa3B3SGJ2TGh0eGlpQnB2VGI4LzNTSktxb2dt?=
 =?utf-8?B?V3QwZ0ZIaDFKZzZxdHZjaElpNEdPZGsyeTJFNiszNkk2VXJSYjlTUmNmR1Bv?=
 =?utf-8?B?TXU1Tmo2T0M5TDEwalFsaURZeUMvNmtyR3Z0SFQzMURHdXVKelBvZTRxUXVq?=
 =?utf-8?B?ZUg4WUZzelRqZVF0ZVdQMzUxK2p0eGxFby94VjZuWFIwLzFXUnRUWU9jeTl6?=
 =?utf-8?B?UVpCT3pwcHNXc1JFbytnWDg0TS9nSUZYT2daT1R6QUM5SUNWWGlvc25HSjJZ?=
 =?utf-8?B?VUpSQTdDZVNnNjJiZklqOGdFeHlmYmpOSDJnV003NHNDWThEendWQWg3OXFt?=
 =?utf-8?Q?K0vz+RyIeHHLf2hdjlgRIGA=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 247c8868-3e8d-481d-dcd2-08d9d2121ab3
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2022 19:15:45.1218
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nDrlnM99ZTkc336LQjb33+iI8bd6HrhZ0CTJtGGk0xxtVfAoKzpJTtx9xMCREBVgcJXqrVMIZzx05obehMnYvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4386
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10220 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 suspectscore=0 phishscore=0 spamscore=0 bulkscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201070120
X-Proofpoint-ORIG-GUID: 0dLlMAMGXztUttCJzGIW2SCJ_XBSP6a1
X-Proofpoint-GUID: 0dLlMAMGXztUttCJzGIW2SCJ_XBSP6a1
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hi Bruce,

Commit428a23d2bf0ca 'nfsd: skip some unnecessary stats in the v4 case' causes 
these tests to fail when the filesystem is ext4. It works fine with 
btrfs and xfs. The reason it fails with EXT4 is because ext4 does not 
have i_version-supporting. The SB_I_VERSION is not set in the super 
block so we skip the fh_getattr and just use fh_post_attr which is 0 to 
fill fh_post_change. I'm not quite sure what's the fix for this. If we skip the fs_getattr
for v4 thenfh_post_attr is 0 which causes the returned change attribute to be 0. -Dai