Message-ID: <91f66c99-aac7-e47d-4c4e-b02d4b4778a3@oracle.com>
Date:   Fri, 7 Jan 2022 12:01:57 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: Re: pynfs regression with nfs4.1 RNM18, RNM19 and RNM20 with ext4
Content-Language: en-US
To:     Chuck Lever III <chuck.lever@oracle.com>
Cc:     Bruce Fields <bfields@fieldses.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
References: <CAPt2mGNF=iZkXGa93yjKQG5EsvUucun1TMhN5zM-6Gp07Bni2g@mail.gmail.com>
 <20220107171755.GD26961@fieldses.org>
 <46407a8e-8011-9cdc-4db5-5679e2b59957@oracle.com>
 <3D2F2375-DDF0-424F-925A-B3BF4457FFE2@oracle.com>
From:   dai.ngo@oracle.com
In-Reply-To: <3D2F2375-DDF0-424F-925A-B3BF4457FFE2@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTRNQ0NOWE1xZnZEbjdnRTRJRXVQTjQrR2RURE5vWHpHSzV6TERQLzVpVVEw?=
 =?utf-8?B?ZGtiRUVGZEtVVk5wNDREY3d6VkZFZ2hFMFo3N2phSG90UGdmNXNTT24zUGsr?=
 =?utf-8?B?ZW9vRVNtUkFiQXczcXlTQU4wNVpCUFdXTy9qK1BoRHlzZVowRkVpL2JKTmZn?=
 =?utf-8?B?Q01pNWhXMk5BMEp6Y0VYblc5MGNScGYrMFhZOU9XYkwwRTdOSDgzYUxPWktv?=
 =?utf-8?B?MVdVWkJVSHBRdzMwWVBBSjBNQTE1L1BVaWQ3VGZJcTVTUk85bFlHbmxHeCtZ?=
 =?utf-8?B?ZnUwV2c0NXZVU09QTCtINFpjcm83WmNDMlpLU0NIVmF3eDBxR1VUdXp3UHN2?=
 =?utf-8?B?MUxPTzFiTHJDRWtqMnlBNHFCalJZVmtrVXR0L1N6d3paVkpHSUJLSGhZUklJ?=
 =?utf-8?B?MkZ5VlorZlN3WUpNVUt0M1R6SVFTSzdETTdYTFVoKzh5bEVoZFJTM1NqMmVU?=
 =?utf-8?B?eGZUcUpSK0FQOUR6MzNuOVZ4ME9tMHgzK1dOU0RWeXBqUTBxQ3ZNR1pDeHdW?=
 =?utf-8?B?OGxDazV6Qmo1SzBJbU1nQXhCMmJDODlKV2JlblRWK0FKZVEvUSs1VzNCc1pj?=
 =?utf-8?B?MmgvVHE1dGtkZWI3aTRqK0Z0ampWWU0wL3YzN1Z6cEtmOGNBMFZRVjM4b0Jr?=
 =?utf-8?B?YVdzUVM1ZGRzMENGQUYyWEo4MWJHM1lVenFVNldYRXBMak9XbnZpYUpSZU9t?=
 =?utf-8?B?NUNXN2pOaC83NjlGc3U3TUttL1NMMkpEekE0aVlSK0NxaVJxRExaYXUyS1Y5?=
 =?utf-8?B?eTRYNzlYY1RmbytDUEQ0eW04TW0zb250VU9UWXlvbEtHVHdCWDFVeUFZbGFK?=
 =?utf-8?B?M21NQ1gzM0VYSjZqZmdkc2k4UUgwOWdSSFVzR0NDbEhxZEtXSk1QYnFBYzVs?=
 =?utf-8?B?czNNSmFxSVJCS21EaWg5VUtrZlZ2MmFVVGZtTWZVbWVJTkJaNzk0c2FFSVBB?=
 =?utf-8?B?ejF5d0M2MExENU9waUZ6UEFlaG1CWkVtNlhGbGl0L3pObWdTenhPa0JZeWNX?=
 =?utf-8?B?UXZpYWRRNVhQMG1lQlkvQjJuUks5Qm1DOGFxSThxQUFoTmdCbW1CeFhXNlgv?=
 =?utf-8?B?OVBGQzZZNHUzaENWOExVUUxqMWVrditrcnFUeFExZ2swSk1WSEVpckZKNDRI?=
 =?utf-8?B?RlF4b3lyUk1wV1JHNmxhQmdrUVczY3kwQkUyWmIrUDVqN25nZFlRTzBGTm96?=
 =?utf-8?B?eVk5bkhsV1dBYVRlVklUVGpyRFUvcHgxS3VERFlJRElGeG8yK3ZYM296OWJ2?=
 =?utf-8?B?dWY2d3cvQXJSMU93RjZhSW9ubzV5TjVyZ28yUUlqQ2tma214QTFEWXRLOGlM?=
 =?utf-8?B?aWFyeFpDQzh3eERKemJJckd0K2hQOE9mMUkzVFVHeHM2UmpYUWlIWkd1TTY5?=
 =?utf-8?B?cnUvRjEvN2o2NG96c090MWZYajJVYXgwdXNyVnpHZWJyd2JQekRPSThUczFv?=
 =?utf-8?B?dGpGNW5QZ0JBbUdDVW01ZjhBV29FTnh5Q0lVeU80OWx5bDVYdWE4SkJyeHN0?=
 =?utf-8?B?c3UvQlZjN3BpUEhjMmpWTm1pVnVMTlhCK0hzYUZkQlNvWHFtRElpZ0w1b2Fh?=
 =?utf-8?B?SUQ2YTQyZ0ZUazIrbGxDcjFmbjBoTStsSGMrTXJNU1ZuV3I1bVVJSFpUUUdC?=
 =?utf-8?B?ZUJXMkxVT21IVlFSOWRSRFd0b1RBQmxEWjhnU1FxUkNnK2Y0ZlVqUk5oMEVE?=
 =?utf-8?B?MXhaN0hMLzMxVXJZOGlMWU1DYWhWOFkxeXlFTTY4WGYrYUJXR25xd0Uwampw?=
 =?utf-8?B?dklvazQ3MFFMNVlSQU5tNFVhTk9sRnVPbHdSSFhYZElXb0RtVVREK0tDU1p3?=
 =?utf-8?B?djJlWmlmcFluclI3S2tKNmJhN3MxSVd5QjBQY2wwZUw5cmdQanJmYTh1b1Js?=
 =?utf-8?B?VFVkOW83aWZheUZZUmc3RDdzNHBtVkl6R250K2RoOXRXT1hMclhDY3M3MSti?=
 =?utf-8?B?V1JhR2lwY1I1ODI3NFkyTG02eFFodDlHMDY0RzFYblh3Wk5lTHNTcTVYSk9a?=
 =?utf-8?B?OXl1cFFyQ29UQmZ1TmM2Z2YyUlQrUXBzZDQ4dXc4N3Jway9VN0JzWldabUF2?=
 =?utf-8?B?bHVEM2FQWWtQOHQ4Vmlwa01QS0E2c3JYVlhMd0F0UXN6OXc4L2JBenB3K1lH?=
 =?utf-8?B?TTB3WHdDR2tsOFZXdjBUbTFjV3pPWWVFdzBvOGFvRDdTNjllVnVxNEpNYmUv?=
 =?utf-8?Q?Vgwd1mN/6JJDdQh8p1PRM/U=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14c75bda-8c0a-4a81-9da1-08d9d218906d
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2022 20:01:59.5348
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eude74lUAdQx9WnxaNWPMCulrlg+msffXUdwUhrLNKpDKpcAegyWjKqHIHUO4R7zzGwX+E425kqp6Js41wlbqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3954
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10220 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 mlxscore=0
 phishscore=0 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201070123
X-Proofpoint-ORIG-GUID: Z_jNVAPwomhtFECrKgzkiSUSt2UJSfX8
X-Proofpoint-GUID: Z_jNVAPwomhtFECrKgzkiSUSt2UJSfX8
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


On 1/7/22 11:41 AM, Chuck Lever III wrote:
> Hi Dai-
>
>> On Jan 7, 2022, at 2:15 PM, dai.ngo@oracle.com wrote:
>>
>> Hi Bruce,
>>
>> Commit428a23d2bf0ca 'nfsd: skip some unnecessary stats in the v4 case' causes these tests to fail when the filesystem is ext4. It works fine with btrfs and xfs. The reason it fails with EXT4 is because ext4 does not have i_version-supporting. The SB_I_VERSION is not set in the super block so we skip the fh_getattr and just use fh_post_attr which is 0 to fill fh_post_change. I'm not quite sure what's the fix for this. If we skip the fs_getattr
>> for v4 thenfh_post_attr is 0 which causes the returned change attribute to be 0. -Dai
> I've got a fix for this issue scheduled for v5.17, and hopefully
> it can be back-ported to stable kernels too.

Thank you Chuck,

-Dai