Date:   Tue, 11 Jan 2022 10:43:09 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     richard.sharpe@primarydata.com
Cc:     linux-nfs@vger.kernel.org
Subject: [bug report] NFS: Support statx_get and statx_set ioctls
Message-ID: <20220111074309.GA12918@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?K7HuYodgQBZRnYE9qnjEhjBsvIQjookkMWW/Yqj9aAncy+Cu0ME6pFcbSE8R?=
 =?us-ascii?Q?pmD/6D8UeMJadV9ukuFKXxmqD6vOEplse4p6dXAK4PgDLRq7RKYeHhwC+Vvu?=
 =?us-ascii?Q?S/pdY2BtjzW7AeQF0VfbTauJc5wbcS7j0Y4FFTR2tLU1Lvllvuu3P1UaskOE?=
 =?us-ascii?Q?VcZdRtE+5tm5WVA1eq+D/45wd9y0gB9DSJ5KRnvh3J7s8HL1mF8TOvqItAwN?=
 =?us-ascii?Q?W01hafDr+JlUilFOHh8kPU3wJarfu+ZJtB0o6smTiImqy0RieIKkl5qvKn+h?=
 =?us-ascii?Q?pyX4RvkvlzvjfKWswLME5ZFusp67OQftn3XSAVE2woWt/XvoqgP/R4rlmdN2?=
 =?us-ascii?Q?JEDkip7viMWiOFnNXio+F6XVy0FqqFqRvDHvhQs6UyA/0COi3iEPSaVLNtI+?=
 =?us-ascii?Q?QxihqpU4aP7I+L4t3NyDWT9jLOFqmqBJATdI01WUG+cRMi2eDElqUALkchXF?=
 =?us-ascii?Q?kHBqG+4BMEnnsDB09rhNaiXP+H9i2HIqAWc4njbkY6K99m4G1Fg+g7JOuJJl?=
 =?us-ascii?Q?KZZMtoDBJQqAy58NbBHKr+E7a0VTjs5fgk6U0PY9vseDVCg2J4UEQXb3aU49?=
 =?us-ascii?Q?hF84HgwiltNW15fDFrqzflWi9+ZoQ9bn1M46nZj7EcfVOiuc0L9ylACXGRKB?=
 =?us-ascii?Q?JjhhPqBTXl5gBGuxdpeqJLIFQiEnr4vkYHLVgXunNBVyEAPQUzVUy8Xj6pqO?=
 =?us-ascii?Q?CEXiJiNbx8fn9HL+CbpR265qpi9hN5SdWCle36AFjvCFZuyWGHxyhjkvEWcc?=
 =?us-ascii?Q?l+bO1OQWU/vcFITyY2IaWqSkWwhB0y6iIbaGp2oMzPAGJ+NSInaVoDx83oSs?=
 =?us-ascii?Q?b63I4mv9sD4lCdcBuS8oUADaLmPwZHWqB3ErouUp2PSROay9tgTo3ze55S+K?=
 =?us-ascii?Q?u7LwCosyeVWN2DpLmF4SAJGSXzuNRsdSU1De3QporeeV+sNn/oGoMkeqjsUf?=
 =?us-ascii?Q?WwnojPCIngX/Z+ueX4PjtophW+I7YKirvCcmftaYtCcusGqWucVMVItNODS1?=
 =?us-ascii?Q?Hv6nDiL/r4RFdtFkdsu827abbeIamVaGfSwH1hkJc5hWxIDox/iCxZVm4G6H?=
 =?us-ascii?Q?SWaIiQYKk8+vUZuOD2AffH0YW2i9ys1rMK0aySZQ40dNaGvKD7xA/6ZHdTCB?=
 =?us-ascii?Q?+40iiYESLEK8/mB54WJrGKSXdztI8odyiZc3FhF53UYKZ/O0yoa03zWyr08Y?=
 =?us-ascii?Q?/djde8r2EcKnG9n1n7BUGbgNiPath+woOriOf+Zur03hJAvqWiV4zcQPVVOS?=
 =?us-ascii?Q?oozlC7+uw78XZQjTxZMQtx/x5KAKLYzVzNw+SYIv6j3g6+4ybCeORxBSoo48?=
 =?us-ascii?Q?9MCnW53X4UVONSU/4rxBfrC3bwwsK99fbTB75zNqJsaM5x/wAGXe6dO76m8R?=
 =?us-ascii?Q?TIGUv8VZ+b5DvGMtJqrgc126tOVTP4lNzwNjTltkBTxrBwczjNZk2oJhbviJ?=
 =?us-ascii?Q?QWQh/OoZTkinBLMQFtVLRFXZZTRFHao8Z+x8oQsfx5mzqIlOKX5edIuQFuF4?=
 =?us-ascii?Q?i2Xd9EYuXdyFBUddhaFQ8mbi50TzO467NqXsrfR0Vl3TmWofko6W/ZFWna3V?=
 =?us-ascii?Q?ZbPPOcvACeW5M/VIHto7kTezcISoo2wYGZAzA5r5GbTT1La6CJZX5YhbBhw4?=
 =?us-ascii?Q?naZXYTszK2khfn745Cs8Knx3gARTiUuYxw0Y1UMcbcSXUjPEgugBGd7+rmsE?=
 =?us-ascii?Q?tzQOVd//b1OEyS8kfDN5r2w82Kc=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a8e3dad-1d46-440d-10d6-08d9d4d60937
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 07:43:19.3423
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 82Q6jQ8IWVVfwX5+pCh8KsGpU3f/sxsElA1k5gSXBqEx7dYjlcshtN5VMTXZG+YRVAMFcEeDIQInywa01XJS7/n0FDeiWW9YSFfSIJBNT08=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1950
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10223 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 adultscore=0
 suspectscore=0 mlxlogscore=898 bulkscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201110041
X-Proofpoint-ORIG-GUID: f7QW55WYm_0oFcg7kB2FZdDABbzQuAXN
X-Proofpoint-GUID: f7QW55WYm_0oFcg7kB2FZdDABbzQuAXN
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hello Richard Sharpe,

This is a semi-automatic email about new static checker warnings.

The patch bc66f6805766: "NFS: Support statx_get and statx_set ioctls" 
from Dec 27, 2021, leads to the following Smatch complaint:

    fs/nfs/nfs4proc.c:8035 _nfs4_set_nfs4_statx()
    error: we previously assumed 'statx' could be null (see line 8026)

fs/nfs/nfs4proc.c
  8025	
  8026		if (statx && (statx->fa_valid[0] & NFS_FA_VALID_SIZE)) {
                    ^^^^^
The patch adds checks for NULL

  8027			sattr.ia_valid |= ATTR_SIZE;
  8028			sattr.ia_size = statx->fa_size;
  8029		}
  8030	
  8031		nfs4_stateid_copy(&arg.stateid, &zero_stateid);
  8032	
  8033		status = nfs4_call_sync(server->client, server, &msg, &arg.seq_args, &res.seq_res, 1);
  8034		if (!status) {
  8035			if (statx->fa_valid[0] & statx_win) {
                            ^^^^^
and unchecked dereferences

  8036				struct nfs_inode *nfsi = NFS_I(inode);
  8037	

regards,
dan carpenter