Date:   Tue, 11 Jan 2022 10:58:28 -0800
From:   Roman Gushchin <guro@fb.com>
To:     Muchun Song <songmuchun@bytedance.com>
CC:     <willy@infradead.org>, <akpm@linux-foundation.org>,
        <hannes@cmpxchg.org>, <mhocko@kernel.org>,
        <vdavydov.dev@gmail.com>, <shakeelb@google.com>,
        <shy828301@gmail.com>, <alexs@kernel.org>,
        <richard.weiyang@gmail.com>, <david@fromorbit.com>,
        <trond.myklebust@hammerspace.com>, <anna.schumaker@netapp.com>,
        <jaegeuk@kernel.org>, <chao@kernel.org>,
        <kari.argillander@gmail.com>, <linux-fsdevel@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-nfs@vger.kernel.org>, <zhengqi.arch@bytedance.com>,
        <duanxiongchun@bytedance.com>, <fam.zheng@bytedance.com>,
        <smuchun@gmail.com>, Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH v5 04/16] fs: allocate inode by using alloc_inode_sb()
Message-ID: <Yd3TVKpvsBmZM51k@carbon.dhcp.thefacebook.com>
References: <20211220085649.8196-1-songmuchun@bytedance.com>
 <20211220085649.8196-5-songmuchun@bytedance.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211220085649.8196-5-songmuchun@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rOpV2mUq8J5R7g3AGVlFqnuUwkFF0+O/DCCg4oy6TaxzfFG55dcuHOzbzoZp?=
 =?us-ascii?Q?ExgynluDKDARF2w8mgoFEQ3ypL2B7Gvqr4fOLZ0SnZFf2IqWC40lcYxvFerJ?=
 =?us-ascii?Q?pDNolmsr902IiLs2D4h5ptC5ceohCjL8/XuocNfmC9fn7lTs8zjsWT9F9cdR?=
 =?us-ascii?Q?RGD9iFLOq6o9CJDTtWrHIq/SQ4a/t9yAzWb7+nCmeCRYQ8wYve+BGpp39/uP?=
 =?us-ascii?Q?eRomdkL+dmX3pXhM3t1Rwf53Jbbbx7KJLsPXrXwTn4U9mNlejf418c0KMqx1?=
 =?us-ascii?Q?0bfcdvpWLTwV6hqaN32jV8aCDIE+MOJ60yg7TreSy7nhrLrf7w3JyIYHdFwn?=
 =?us-ascii?Q?651U2JHZ3QRRAMJA6go5sIU5RG94f77wpEhLl/TmJO1EoECN+/9sViEVQ2Ap?=
 =?us-ascii?Q?tx1UGIiVDs73sSsKApQEQA2zF1MZrpc0xJiz4nBwOY9zgleEZYU6afpqDjxQ?=
 =?us-ascii?Q?TMAij7UoZcP2zCtERELqSLLNqtvPCHL/7mvUGe/y8LbRO2DC3hxo9p6mA75u?=
 =?us-ascii?Q?pGd7SWcYpjw0S0acEqGRnrXRkYXcp/8GWVy4zCVMtvvkmR1m/IgIiE4ZG1U5?=
 =?us-ascii?Q?YE0F2HDPxsLTaGGyEOOE15/J/MrVrSCsyNPA05FeW6I6cVbGlS0IBG8uvs4Y?=
 =?us-ascii?Q?vEVL3nNOkGbMXpdDjluHcfK8+71IWx/Pcb3MyfGcgZYf8ZYPBifcH03C7Xgl?=
 =?us-ascii?Q?Q5cVJJ1GV3TUQIU3UHmMf9tuhIuwbMQXNo3uks7AlCstNdpwT0XjBIJg4KjA?=
 =?us-ascii?Q?B/FO6N8eI+qKm0JlV40pVd+JLuWWB10YufEDUpPiVaZ7gcQ/s9Irz6YEDjsp?=
 =?us-ascii?Q?sQUGKPCB357PUl5LbUeh7mj2OKzPd3HgCXLWBdEzuKE+PrdoYDovWv0tfy5V?=
 =?us-ascii?Q?SNK7LGeKceU8prZ2pih5LEZAzgPwwHwhCEHnazSXDfCQCkZrOFkk00pgLS53?=
 =?us-ascii?Q?pow//ClJyodrowQ+4+r91OpzsX2qNs9sUrloluKbJO6ZO4+2zlty8gcuq4kZ?=
 =?us-ascii?Q?HwZVXq3aqz9u2N+3sUB4o68SKs9Y7w3Ti9n1w/j4aKzNyLMQBDw+6L8ROsya?=
 =?us-ascii?Q?uc9jSOn69rHxbE/Pz/0FeMQbJmztnvwfRRK8OW6d4VSVJcUo9gTWdJ/ppx+H?=
 =?us-ascii?Q?e5XPfSua5tCSle1/pruisKfM3P41Tpw/lGvrTKZ3apkUaOsDpKsTJVOjG9ad?=
 =?us-ascii?Q?OO7Hhtr+lURUTgIca/6qmkOvk+7BwdLGv8WpYiC+Y9oWgN1gW4IJV/OkqxiS?=
 =?us-ascii?Q?F2tL9+vMXiV8x1ZxV3izskuQLMWhHyg+yT8RyKkv8ygDvXmCvtGE235iKOpP?=
 =?us-ascii?Q?iUqh01L6txGQAKvUxK+UJEEynmHVQMq1KCj/4XyctGvI+mHdi0j1rCxffcQK?=
 =?us-ascii?Q?2ubQNRsfua95gr+x9KAcVAc3Eo/AoMkLn4HRmIJyaOiu1qL/uJHXXUpWGqJZ?=
 =?us-ascii?Q?ydBD0H8UAsroUC4tNRZvBlBlR3fJnQqw8aAl53kcUbrV8BX1L+4DndtvajZQ?=
 =?us-ascii?Q?fZFP0ohxD5r+LEyPTO7N79OlzeLjaXsUn3gRW8CLn8sb4xRM8mxt1vbZP9Wg?=
 =?us-ascii?Q?qCBxMB4G7kfisSQx504go7we14D6o/BvFKWGA5tX?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cd83de91-29ec-4c48-26a6-08d9d5345d7d
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 18:58:33.5165
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5TPyawRzs72MGQhT1loT+3URH5k8IVHc/2af8CdgNFExPMiKQ3BjP7N6DQvJIGvn
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR15MB3683
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: Zb4T-NJrrWHWPOptw5qOaJEJfloaongh
X-Proofpoint-GUID: Zb4T-NJrrWHWPOptw5qOaJEJfloaongh
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-11_04,2022-01-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 bulkscore=0 mlxscore=0
 lowpriorityscore=0 phishscore=0 clxscore=1011 impostorscore=0 adultscore=0
 malwarescore=0 spamscore=0 priorityscore=1501 mlxlogscore=816
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201110102
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On Mon, Dec 20, 2021 at 04:56:37PM +0800, Muchun Song wrote:
> The inode allocation is supposed to use alloc_inode_sb(), so convert
> kmem_cache_alloc() of all filesystems to alloc_inode_sb().
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> Acked-by: Theodore Ts'o <tytso@mit.edu>		[ext4]

LGTM

Acked-by: Roman Gushchin <guro@fb.com>