Date:   Tue, 11 Jan 2022 11:03:03 -0800
From:   Roman Gushchin <guro@fb.com>
To:     Muchun Song <songmuchun@bytedance.com>
CC:     <willy@infradead.org>, <akpm@linux-foundation.org>,
        <hannes@cmpxchg.org>, <mhocko@kernel.org>,
        <vdavydov.dev@gmail.com>, <shakeelb@google.com>,
        <shy828301@gmail.com>, <alexs@kernel.org>,
        <richard.weiyang@gmail.com>, <david@fromorbit.com>,
        <trond.myklebust@hammerspace.com>, <anna.schumaker@netapp.com>,
        <jaegeuk@kernel.org>, <chao@kernel.org>,
        <kari.argillander@gmail.com>, <linux-fsdevel@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-nfs@vger.kernel.org>, <zhengqi.arch@bytedance.com>,
        <duanxiongchun@bytedance.com>, <fam.zheng@bytedance.com>,
        <smuchun@gmail.com>
Subject: Re: [PATCH v5 05/16] f2fs: allocate inode by using alloc_inode_sb()
Message-ID: <Yd3UZyhGiACHgBah@carbon.dhcp.thefacebook.com>
References: <20211220085649.8196-1-songmuchun@bytedance.com>
 <20211220085649.8196-6-songmuchun@bytedance.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211220085649.8196-6-songmuchun@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PttLO13CQiN5zAJoumJcBsxhtZBuxYkTnEvk4nJthwdXsy7nwCLHqaHAd6B/?=
 =?us-ascii?Q?4r1fpRkqAWOJLBoHXVD4fRcDUev6rbh7whC6aUr+1Q9IDRIhaFQii/Pytlh+?=
 =?us-ascii?Q?yfmr1JhCFCFx3u1Tm/2BeK0Vjx7MfPWMfjMlm7HKwgmJdFB4tS5bKKNk8+cV?=
 =?us-ascii?Q?b6RLz3vh5C1jHNcrSmOgcX1Rnp523iooR5A2EZvDhStGy6XuRqdcMI0jSR7X?=
 =?us-ascii?Q?29IoiLC5yJMsNuR0uGozfxXSttg+s5Aqp4lV9gFXWLCjzcZOU4ub5Rha7ABm?=
 =?us-ascii?Q?rzHbGdARmbeOUjjqPLXHtXa5JNNMKHHteiJne0XtESNgyQA5t0X8NJjACaeG?=
 =?us-ascii?Q?JPhnK0UY4vRIaiPSzdEz7tinJzUHELsoC5R3CXxub+h8xg/o52jjIKVbcVzO?=
 =?us-ascii?Q?biZcTiMiVxm+VTCZZLj652Ll9usYe4PGwadxp0eHUu2D66vSLhyE+YtQ39a2?=
 =?us-ascii?Q?ZCH9SuroWvZiK7sBz7UVSKYIOm20XlymLv84q7eioWsLUq+x11Nd1y2QsrRk?=
 =?us-ascii?Q?GGogy720MAFTwIl0zILFXQxx450hW0S2Qt5XdiwjEu8TPVGYt9qGwONP/69O?=
 =?us-ascii?Q?QZzs8W84wZq/uEcWUfxUHGJxlVU5T8MzxKH/PVrWrdI3WCy7HoR+d2y5m/yx?=
 =?us-ascii?Q?fYPQb2bbSCSm6Hl6jjg1eFNuGPKZG7JO40fZOiEU/ZGqV+MNwi+SelHulOOT?=
 =?us-ascii?Q?Y0T705fOOJnG1tIZmqqCKwqvR3eQuiI9pHNpgBBiHs4+1/8TVfD7UrCw6qNd?=
 =?us-ascii?Q?eicCoJ6fiqMVNDNI2gkJ4mXMRLXiq9jt4GTgqrOy/9xFBrHN8ZHtYxK9dFOu?=
 =?us-ascii?Q?h6gbOSxiwdb4Oq6OAJ2u0yq3Kj/NAHH7cZ54u2G6nd66dgjo6V0LsYQgCfD1?=
 =?us-ascii?Q?81Ncn0CbeddQNSrwZJRgjlBurpzFvZ/3WMySqZVA+Qrq4HZdw8AoZJFrsCUM?=
 =?us-ascii?Q?DFHu1HvU3p9KDuFnLKJYUBim/4is3tH+wKURCLqeBdIyTQFabEf1CX8Bv7QB?=
 =?us-ascii?Q?8+BTjimQPW7YmW6dQUuMDSxnzylEltnwp8bmWs2LVOhOPp3tNQEtxTFrNE6W?=
 =?us-ascii?Q?ESqII91ntKSBFdZ2ih0Fe4k7YYBc4p0MX1Bh6iht9qoSsKWiIuIDMC5dYBuP?=
 =?us-ascii?Q?2VdNmLPuZVEHrVWY1SYs8nUkvMrjet1FW5DdJ0JmfdhlAdiCNnLKfXu5k4uZ?=
 =?us-ascii?Q?Q4PtmeuDchNxPnUnwORzuqVDdGOVv8TQx8yqwh/n7CkAB1tIpaBLqDpV9Zyx?=
 =?us-ascii?Q?E1Aj+11oLJY62oLuT1ZBCtr49ZO/gtGmx6fVczXRCP+hbYBPB0TXGNz8qiJm?=
 =?us-ascii?Q?daxJbXgb5GhuLSF2VR34PQNsjrRlK2EnPAyKbnBn1JqCEb9hb9M2dFVZZmOG?=
 =?us-ascii?Q?G3Hj11YRIFOPRUHjn93wWGLyTswqzZzyRLinTa0HIo6UxFWbdQyGUTXY0P+S?=
 =?us-ascii?Q?HNjJLblHI+hyT09uInqz5qDE1fwIgNM4W/V1M2E2iUzipusNJfaUvO0SN7DP?=
 =?us-ascii?Q?3faAA0S57h0om9qdwzGlRCPdE9yJcdxwbj8XWlX2Ku9o8BY8ABcFsv0yLa6A?=
 =?us-ascii?Q?dV9havauDnjP9U1CkEpKPBaks0iKTOlXwc11bqfB?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bca41da-0be0-4213-aadb-08d9d5350176
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 19:03:08.6360
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K5jMdzlwORXqCPyQFwQE+h25BlnR58gczPtOVilfxk16sHwgZIVHwC5QolgWWoCX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR15MB4373
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: EvD5xK_fdARI1DvVbK91iRPtmS4I7a2U
X-Proofpoint-GUID: EvD5xK_fdARI1DvVbK91iRPtmS4I7a2U
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-11_04,2022-01-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 impostorscore=0
 bulkscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 spamscore=0
 clxscore=1015 adultscore=0 mlxscore=0 priorityscore=1501 mlxlogscore=979
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201110102
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On Mon, Dec 20, 2021 at 04:56:38PM +0800, Muchun Song wrote:
> The inode allocation is supposed to use alloc_inode_sb(), so convert
> kmem_cache_alloc() to alloc_inode_sb().
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>

LGTM

Acked-by: Roman Gushchin <guro@fb.com>

> ---
>  fs/f2fs/super.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 040b6d02e1d8..6cdbf520b435 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1311,8 +1311,12 @@ static struct inode *f2fs_alloc_inode(struct super_block *sb)
>  {
>  	struct f2fs_inode_info *fi;
>  
> -	fi = f2fs_kmem_cache_alloc(f2fs_inode_cachep,
> -				GFP_F2FS_ZERO, false, F2FS_SB(sb));
> +	if (time_to_inject(F2FS_SB(sb), FAULT_SLAB_ALLOC)) {
> +		f2fs_show_injection_info(F2FS_SB(sb), FAULT_SLAB_ALLOC);
> +		return NULL;
> +	}
> +
> +	fi = alloc_inode_sb(sb, f2fs_inode_cachep, GFP_F2FS_ZERO);
>  	if (!fi)
>  		return NULL;
>  
> -- 
> 2.11.0
>