Date:   Tue, 11 Jan 2022 11:05:30 -0800
From:   Roman Gushchin <guro@fb.com>
To:     Muchun Song <songmuchun@bytedance.com>
CC:     <willy@infradead.org>, <akpm@linux-foundation.org>,
        <hannes@cmpxchg.org>, <mhocko@kernel.org>,
        <vdavydov.dev@gmail.com>, <shakeelb@google.com>,
        <shy828301@gmail.com>, <alexs@kernel.org>,
        <richard.weiyang@gmail.com>, <david@fromorbit.com>,
        <trond.myklebust@hammerspace.com>, <anna.schumaker@netapp.com>,
        <jaegeuk@kernel.org>, <chao@kernel.org>,
        <kari.argillander@gmail.com>, <linux-fsdevel@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-nfs@vger.kernel.org>, <zhengqi.arch@bytedance.com>,
        <duanxiongchun@bytedance.com>, <fam.zheng@bytedance.com>,
        <smuchun@gmail.com>
Subject: Re: [PATCH v5 07/16] mm: dcache: use kmem_cache_alloc_lru() to
 allocate dentry
Message-ID: <Yd3U+jr7gFXlTYTK@carbon.dhcp.thefacebook.com>
References: <20211220085649.8196-1-songmuchun@bytedance.com>
 <20211220085649.8196-8-songmuchun@bytedance.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211220085649.8196-8-songmuchun@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ti2yoURZvJNrzPBiaTuz7i0tztIIbcdCiNk62zGnbehZZLix/fYbZV/dqNib?=
 =?us-ascii?Q?KrZqLb/jpYIcjFRrx+pKFMvenh4mbo6JCZTPjiDiNOX07djpIOYfBYjsGE7C?=
 =?us-ascii?Q?/72NSE1yyzmthO3QdeM0yIrpMPN+s6uxhjJzXu758EwTTpdPWPwOBpz4OXJw?=
 =?us-ascii?Q?AyHo7zYm4lVXwsZe5Buxlf5YYi2ldX0tNiPTf3Hl4VkA9h0zebk8EOAv+dEs?=
 =?us-ascii?Q?JfMIn0wx9crYH7iftA4hCRnbhDXvMA9lSyN6p6CBuJoIBB2oeXSrJLDh5lBm?=
 =?us-ascii?Q?jAqW1/erNBoN3Mag1T2uDwa/Noo/NjFnzVZ1cqA0OhpDQksuLK/htsqZB7e7?=
 =?us-ascii?Q?jnMCbMyYOd0ne/d4tVbddqJwv9Ol2vLsrQC3wjykWNgtFP0a7b+3CFFLszeE?=
 =?us-ascii?Q?44txh5OJmvFC8SFauxxdflUbGTfMJb3wXdyFO02jbJU3Os/+SChf7g9WBduu?=
 =?us-ascii?Q?mWrzdqzETqNGg3jl/D/isJgY29uppSrF9KYh+1Ru43oY89JjpAUsvNN+7scr?=
 =?us-ascii?Q?9glCg9xvpCcmkIY7D4U78d8MvFCBTdDKSo19+o0jeuSGcAv3bzdMZ+vT8vsN?=
 =?us-ascii?Q?GnXmlNhWKaY6W6EVu1WtKT5i+apHCBpXpjhWLr+6hy0DAVG911uplxbHECYy?=
 =?us-ascii?Q?vKI2yK4PAzAWbLNSfsYGX/R3lf5VmAcShTq9lOp//NeqmgXdCVEZd1UbwjlU?=
 =?us-ascii?Q?ig+aI9vpbWfrtRPuXMeZAnLq3G9JZOn04Fu2xb8tnFQpO/7Ufxt50LNjSDZy?=
 =?us-ascii?Q?dT7fNGkHxcfXG73OFuEMYskrcsuGSGBfUjmG9eNMPrOnm1MP6USSCABXU23R?=
 =?us-ascii?Q?rTfKk/z1iTpWVBkjfBiG+EBZstfkGmdQRATgjNAOmz4xGEbl469Nu1bemYLB?=
 =?us-ascii?Q?xmUIpyHYuLo1yUzttUHEpHXMl02lKh35CS4QhUvWmWqldnj7PZA1gU55mSDH?=
 =?us-ascii?Q?aHiS9Lbrjb0GFq7ehFOYTfnO9Oy/U+FuodwDw6iTL9gxzHp2u3GtuTd0AOYt?=
 =?us-ascii?Q?KaiqGaKQsq+Uj0UBW9nqILD50PlAJCisB9RzI4yA3mTWjGx6ReBTU9bLMXr4?=
 =?us-ascii?Q?zvTem8jjNRKgwb8KtfHX05V/kFDFxcu1XbMqUaXeLNqRR/CBq97ui1Uils/P?=
 =?us-ascii?Q?oQc3WDEvgO1qJSbyVgMxgLjrwQEdwsc28DKtmovgsvwSC9lC1x7CUVIopWyz?=
 =?us-ascii?Q?TQGOLmt2Z6QfmvQsC0lHgUiattJAgrh1u8qAfJiLsawIXAevUuDh1DBRfFJI?=
 =?us-ascii?Q?3IpmGi2JQmnQJm81nq2I2Ce6BnieEzoE4sVXOfCAI10LdkmUUtPT682WngZc?=
 =?us-ascii?Q?YinTjB2k+Bv0ZdNeJw5mQ43z18HOHfk3zyNSs/Hos2iuoPma5ethLzXUYXCA?=
 =?us-ascii?Q?KNw0R6fE5ZlEV8JR3MErdw+zqAOWTbKTbeQNd2tcGprGRpKW+OdI5FV/6ViZ?=
 =?us-ascii?Q?SkYJoLaTqN7zZYs36Jsy++surchq/cZ/j0fPEW5YmDb5AGG7figjZDdKvrJq?=
 =?us-ascii?Q?2Xti5g3Oxp6ZN+5wNS2VzZmZTwrFMpCyVjNokppragsoXMufgFytyG8XfHRh?=
 =?us-ascii?Q?oIioPs+1ZVk+gbjca42IeKZe68UuCiq6Dq+7Q8VB?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f931779-853e-4f7e-dc48-08d9d535588d
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 19:05:34.7654
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /WMj1ZPCnR6n1nZmQ0U1rOPAZ9G3iWZYIqqBLkBox3DDKzYhL52nLBRxfSuDFhx7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2600
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: uNBdWnFOz8yTRJL12ctZVoTyBEJ3nZsy
X-Proofpoint-ORIG-GUID: uNBdWnFOz8yTRJL12ctZVoTyBEJ3nZsy
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-11_04,2022-01-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 bulkscore=0
 priorityscore=1501 malwarescore=0 adultscore=0 mlxscore=0 suspectscore=0
 mlxlogscore=664 impostorscore=0 spamscore=0 lowpriorityscore=0
 clxscore=1015 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201110102
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On Mon, Dec 20, 2021 at 04:56:40PM +0800, Muchun Song wrote:
> Like inode cache, the dentry will also be added to its memcg list_lru.
> So replace kmem_cache_alloc() with kmem_cache_alloc_lru() to allocate
> dentry.
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>

Acked-by: Roman Gushchin <guro@fb.com>