Date:   Tue, 11 Jan 2022 11:14:30 -0800
From:   Roman Gushchin <guro@fb.com>
To:     Muchun Song <songmuchun@bytedance.com>
CC:     <willy@infradead.org>, <akpm@linux-foundation.org>,
        <hannes@cmpxchg.org>, <mhocko@kernel.org>,
        <vdavydov.dev@gmail.com>, <shakeelb@google.com>,
        <shy828301@gmail.com>, <alexs@kernel.org>,
        <richard.weiyang@gmail.com>, <david@fromorbit.com>,
        <trond.myklebust@hammerspace.com>, <anna.schumaker@netapp.com>,
        <jaegeuk@kernel.org>, <chao@kernel.org>,
        <kari.argillander@gmail.com>, <linux-fsdevel@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-nfs@vger.kernel.org>, <zhengqi.arch@bytedance.com>,
        <duanxiongchun@bytedance.com>, <fam.zheng@bytedance.com>,
        <smuchun@gmail.com>
Subject: Re: [PATCH v5 08/16] xarray: use kmem_cache_alloc_lru to allocate
 xa_node
Message-ID: <Yd3XFjz9eKVpYHsM@carbon.dhcp.thefacebook.com>
References: <20211220085649.8196-1-songmuchun@bytedance.com>
 <20211220085649.8196-9-songmuchun@bytedance.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211220085649.8196-9-songmuchun@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Xego0Q6EYABl2lBN6TW3FySh52iSNgkG0CK8y/f2mvU3WqNI3sUfLHl2Oa1U?=
 =?us-ascii?Q?nnbsyI6mgDdJijsiSfd/H4r3nLOFTHhS8dxheljMluUOqCwHeQZoUZCsUl4c?=
 =?us-ascii?Q?oxMsCm0aswq7UWij6CvVcrhELcbn8aozmOLOs8NocsQNTfxCDYGLba6NvRK2?=
 =?us-ascii?Q?yuGOmZFW5ssOL3O+PqhqdcAUB6yKEGr1MFcCJC264YnzMzpuhu5daC0HX+QK?=
 =?us-ascii?Q?5+KSPWAJHsHzEO2Tugz2jkbsCw2nFAmyhkHdP0CVJCUcszPUltpsapNNXIEn?=
 =?us-ascii?Q?Wdh62SXFsYtDR6r2Mon+2vEGLv5MmlUcnuXHhcAn+d72cGJIDyvpFX+CrEsg?=
 =?us-ascii?Q?0tII97e/deYQs1Snf7skWXAXgDTDMxU+04F6g6pRXITarapydJR4fpEi96a8?=
 =?us-ascii?Q?dMAUN3cnw2Kp/Wc8FWDSTysIrqZl5Sp8fYcw6R2BBhfwNOv2aDr58WicWwsq?=
 =?us-ascii?Q?K6xaPANPDfuM+OXBkrX+BCUjh5R0cEmZXHleNtkEMdUB4eif7MdIP/x+uMIQ?=
 =?us-ascii?Q?791fKHIjMjBaZiLFMstTryDa0poUtqfFyHtPZdx4UISixiY+oi7mr62QQK2I?=
 =?us-ascii?Q?uXmcKxkUaj0hSLEJ8gmgtGnug8Mxe9XQ7LDjfVClsPBqrkaHocueEriirqAN?=
 =?us-ascii?Q?VKnkaR7EveqBwlbrnLiPLUh6WMKnadBeUp+c+OR/JU9pkcZmhANV5QvTLCgo?=
 =?us-ascii?Q?RpEJ69UIlH0ZEGxQjwpHanalmFohwKhuWDpftcU6zpoZDjr6oLH6BomTPsNf?=
 =?us-ascii?Q?oCtBVuCOEuC9+t5MKO0OqlzVOHFeyZNkf7DX/jHBTeqUrJfwUhABD4DTsNGG?=
 =?us-ascii?Q?2Ml72WLXvGUsh0IN+mJcBTuCcrQ4lV/ptPeRqfSCYskF38cCOJ5vC4gtoFQV?=
 =?us-ascii?Q?lLB3VsezajuX0QUgbPPIronnCpHljAj8+QcQWRuWZDr0ntzjTBNrrmynbeA6?=
 =?us-ascii?Q?gLxxMpXyWy55NuEuSKOfK7BYMZjrBw5BlLDXfjYSacp4zfc0rC6YbltJ6xbw?=
 =?us-ascii?Q?LGzOiFhiCgDMW8ICQ6eWWIpt4zygxOopQ2J1yVJ8uDkJn4VSJTfsh5DZ5k/i?=
 =?us-ascii?Q?OD74UkiAVhbs6g+V6DWk85sydCCv7QjaKmFTkqkRyRkr02GEfhlQUo33/A7W?=
 =?us-ascii?Q?9DPHBlf7kCPjw42zZihkrDPRzWEVkFzpluCZ09PEzoqkjUMCmF0d+biEtTwL?=
 =?us-ascii?Q?FlRyO2W3Ia3MagQccQKWS55gtO9aPiUQUDMEWyGHpzAdHzcjYct1UBGKfBAe?=
 =?us-ascii?Q?/1mH/Ck5gKakvBWMNJbsLh46rBc4P36oS4DVi/mBx31e0bhhEv+Uds00mWvP?=
 =?us-ascii?Q?NmbQG4isbG2cmD8maq+hA7mpTE0sEcc7hM3oa8xum4cahyTxqLjvSXjqMDs0?=
 =?us-ascii?Q?ATTRwJbwCpv7hRAwpQO4FTO81+KcGoUDWSAKGzDY4GQE10kj5h1uWR49uwU0?=
 =?us-ascii?Q?c4Lvd2N8mMq4gTGiEME3QFCidgCDFNJVnFtUW7EzSwFzMkzu1K/Im4oDxLyr?=
 =?us-ascii?Q?V3fxbuRQKTa7ioNzVzN+5KTA1AhRsGVTXxMdn22GW4uXyeaiaOpyXFJ0Lpp0?=
 =?us-ascii?Q?HDEV+mnHCqg5paJM4rfvTtIWpstSPf7oz4VUt0F9?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5cd0c55e-c171-40d5-5d3c-08d9d5369a86
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 19:14:34.9582
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SNNMo8oE1VpcdKFt7/HLP0GGHWATwxvQ6jBd/ottdc6meDAV7q5TNB2jNW/G1xpO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR15MB4186
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: eFig7PQ_fiOZi3spK6EgAHobmZyH5V-7
X-Proofpoint-GUID: eFig7PQ_fiOZi3spK6EgAHobmZyH5V-7
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-11_04,2022-01-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 impostorscore=0
 bulkscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 spamscore=0
 clxscore=1015 adultscore=0 mlxscore=0 priorityscore=1501 mlxlogscore=949
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201110103
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On Mon, Dec 20, 2021 at 04:56:41PM +0800, Muchun Song wrote:
> The workingset will add the xa_node to the shadow_nodes list. So the
> allocation of xa_node should be done by kmem_cache_alloc_lru(). Using
> xas_set_lru() to pass the list_lru which we want to insert xa_node
> into to set up the xa_node reclaim context correctly.
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>

Acked-by: Roman Gushchin <guro@fb.com>

Thanks!