Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 13 Jan 2022 12:24:02 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Chuck Lever <chuck.lever@oracle.com>
Cc:     linux-trace-devel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH RFC 1/2] trace: Introduce helpers to safely handle
 dynamic-sized sockaddrs
Message-ID: <20220113122402.74f73553@gandalf.local.home>
In-Reply-To: <164192756765.1149.13872546013201834510.stgit@klimt.1015granger.net>
References: <164192738510.1149.7614903005271825552.stgit@klimt.1015granger.net>
        <164192756765.1149.13872546013201834510.stgit@klimt.1015granger.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 11 Jan 2022 13:59:27 -0500
Chuck Lever <chuck.lever@oracle.com> wrote:

> Enable a struct sockaddr to be stored in a trace record as a
> dynamically-sized field. The common cases are AF_INET and AF_INET6
> which are different sizes, and are vastly smaller than a struct
> sockaddr_storage.
> 
> These are safer because, when used properly, the size of the
> sockaddr destination field in each trace record is now guaranteed
> to be the same as the source address that is being copied into it.
> 
> Link: https://lore.kernel.org/all/164182978641.8391.8277203495236105391.stgit@bazille.1015granger.net/
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---

This looks fine to me. The only comment I have is that the subject should
be "tracing: ..." not "trace: ..." as "tracing" is what we use for the
tracing subsystem.

I'll test this out if I get time.

-- Steve