Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     "linux-trace-devel@vger.kernel.org" 
        <linux-trace-devel@vger.kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH RFC 1/2] trace: Introduce helpers to safely handle
 dynamic-sized sockaddrs
Thread-Topic: [PATCH RFC 1/2] trace: Introduce helpers to safely handle
 dynamic-sized sockaddrs
Thread-Index: AQHYBx1g7+LR+5J9j0a+/twlIKZeRaxhNnwAgAANx4A=
Date:   Thu, 13 Jan 2022 18:13:21 +0000
Message-ID: <81019357-9BCA-4EB9-9B8B-F637C98AAEB9@oracle.com>
References: <164192738510.1149.7614903005271825552.stgit@klimt.1015granger.net>
 <164192756765.1149.13872546013201834510.stgit@klimt.1015granger.net>
 <20220113122402.74f73553@gandalf.local.home>
In-Reply-To: <20220113122402.74f73553@gandalf.local.home>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GVaNVBwWuWaxeNj/RpY/o/NZzAM4ZUN2+dT3nrWSBhvGYzQeBM+Fmh7smBOX?=
 =?us-ascii?Q?kv6AOLDXEJ35EyrJ00oFtU9pAqXtzJ1NlOdjuBZAmC6jGtgVvqNCTovazitm?=
 =?us-ascii?Q?n9x6vUqw/pOknqrOBV2JOCuoKMmR1yB/qMdKf3dasmf5AKcWrgdqvsnFerdG?=
 =?us-ascii?Q?/DlFs21DDNJ9BR2tPfinkkEVGUidjR+rnvivWhnQyskhl1DLvsIaR+4Zyi35?=
 =?us-ascii?Q?4EMA/or/HZ3hKgyEDVhdKQKZ52cRZp2/U5GUQ0xunuzn0FNOw9Lbvzm05hVE?=
 =?us-ascii?Q?Z64raBZCxO9Z8XGoZx0skdzbrNfBoJ0VEwCrcRo4lCRB2NwUZPLg7PkRu2l0?=
 =?us-ascii?Q?dq5bbSwTzeGHs8CjwXhXcvl8f0K0EdZSZh96svPFjY6ekBiox8uG6YBxOZU+?=
 =?us-ascii?Q?ijKmhY+QReMPnxXpoD+H8uzfhzvXCxzftB+86i5km+LY2pUO8hPk0s8pQPs+?=
 =?us-ascii?Q?eBlbFf3Ir0MmutfZ827Vzk9yEYQs2JgkHwTtcUHTCJcCDEWJHJr8gj+zK766?=
 =?us-ascii?Q?TveJKgxn+nVLZKUnHyexy8LH3AmEFMNE4LIDjqYoSFjVlG1urFJt+hxdkkFg?=
 =?us-ascii?Q?c5mvFIV+sx8UkSCZ17bTE+z3PDQyn6wi1Q7+6zvDi1mq/K08zNPZjdOIb3/o?=
 =?us-ascii?Q?hLVEYV2iTx6uaJEHGAfsWt3KlXj7cYbMijzGmcRSYD3wzma3zYXpuQPOomD5?=
 =?us-ascii?Q?yPzsjb16NRmMnZZgp3+D9cmemOz1vhdV+8NUvIEao1PL6nufd8JpFkxvwV1j?=
 =?us-ascii?Q?u7XmbcTKsRTHpTbW6occEEWfiF8JWyvCarjGHvZ1Uv6SRUQHIQSA24gNN5uN?=
 =?us-ascii?Q?hmU3tl378zU/rtPnm0J70hT+lbPVNdQgMard0KYMstbZnMaMBqLdmfz1xXgp?=
 =?us-ascii?Q?Vg/KJTfiA124rLoZjRs4eEYYzmo4czhC76VBrnqkjseuh4EC9KaoQiMWENJG?=
 =?us-ascii?Q?xyrEqbrLKTCY09fDGb8zsO/AiAimS+3Gx7GS+QlAu0zTOEdqt+G9aId5I7Rh?=
 =?us-ascii?Q?40qqh48Gz25Agmy84fU4L6HUQB3Dyy/vrufPtZFCDR87tSwetqIL42wS0T/w?=
 =?us-ascii?Q?VK+Wje0zvFA1hdHIl6jjybVfjVfxW4LxQuD4uDdukalSBGMzB+VmV0Wwb0Vf?=
 =?us-ascii?Q?ybqEWzN47vzE96LN4ls6WYGbYSXypHTUG0/wgvRtJEbmrmfnWqAFwIRaJsEz?=
 =?us-ascii?Q?TYQLpQlqV0kRoWFqOlBAPeYJJIH6i3NyY2hg5oZdSrsmkHd8u68yy6Yc9g4L?=
 =?us-ascii?Q?/yvvrmgAOmUqR+/LAUMwhzKHZk+EpI5BdNUBPKFd2HtLOyIcNSCwm1ECSpXr?=
 =?us-ascii?Q?H2ax0Z0/dwtWV/of2qBiu6wI4s8QzUe+go9VbHKhP5fnjQ+7r/98MUCKGt+r?=
 =?us-ascii?Q?2sPVaJn73R1Y8AezFHcYgzlTMNwr3CAzUIKAXFkbgh2NTLLlUGRWhFGQ3kk/?=
 =?us-ascii?Q?U9b/bcK1lkXEo6smXqTeE2mNtZN4nd3kXGIjPpjVg+6cybHjJVcdMXZEIoe6?=
 =?us-ascii?Q?UjrX58dcH7ZL2STzHuCXVqsvJmP5QPu2Z8175CPPzDUVSm49rDK3DwEaW0uY?=
 =?us-ascii?Q?HOBo7KflsEaqaf1aUL8Q2erbWP2W1pZwFq+Sk8KJ2k3MJqr27vKYMVoVTN1W?=
 =?us-ascii?Q?eqiEHdxvAJrtMHt2CANPDHk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <69B22C596402DA448C6030016D18838D@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB4864.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad2939d9-7292-42d1-4801-08d9d6c061f4
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 18:13:21.4163
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lKXsEUrllC5FDmL6OI5PS2imaWgLgKAIELrhe0/BSLPDN0oqLKVE+XnCLihDqZ+CWRRwYuPapEAjjYsQ2wNWaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3471
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10226 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 spamscore=0
 phishscore=0 adultscore=0 suspectscore=0 mlxscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201130113
X-Proofpoint-ORIG-GUID: zkaEAnR5blq2yGSsU9aEVR76zvYKQlN-
X-Proofpoint-GUID: zkaEAnR5blq2yGSsU9aEVR76zvYKQlN-
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jan 13, 2022, at 12:24 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
>=20
> On Tue, 11 Jan 2022 13:59:27 -0500
> Chuck Lever <chuck.lever@oracle.com> wrote:
>=20
>> Enable a struct sockaddr to be stored in a trace record as a
>> dynamically-sized field. The common cases are AF_INET and AF_INET6
>> which are different sizes, and are vastly smaller than a struct
>> sockaddr_storage.
>>=20
>> These are safer because, when used properly, the size of the
>> sockaddr destination field in each trace record is now guaranteed
>> to be the same as the source address that is being copied into it.
>>=20
>> Link: https://lore.kernel.org/all/164182978641.8391.8277203495236105391.=
stgit@bazille.1015granger.net/
>> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
>> ---
>=20
> This looks fine to me. The only comment I have is that the subject should
> be "tracing: ..." not "trace: ..." as "tracing" is what we use for the
> tracing subsystem.

Will fix.


> I'll test this out if I get time.

No hurry on my part.


--
Chuck Lever