Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1242914pxb; Fri, 21 Jan 2022 13:11:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJzR17KyGv2p0kqoMTwglAJ4PoL+lPpzo4Q2Q75kkdlUt/a8gOTiipb6uXvw0FDI9TVARIt+ X-Received: by 2002:a17:902:8a94:b0:14a:ef2e:60e5 with SMTP id p20-20020a1709028a9400b0014aef2e60e5mr5437292plo.42.1642799459789; Fri, 21 Jan 2022 13:10:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642799459; cv=none; d=google.com; s=arc-20160816; b=VzwVRRyNwVTMWByTD/uj2yjtsuD5yr5NM7vhjxbTROSeEXOAc9oPYofB++lbSWCjsk JG8OYbqyIqpa8r+bN6a6Ct1hMaHRVWhLp/JMloebG+qHKJuhZmb1k3MH8QqP/mT8py2I kGh1j+g3eylVsLvTOQhhnWgnbTsKv/sp17eDEl7yTaAWIzDe9t7Pam0i4eGRlBRSN7Xw iTN9K+hmpwyFgC3ejDN6PM5yFsNRmJn4hMJFZbShO0Ugbea/vIeed31C8ge7rKkn6MfJ EhOx2RTOGRpP43RPojCw8hzeRTJ8MDrGseJepZdRcx3dSqvkG+xl8JgU47HaA8Szsjc1 9/Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=NricS2Ridi6Kop3TbcuFis2yY72KzAH/d2uJ7Y7H6z4=; b=umiL0uJ0M8J6XFEa38bXlr7e8O8DaOu8jLCKO8hOiSBhw1AH0qLf5IoXDROf4LX7Q4 oBnRZR2qh9Av+pXD1VEPwY4wPWqEjrOeZnbmiUboReLI/gCxGNjX0Vir1U1ZgJQmpPtv YFbvK+SuuNiwibC+jh2NnjTi8VGpcvoBNqmEJUXdkL8PXh+rBTUv4XCTyA/L3IYKbLO6 Gh6721+m7qLAAsuCwccPh1MOu+mcJU+OFXB/DFRMBIshLYaggb4xJkJ30Dptu95hJZSx LgZDQ8XFHQsBX6gf+uNYOnKz3vycI+SlXhlNBRPmG3o6xsJEUvII+EizSLp3SPgI5FNF 6K2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k5si8438112plk.64.2022.01.21.13.10.39; Fri, 21 Jan 2022 13:10:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359287AbiATIhv (ORCPT + 99 others); Thu, 20 Jan 2022 03:37:51 -0500 Received: from verein.lst.de ([213.95.11.211]:43574 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234192AbiATIhv (ORCPT ); Thu, 20 Jan 2022 03:37:51 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id D6EFC68B05; Thu, 20 Jan 2022 09:37:46 +0100 (CET) Date: Thu, 20 Jan 2022 09:37:46 +0100 From: Christoph Hellwig To: Jinpu Wang Cc: Christoph Hellwig , Jens Axboe , Pavel Begunkov , Mike Snitzer , Ryusuke Konishi , Konstantin Komarov , Andrew Morton , "Md . Haris Iqbal" , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Philipp Reisner , Lars Ellenberg , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, xen-devel@lists.xenproject.org, drbd-dev@lists.linbit.com Subject: Re: [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma Message-ID: <20220120083746.GA5622@lst.de> References: <20220118071952.1243143-1-hch@lst.de> <20220118071952.1243143-11-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Wed, Jan 19, 2022 at 01:20:54AM +0100, Jinpu Wang wrote: > this changes lead to IO error all the time, because bio_add_page return len. > We need if (bio_add_page(bio, virt_to_page(data), datalen, > offset_in_page(data)) < datalen) Does this version look good to you? http://git.infradead.org/users/hch/block.git/commitdiff/62adb08e765b889dd8db4227cad33a710e36d631