Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1242997pxb; Fri, 21 Jan 2022 13:11:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJwq3pxEZzqsRIpSgogZv8mGCwV2oYjOqUANVzgIg73jJuIMHJEow/xBuheLam6YKCBZ8z/Y X-Received: by 2002:a17:902:ced2:b0:14a:5a5a:49c1 with SMTP id d18-20020a170902ced200b0014a5a5a49c1mr5306166plg.151.1642799466331; Fri, 21 Jan 2022 13:11:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642799466; cv=none; d=google.com; s=arc-20160816; b=IWSziki5jKE/T70EPzDf06diXBzgo0zke2FeqYvpfd0p9IFcNBTuXvWTsPcbjbZzrC mpcti1TR4bqv6EpWUfp53zljFhuESFPP1SwDAjeChERlrs+RiN/9vn6uDekS7uKEeagF /UXGw8zzLY+SnJGfqWeCBooqSAiR3OItk5NPoCzl77jD6gc4N0Qxv2MO+9w/9zmtA9D6 ak/+DXdusJLH8IlahdVoZHefjh52hyb/r6sw2S/qT0QTAb+IF4sowkWIB4odA1Xay3w+ VHzG/8O5uT1jmLf1uk8+9he9gclcoBb2RFP8WFcm3RK0t0uBLSHEQK6yVZwDXto755DZ BB1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=cgwK+h4TcKTuzoMVgpyjaT6hqJgZPgeFi9/82jcEytw=; b=PRr5I2ltzGCnjfZ69zrnn2yxSJTCSHLlsc3066xDmw0tUk9zHFpuH9shl/Jal3/urX vmDUSEddGUFx2X43Gdp95heykGK3MrITVFPliXAqc79G0Ra3a1wBeUxavdOOGDBGmkLM mZhbdLP3EQCthWUYo1xkzRt0KTDE08F+8PIzgyaT8B1kRzXkoYpxU1r0t+eRBm2H7if6 98SO7lOZPcCW7MGkdTD7FEclenpFTwh4j4WEazwzO2I1JxhjYgTPrlVMdTjryDMmALIf MFoHJwyduTbeDPnsVwbwTo2P7J4OZYOiETCgpKQYCqlDJCIW9ntOT+F//Tti8VtyWIdC YYBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ionos.com header.s=google header.b=bSaFa+UR; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ionos.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gl7si4288896pjb.5.2022.01.21.13.10.54; Fri, 21 Jan 2022 13:11:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ionos.com header.s=google header.b=bSaFa+UR; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ionos.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359351AbiATIqg (ORCPT + 99 others); Thu, 20 Jan 2022 03:46:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359359AbiATIqg (ORCPT ); Thu, 20 Jan 2022 03:46:36 -0500 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5641C061574 for ; Thu, 20 Jan 2022 00:46:35 -0800 (PST) Received: by mail-ed1-x531.google.com with SMTP id a18so25497559edj.7 for ; Thu, 20 Jan 2022 00:46:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cgwK+h4TcKTuzoMVgpyjaT6hqJgZPgeFi9/82jcEytw=; b=bSaFa+URfbmU/MszEXVOlamjch2d/bVKLmiJuU4jZJRaWnRGqGHrY9tAQfmQRbRXiV uc/9kTk3/S5l1jHMLdTRmVU57otES44XeerqdTVprmM6I9EDUZQLX+yH0h63YbxWR9mE 9nbGRPoufn7nse+dFWj62siY9k2GshoKLCrxbi33+uXmG5HvTOiNXAwJCNJOjjOHmaSp XOP01luyWgvqHzNdBA4wIYoRQp0k9Ft6zqCX+Ra/R90oY2R7/AxbMlg/sS1PwZuWZg03 Z3JDZLtjXW1ZdUyTLOQOdSV8iGdn5zWa6hPXzsGCHlb9LWK1Z0CByscOqozFwyTfAd7X /t3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cgwK+h4TcKTuzoMVgpyjaT6hqJgZPgeFi9/82jcEytw=; b=RrOFYhOqm4KXvgMDD1zXrqdvMa++A/LlMFuylseeenUTBxerV0BRMtSO/j+FRiE/5C Uk6W42bJPnzlJ0I3u8dZVmLQ5NZuptFxnANyqZ8VYwmmRYnTbYn3Hg+lRwMqvPUOpA5J MbQtVf+/MxUYm4eWvQXSv/OVfpOxnzpECq1+iRM9whKcjCrPdZ7BSue2B8EJQekGLHm5 aABUJaX5yYSHa4ywtW9XNVm/GADzzO1yyJpbeILHU7aFK7jsuqzth1EzKvX4E9mIylBH AZlhR3HxipSDQZ8VQI4jshv3Fkl1VGn8WTsrn43UofUR5ZYhboZUY2amkbqkdgi3UogX 8jGA== X-Gm-Message-State: AOAM532KzmoxtMvq/YX9MP+PFhX/opo3ZDqL2Wp9fzla9UGi82R5PGRo fJWmS56jh0lhzxt2+rd6Jms00Tn+SwCFUEBN8krXiw== X-Received: by 2002:a05:6402:195:: with SMTP id r21mr34247351edv.174.1642668394471; Thu, 20 Jan 2022 00:46:34 -0800 (PST) MIME-Version: 1.0 References: <20220118071952.1243143-1-hch@lst.de> <20220118071952.1243143-11-hch@lst.de> <20220120083746.GA5622@lst.de> In-Reply-To: <20220120083746.GA5622@lst.de> From: Jinpu Wang Date: Thu, 20 Jan 2022 09:46:23 +0100 Message-ID: Subject: Re: [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma To: Christoph Hellwig Cc: Jens Axboe , Pavel Begunkov , Mike Snitzer , Ryusuke Konishi , Konstantin Komarov , Andrew Morton , "Md . Haris Iqbal" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Philipp Reisner , Lars Ellenberg , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, xen-devel@lists.xenproject.org, drbd-dev@lists.linbit.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, Jan 20, 2022 at 9:37 AM Christoph Hellwig wrote: > > On Wed, Jan 19, 2022 at 01:20:54AM +0100, Jinpu Wang wrote: > > this changes lead to IO error all the time, because bio_add_page return len. > > We need if (bio_add_page(bio, virt_to_page(data), datalen, > > offset_in_page(data)) < datalen) > > Does this version look good to you? > > http://git.infradead.org/users/hch/block.git/commitdiff/62adb08e765b889dd8db4227cad33a710e36d631 Yes, lgtm, thank you! Reviewed-by: Jack Wang Tested-by: Jack Wang