Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <3710b69f-a77a-04e4-5989-b2cc3dd77929@redhat.com>
Date:   Thu, 20 Jan 2022 11:00:35 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] libtirpc: Fix use-after-free accessing the error number
Content-Language: en-US
To:     Frank Sorenson <sorenson@redhat.com>,
        libtirpc-devel@lists.sourceforge.net
Cc:     linux-nfs@vger.kernel.org
References: <20220113193605.3361579-1-sorenson@redhat.com>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <20220113193605.3361579-1-sorenson@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/13/22 14:36, Frank Sorenson wrote:
> Free the cbuf after obtaining the error number.
> 
> Signed-off-by: Frank Sorenson <sorenson@redhat.com>
Committed  (tag: libtirpc-1-3-3-rc2)

steved.
> ---
>   src/clnt_dg.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/clnt_dg.c b/src/clnt_dg.c
> index e1255de..b3d82e7 100644
> --- a/src/clnt_dg.c
> +++ b/src/clnt_dg.c
> @@ -456,9 +456,9 @@ get_reply:
>   		 cmsg = CMSG_NXTHDR (&msg, cmsg))
>   	      if (cmsg->cmsg_level == SOL_IP && cmsg->cmsg_type == IP_RECVERR)
>   		{
> -		  mem_free(cbuf, (outlen + 256));
>   		  e = (struct sock_extended_err *) CMSG_DATA(cmsg);
>   		  cu->cu_error.re_errno = e->ee_errno;
> +		  mem_free(cbuf, (outlen + 256));
>   		  release_fd_lock(cu->cu_fd_lock, mask);
>   		  return (cu->cu_error.re_status = RPC_CANTRECV);
>   		}