Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Petr Vorel" <pvorel@suse.cz>
Cc:     "Nikita Yushchenko" <nikita.yushchenko@virtuozzo.com>,
        ltp@lists.linux.it, kernel@openvz.org, linux-nfs@vger.kernel.org,
        "Steve Dickson" <SteveD@redhat.com>
Subject: Re: [PATCH] rpc_lib.sh: fix portmapper detection in case of socket activation
In-reply-to: <YenNsuS1gcA9tDe3@pevik>
References: <20220120143727.27057-1-nikita.yushchenko@virtuozzo.com>,
 <YenNsuS1gcA9tDe3@pevik>
Date:   Sat, 22 Jan 2022 07:44:51 +1100
Message-id: <164279789186.8775.7075880084961337149@noble.neil.brown.name>
Precedence: bulk

On Fri, 21 Jan 2022, Petr Vorel wrote:
> Hi Nikita,
>=20
> [ Cc: Steve as user-space maintainer, also Neil and whole linux-nfs ]
>=20
> > On systemd-based linux hosts, rpcbind service is typically started via
> > socket activation, when the first client connects. If no client has
> > connected before LTP rpc test starts, rpcbind process will not be
> > running at the time of check_portmap_rpcbind() execution, causing
> > check_portmap_rpcbind() to report TCONF error.
>=20
> > Fix that by adding a quiet invocation of 'rpcinfo' before checking for
> > rpcbind.
>=20
> Looks reasonable, but I'd prefer to have confirmation from NFS experts.
>=20
> > For portmap, similar step is likely not needed, because portmap is used
> > only on old systemd and those don't use systemd.
>=20
> > Signed-off-by: Nikita Yushchenko <nikita.yushchenko@virtuozzo.com>
> > ---
> >  testcases/network/rpc/basic_tests/rpc_lib.sh | 6 ++++++
> >  1 file changed, 6 insertions(+)
>=20
> > diff --git a/testcases/network/rpc/basic_tests/rpc_lib.sh b/testcases/net=
work/rpc/basic_tests/rpc_lib.sh
> > index c7c868709..e882e41b3 100644
> > --- a/testcases/network/rpc/basic_tests/rpc_lib.sh
> > +++ b/testcases/network/rpc/basic_tests/rpc_lib.sh
> > @@ -8,6 +8,12 @@ check_portmap_rpcbind()
> >  	if pgrep portmap > /dev/null; then
> >  		PORTMAPPER=3D"portmap"
> >  	else
> > +		# In case of systemd socket activation, rpcbind could be
> > +		# not started until somebody tries to connect to it's socket.
> > +		#
> > +		# To handle that case properly, run a client now.
> > +		rpcinfo >/dev/null 2>&1

If it were me, I would remove the 'pgrep's and just call "rpcbind -p"
and make sure something responds.

NeilBrown


> nit: Shouldn't we keep stderr? In LTP we put required commands into
> $TST_NEEDS_CMDS. It'd be better not require rpcinfo (not a hard dependency),
> and thus it'd be better to see "command not found" when rpcinfo missing and=
 test
> fails.
>=20
> Kind regards,
> Petr
>=20
> > +
> >  		pgrep rpcbind > /dev/null && PORTMAPPER=3D"rpcbind" || \
> >  			tst_brk TCONF "portmap or rpcbind is not running"
> >  	fi
>=20
>=20