Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 24 Jan 2022 06:35:26 +0100
From:   Petr Vorel <pvorel@suse.cz>
To:     Steve Dickson <steved@redhat.com>
Cc:     linux-nfs@vger.kernel.org,
        Yongcheng Yang <yongcheng.yang@gmail.com>
Subject: Re: [PATCH 1/1] utils: Fix left debug info
Message-ID: <Ye46npjOSzvqdXc2@pevik>
Reply-To: Petr Vorel <pvorel@suse.cz>
References: <20220122180243.19355-1-pvorel@suse.cz>
 <67d7bba1-d4e5-00be-c198-8501df6e61e1@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <67d7bba1-d4e5-00be-c198-8501df6e61e1@redhat.com>
Precedence: bulk

> Hey!

> This patch is pretty messed up.

> On 1/22/22 13:02, Petr Vorel wrote:
> > Patch for 497ffdf8 ('manpage: remove the no longer supported value
> > "vers2"') [1] didn't contain printf in exportfs.c (looks like debugging
> > info) and errno handling in stropts.c (maybe work on other patch) which
> > were applied. Thus removing it.
> Someone pointed it to me that  with 2 v3 auto-negotiation
> on the same mount the is error EPROTONOSUPPORT
> instead of EBUSY so this test
>      if (errno != EBUSY)
> 	errno = olderrno;

> seemed to work but unfortunately I can
> not find the patch/bz or thread we were
> communicating in... So I am going to
> remove the test until I get (or find) the
> official patch

Hi Steve,

thanks a lot for explanation.

Also not sure if it needs to be removed, but there are at least few places which
mention NFS version 2.

$ git grep -i nfs.version.2
utils/mountd/mountd.man:an NFS side protocol used by NFS version 2 [RFC1094] and NFS version 3 [RFC1813].
utils/mountd/mountd.man:can support both NFS version 2, 3 and 4. If the
utils/mountd/mountd.man:can support both NFS version 2 and the newer version 3.
utils/nfsstat/nfsstat.c:  -2                    Show NFS version 2 statistics\n\
utils/statd/sm-notify.man:For NFS version 2 and version 3, the
utils/statd/statd.man:For NFS version 2 [RFC1094] and NFS version 3 [RFC1813], the

Kind regards,
Petr

> Committed!

> thanks,

> steved.