Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3502407pxb; Mon, 24 Jan 2022 10:54:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJz+myt2aAYsR0gu8wbL2BZyyh5K1JwlLbq9akRbnGOPzRmBMQegtgTDiWje1xOmXGj6u11m X-Received: by 2002:a17:902:a703:b0:149:7087:9904 with SMTP id w3-20020a170902a70300b0014970879904mr15275635plq.126.1643050467755; Mon, 24 Jan 2022 10:54:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643050467; cv=none; d=google.com; s=arc-20160816; b=ZjXjc3f8jP2DZgR+cAXdQpMvoSF6zFXPJmSu2KoOUzRyAntcpD+7Od+TvefjrXcweg GFKx5rDzzNph/bSjwge2vSMf0FmbcZ6/eJLG03lulGM3jU0KUOnrQGdB49eymnq2e9wg FUYEkJvL1G7167NEatE0WFUrObNTvGQacGg+kXFdeQU4J7AhyOoKQoDd4GNCs+9WFSH3 kLbyfe1Y29Vl/izvv+fYRxWCmXgmTjZuwgE+wVa3Tm5EVRCjeDgAtp+SeIIg4ZngPklu CtVpeMmyDOzLWBBmEuHivQ9P+IDSuW57tUUmvzyLScbYdhKSF/c8vaD8rFDsZpVuNe8g ScgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=egI+y7AO8wKr4Y2T/LgBNkccAOtCyUbyUckfPi3yE8o=; b=ocvPXsrl/nREUANrtfmOARspzp7p8EFlkmvN3HDw3WZJTTnaJOp+LOOwMxPVHnqlhH s+1LSRDlMB5N92zktj4Zl8sbZJvgg7tKKJCcNCh8yJE+IfCiBE2bTxJoEzgtqZCWheVa GXkn7sH7Yk1YcRuB9La5FvL7vfOkjBuHbotPfbQncC67/fDEpNqYnKy4udbVmQ/xmnnY 0jEcm9CgnCNbyWtA/og685Wny9pEYuRE3abuq7p31UReOOOgLeiQEBIeU2lZ8V4IgL3Z 7gCgiV0WwMO7zQSMbKQz5r7Iq/SUoESnF48kIfbjiT/M1NO4QzeeTxs0Qj1dVxO0/hOO 9DTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=trRSnqkV; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y184si11073948pgd.377.2022.01.24.10.54.14; Mon, 24 Jan 2022 10:54:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=trRSnqkV; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242504AbiAXI4p (ORCPT + 99 others); Mon, 24 Jan 2022 03:56:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232547AbiAXI4o (ORCPT ); Mon, 24 Jan 2022 03:56:44 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AB7FC06173B; Mon, 24 Jan 2022 00:56:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=egI+y7AO8wKr4Y2T/LgBNkccAOtCyUbyUckfPi3yE8o=; b=trRSnqkVoDGjPRY1W18iMn49qk mg1UC8X4zJbTpmEVmtNAbiBsOKnUIIY/pOk769eL0IGGxbssBjv4T/Rkg3a/aEh9s38XzscNkxFbX j2c2Ii/S3ifNhKDup9bsQhDRTqhF20cAxo3YbY3VnwBEbOk1FB1qARRpoMZq8BN5CKsIY+JRw+BoO 5XsWPOMayez0ojqr58rVp+a7qeQ0m+fq/z52HH31t6gLMLwPoiTza9TEr9lA5TtbNk40rqeC+I/h+ rtDre+QH2UK3W7G/9vg0OkQUTjuhBw1nRiOJjjZ6ccIU+QcFFF+Cb5mncKdT+d7RdO/n01weV2uTH zgx/3Vfw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBv9T-002hBP-HM; Mon, 24 Jan 2022 08:56:39 +0000 Date: Mon, 24 Jan 2022 00:56:39 -0800 From: Christoph Hellwig To: NeilBrown Cc: Trond Myklebust , Anna Schumaker , Chuck Lever , Andrew Morton , Mel Gorman , Christoph Hellwig , David Howells , linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/23] NFS: remove IS_SWAPFILE hack Message-ID: References: <164299573337.26253.7538614611220034049.stgit@noble.brown> <164299611280.26253.6924680050876339981.stgit@noble.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164299611280.26253.6924680050876339981.stgit@noble.brown> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, Jan 24, 2022 at 02:48:32PM +1100, NeilBrown wrote: > This code is pointless as IS_SWAPFILE is always defined. > So remove it. > > Suggested-by: Mark Hemment > Signed-off-by: NeilBrown Looks good, Reviewed-by: Christoph Hellwig