Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3502467pxb;
        Mon, 24 Jan 2022 10:54:35 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwG2C9XvwjHcHUZqwRfD2iFtzbKNMd5RU5euRgcmxVHQW6Ac+2PYoscjFc5OKif1wQEXAQz
X-Received: by 2002:a17:902:bcc9:b0:14b:4a74:bb1d with SMTP id o9-20020a170902bcc900b0014b4a74bb1dmr6692470pls.40.1643050475651;
        Mon, 24 Jan 2022 10:54:35 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1643050475; cv=none;
        d=google.com; s=arc-20160816;
        b=ElsclIELYwYuI81pusx+goFjrhAAd36j44lnih3m47vMTkIvPygd3Zv1oBa2erJIg6
         mPWs9P/70xDGY6sD18TgjZJZux3nLhpZs4cFKmVphM2qr6R/LXvDPlPJ90DGpk9KrMyy
         0T8o5u0f37zlx7mjRFOiT7Jvxqjh4J8H1FRCITFMs5o0sNw7r1fHv2srn9i/b8QENEZy
         G3Y2ihZQyYnb9LfnD4QRK5s1s4fNpBP8X+d4EqV7xNdSb8j+dv3k2+bjQHrUBZITx9Ys
         aQiXbuAAjR2D9/OIuc7yXVh75eJxt3ixUB2OwDjbFpdJLnO08dyg5rJB2hH395GD93wR
         aY/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=asCzRIoppSmO4QZ+TuOt/SZMZHwp70x1LmUoq7XNu7Q=;
        b=ecUa9ypMrENI9OfQV84Qsk88S3WoUiiwvxRxGBjT61iqjOJU6SVoVxoANluD0H8fwp
         dlI4i4gR5h2+XogvrXFSs+1q81+88AU4mvjyQ7GiqNPnbB0yQcl29fItAdZ/f5NsPGvx
         KNq0sUeaZZtmbLcvFxdUkRUNpz7mWlwpT735AG2oMahTK0lbgWM+by+3EAOzvE97Yo5B
         mSH3zYbGyeShapD59tIi/EdMOwhXb6NjhQD8scN7EpaHvZ1Dbkba9wAK1lBZSm/nbHZ/
         WjYimrjBjRSWTPJ+07UexqDLA0Ruk+EKNeBsI0xg84pdj3ZmAhTeSR2CCYtopnUekRht
         lz5A==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=wkisxQoT;
       spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org
Return-Path: <linux-nfs-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id q11si11647724pld.501.2022.01.24.10.54.22;
        Mon, 24 Jan 2022 10:54:35 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=wkisxQoT;
       spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S242529AbiAXI5m (ORCPT <rfc822;chilversc@gmail.com> + 99 others);
        Mon, 24 Jan 2022 03:57:42 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44048 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232822AbiAXI5j (ORCPT
        <rfc822;linux-nfs@vger.kernel.org>); Mon, 24 Jan 2022 03:57:39 -0500
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 035D6C06173B;
        Mon, 24 Jan 2022 00:57:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=asCzRIoppSmO4QZ+TuOt/SZMZHwp70x1LmUoq7XNu7Q=; b=wkisxQoTZF4xxUhI4XNl0vmyAb
        NaQNpYi3/atnNwVIRwialv+9VcPJBMjLRySEa8ydT6FiRSbl3p+KlrMFOb8aEszRtMn3Njn84hhTb
        MWmCM0HL65mpZm9l8tb+eLPX/hfVz50HuZg3Fvchqe7NxMVrELHqms3SDzFEKhVqrkewzcmlcKI5f
        jJuRh2H3JzAT7C3+N1jwFYKo3Ue93W1sUv1zjcmfb7VQOi3Vtl1pEiUrVs0S878556JItPFPjaQXm
        4l0u5c/SWH9uOUFgZAz48eeh+MpxA+ZQBgTF1GErn6OCo393nweUWLLiHH7rZfe1k2W7itdFBHo96
        XeVt/e9w==;
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1nBvAM-002hYe-PY; Mon, 24 Jan 2022 08:57:34 +0000
Date:   Mon, 24 Jan 2022 00:57:34 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     NeilBrown <neilb@suse.de>
Cc:     Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna.schumaker@netapp.com>,
        Chuck Lever <chuck.lever@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mel Gorman <mgorman@suse.de>,
        Christoph Hellwig <hch@infradead.org>,
        David Howells <dhowells@redhat.com>, linux-nfs@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/23] NFS: rename nfs_direct_IO and use as ->swap_rw
Message-ID: <Ye5p/n8EF2dzV8ch@infradead.org>
References: <164299573337.26253.7538614611220034049.stgit@noble.brown>
 <164299611281.26253.6497855219394305186.stgit@noble.brown>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <164299611281.26253.6497855219394305186.stgit@noble.brown>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

> +extern int nfs_swap_rw(struct kiocb *, struct iov_iter *);

Might be worth to drop the pointless extern while you're at it.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>