Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Anna Schumaker <Anna.Schumaker@Netapp.com>,
        Trond Myklebust <trondmy@gmail.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: linux-next: runtime warning in next-20220125
Thread-Topic: linux-next: runtime warning in next-20220125
Thread-Index: AQHYEaktcg7+1kysjUiIdD4hmV/HjKxzM5EAgACiBACAAAmigIAAAKCA
Date:   Tue, 25 Jan 2022 15:38:22 +0000
Message-ID: <E23F5174-F706-40FC-9072-143B04905208@oracle.com>
References: <20220125160505.068dbb52@canb.auug.org.au>
 <20220125162146.13872bdb@canb.auug.org.au>
 <20220125100138.0d19c8ca@gandalf.local.home>
 <20220125103607.2dc307e2@gandalf.local.home>
In-Reply-To: <20220125103607.2dc307e2@gandalf.local.home>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FAwDM8rRMQ+sVqMqJdIaMyt7c8nve2nannd1si/Yfp4EWq/JM3aFo4XXN1Vn?=
 =?us-ascii?Q?ulNlFfmpUZUWD3RYdDGEhecc8ujw/VESDzAtEEzYD1J8DRfYhBaBP7QAErri?=
 =?us-ascii?Q?WzVpT8KGUSrTGu51ldN3g6kkQt3RYy8mMwOi/fOvrBIJ0Eao4z8s7SEQsvnR?=
 =?us-ascii?Q?xW8T++paz4DaHk9RNebtH27U7EWAjQSImoagVf/7Qb4Ev8QbTvVbCmP0hMkk?=
 =?us-ascii?Q?TrNylLmoedrCsW6MREvj04Q9VstGF7TYMFz8AGEyTrQ1bfmrOdwqQIsy4x/F?=
 =?us-ascii?Q?hYwCm5aeCGwTqBTIUe47EfOgKWu+tY69lLB5DNs+7anqr12XvPwvSFVKBF1A?=
 =?us-ascii?Q?y997YB6oLP7TEEmPCnMwaW2N6FzPTX3Cfb61szvZz/FMXJDFJEg4LJ2UQTB2?=
 =?us-ascii?Q?m7Ej32OxkOLM1z4soCbZyEBvjFOskmWng9Ag6t8DpaCrna5rYtB+g/8BMH0O?=
 =?us-ascii?Q?zCTvUx7euI6OVAZDd0QVFBfHvbnhFLgJKlw1H5GSocGNE7clkrez0rrA37QY?=
 =?us-ascii?Q?B3taSpqnczosKzoAlFhdIFZKomjiyQhGc+3fWdE7a4T/TUeuBdYNzlndd2fE?=
 =?us-ascii?Q?CFOl6/ConyZIbTitMlMFvRSCykIDgIZ7A9SdLuFdqF+s4V3HiRhCXAx26RIc?=
 =?us-ascii?Q?Q8+LgMN010S+3Ik3nL4eu6GdOyomcWQeQkRm9/IbE0v2U5iIcVLsxKSTP2ns?=
 =?us-ascii?Q?QglgHxZdWvhFlaba0ScdusC3vvZbF3oJ6Ubx+joj6Gim+96+ZUzxHOuPpsNJ?=
 =?us-ascii?Q?l5uLPZsfNi0D3d1Br/7EUjOCjy3/y17nmLhyyRNnryB3qJNI9sk1VsSTyZSb?=
 =?us-ascii?Q?L+TDm2/bfbxG7MsfEYU6KsiSCUURhAJ2cy8MZ2U0ruSsryBSfswJmGw3RREI?=
 =?us-ascii?Q?YNoWdDV66lnD3RYkrc92eV/qRCzhNocd7xzObgtGWKWZIazsaxQmPlv07vSi?=
 =?us-ascii?Q?EhTtjfSy549nlWH5FZOfJ5MurdCCbdi48BwMzUDGlUUtIQ8tba2V7/VuvIdf?=
 =?us-ascii?Q?lZul/JskLqBWAwAGRLbXm++PMK1oP160V8fhJEJul9jvFXNFHLBECI+ZIbQo?=
 =?us-ascii?Q?my+kHi4EExrio5IaxqKGYVvjAlHe1YLOrkypZlAQIoRF9i7/Io3HPLFLY4Qi?=
 =?us-ascii?Q?pzCrh6cqGQRdSZCZiA347Q2cRLSe+bXFE7T2ALN5T7lKtfQK7gIG7RjKxNy0?=
 =?us-ascii?Q?ZooiroEgKCnWXDZ7uoo+DOmK+nFQyJV23H8BwXy3i34G320g2on6OZh/TjMN?=
 =?us-ascii?Q?UQNBTgkOwg5X6fvmq8w9K6EeBJgEO0yiQRVqcBbxqE7KHq0lCLIdCY5yVkU5?=
 =?us-ascii?Q?tX6pqzbean3Hzq3Oq5+0MUfI+7wKcr894VkQpdYZxfcWlc5Qaq/USpCcmVRk?=
 =?us-ascii?Q?R5E6FnJ9cOLud1XZ58Z6hViK27yJPKA1AsWXG1OjYGsD4F4Y02yZioqL7oi1?=
 =?us-ascii?Q?Fm3VZJesZBZwRqtyO1DeaFAbPMeWjJ7Ih1AeoCd+TIGnq0OtXEVfYivSMofy?=
 =?us-ascii?Q?NQjBdetP8d4+wbqwjgQnBmwe7n5Qv1Rjxi+o4MnSw7lNBLUJybuKyEoJ7WBh?=
 =?us-ascii?Q?dSujCL1oTZtOWQEQDNITPhoyhFMMdnbyV6i5hGLhkOzW8vGJqe2vUrMic06g?=
 =?us-ascii?Q?AL07sW00SHB+fzyg37Xoj2s=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CEEA0A4791860948B22860B82EC9DBC0@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB4858.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 58767cf2-da50-4ff3-804d-08d9e018b868
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2022 15:38:22.6235
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uHCAXNt/nUCWkaRXo5jky9qtdfBxEl3wb08aSeg6lqcaH3uRaKP0oK9IXtKmthqITFoNAXQaxh727XW39KQ0HQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5065
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10237 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0
 suspectscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2201250100
X-Proofpoint-GUID: UAMrZQh6Rq_kZPXkevpDLzb6UQZNLcOd
X-Proofpoint-ORIG-GUID: UAMrZQh6Rq_kZPXkevpDLzb6UQZNLcOd
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jan 25, 2022, at 10:36 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
>=20
> On Tue, 25 Jan 2022 10:01:38 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
>=20
>> On Tue, 25 Jan 2022 16:21:46 +1100
>> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>=20
>>> Hi all,
>>>=20
>>> On Tue, 25 Jan 2022 16:05:05 +1100 Stephen Rothwell <sfr@canb.auug.org.=
au> wrote: =20
>>>>=20
>>>> My qemu boot test of a powerpc pseries_le_defconfig kernel produces th=
e
>>>> following trace:
>>>>=20
>>>> ------------[ cut here ]------------
>>>> WARNING: CPU: 0 PID: 0 at kernel/trace/trace_events.c:417 trace_event_=
raw_init+0x194/0x730
>>>> Modules linked in:
>>>> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.17.0-rc1 #2
>>>> NIP:  c0000000002bdbb4 LR: c0000000002bdcb0 CTR: c0000000002bdb70
>>>>=20
>>>> I have no idea what has caused this :-(  Maybe commit
>>>>=20
>>>>  5544d5318802 ("SUNRPC: Same as SVC_RQST_ENDPOINT, but without the xid=
")   =20
>>>=20
>>> Actually, reverting commits
>>>=20
>>>  6ff851d98af8 ("SUNRPC: Improve sockaddr handling in the svc_xprt_creat=
e_error trace point")
>>>  5544d5318802 ("SUNRPC: Same as SVC_RQST_ENDPOINT, but without the xid"=
)
>>>  e2d3613db12a ("SUNRPC: Record endpoint information in trace log")
>>>=20
>>> makes the warning go away.
>>>=20
>>=20
>> We added a new way to save items on the ring buffer, but did not update =
the
>> safety checks to know about them. I'll fix this shortly.
>>=20
>=20
> This should fix it:
>=20
> I'll make it a real patch and start running it through my tests.

Should this be squashed into the patch that adds __get_sockaddr() ?

I have an updated version of that patch that applies on kernels
that have __rel_dynamic_array.


> -- Steve
>=20
>=20
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index 3147614c1812..f527ae807e77 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -384,6 +384,12 @@ static void test_event_printk(struct trace_event_cal=
l *call)
> 			if (!(dereference_flags & (1ULL << arg)))
> 				goto next_arg;
>=20
> +			/* Check for __get_sockaddr */;
> +			if (str_has_prefix(fmt + i, "__get_sockaddr(")) {
> +				dereference_flags &=3D ~(1ULL << arg);
> +				goto next_arg;
> +			}
> +
> 			/* Find the REC-> in the argument */
> 			c =3D strchr(fmt + i, ',');
> 			r =3D strstr(fmt + i, "REC->");

--
Chuck Lever