Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Chuck Lever III" <chuck.lever@oracle.com>
Cc:     "Linux NFS Mailing List" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] SUNRPC: Remove svo_shutdown method
In-reply-to: <E1C5753E-6061-41CC-930F-1565488FC799@oracle.com>
References: <164313706374.3285.4265550102084857832.stgit@bazille.1015granger.net>,
 <164313725230.3285.5420060785593218794.stgit@bazille.1015granger.net>,
 <164314763348.5493.760625882164316264@noble.neil.brown.name>,
 <E1C5753E-6061-41CC-930F-1565488FC799@oracle.com>
Date:   Wed, 26 Jan 2022 10:39:57 +1100
Message-id: <164315399729.5493.8755514018709100922@noble.neil.brown.name>
Precedence: bulk

On Wed, 26 Jan 2022, Chuck Lever III wrote:
> 
> > On Jan 25, 2022, at 4:53 PM, NeilBrown <neilb@suse.de> wrote:
> > 
> > 
> > Could we rename svc_close_net() to svc_shutdown_net() and drop this
> > function?
> 
> I considered that, but svc_close_net() seems to be transport-related,
> whereas svc_shutdown_net() seems to be generic to the NFS server, so
> I left them separate. A better rationale might push me into merging
> them. :-)
> 

svc_close_net() is effectively the inverse of svc_create_xprt(), though
the later can be called several times, and the former cleans up them
all.

So maybe rename svc_close_net() to svc_close_xprts() (plural), and call
it from the places which currently call svc_close_net().  Those places
(nfsd, lockd, nfs/callback) already call svc_create_xprt().  Having them
explicitly call svc_close_xprts() to balance that would arguably make
the code clearer.

Thanks,
NeilBrown