Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp877918pxb; Fri, 28 Jan 2022 12:07:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJyM8UgxXVtTcSYqbsQJ1yRqkXg+l+hV+VmY+I9n2cCKWNanJIG77fFtIWdvJvljqsDRGW/L X-Received: by 2002:a05:6402:35c3:: with SMTP id z3mr9860567edc.17.1643400434571; Fri, 28 Jan 2022 12:07:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643400434; cv=none; d=google.com; s=arc-20160816; b=KxVPRcmEa4zRyWPtb0yDVNCnHp+XYzV+BGytNH4DwWH0hg/fPu8fkS/PZPTJabh3/t Kiv6U7h6cmzgk40vRiBuLU8HIX7UOUec6Bg4gq2d34Uhq7F3YzG6ptWTHd4obE+QOdkz S4WRbzpBEx2aeWZkHvFQstBZJBXOtYTL+5F6klxlNbrdP9GIy05g8zhNlXMlqi01/xek EP7II6ONYtQVMu8AjL5jGo/nTsRxrRgVMwMw8eN1nTtXTyVWQYoJYEK5FPllJAsOOYtF XkQ8l4b9lI1vkfAarLFmhdUVqLjSR3ZdfUObT6BAKJG61WJjlU4nz6u9qiHb0WJCJdSD Ejnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=z+U+izVFukrEKq10kL5qCCsiT3qJmeLAo+mnNrOVCPU=; b=BPNGEeQSdoOHpW3CQTP4aSyAiBuyBaaY8BxF5qVP5SFpCsGMvpG34l3GCJgD8+WNtd BTYNCM86V6b6155f0KeVxcpUWmtZrvMzgR9xPzyhqHVfsj1Z6zlVtRyhMR9Sj+uOo7ob IC+EOy8OIzxjCZOm3KhWFMmxn4KbH0f6KafcGjzhKx+ONjQd7lw4I9WvbiPgiyGTJSMW I7QSDNZ+KKRu3xTKerblVW6pfqcWbiwb7Wz/eb0J9Sb373JAYQ31jOJSgcug7rNZ9lQd EiB2YJQ52oZxMzAZjQXuwiKJdrd2cbGRUt2E1DBfu9u/L3JbhueSQdp5lECahX3NE4a+ JmTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=DwtRea8L; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sg34si3721387ejc.780.2022.01.28.12.06.40; Fri, 28 Jan 2022 12:07:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=DwtRea8L; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344446AbiA0ViV (ORCPT + 99 others); Thu, 27 Jan 2022 16:38:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344424AbiA0ViU (ORCPT ); Thu, 27 Jan 2022 16:38:20 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB875C061753; Thu, 27 Jan 2022 13:38:19 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id y15so7872257lfa.9; Thu, 27 Jan 2022 13:38:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z+U+izVFukrEKq10kL5qCCsiT3qJmeLAo+mnNrOVCPU=; b=DwtRea8LCCOg/PGJHjd1bTltmn0bHa2clILkAwGYtZppoAY25qIBMTxyD6B5uMLit6 7wk+d+sZiWX35l8wQaAoyrJ9H5CizW30SYci3NU1ojzD14qB67btK2MGpyfbQ3U8Fswu zxqpCDGkYCIAg/NDZ5r6/eIuacbMkuvBlqu9ammCZDYbuScyx0/VXZFI/czsoS4aCdCY RzPo3aqhubsJoGDCZLj5SmdkiGyLla36RWFVNiU5MVGZ7MrbcY5xEOS4+eUv/n2M8qYN MVuY5Y428ZMyJxOjYYJ1BtbtHPjLQ+HBbJ/bfmBPwl0UHF3vKl1N9F7XDbteSxFshMZ6 OfIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z+U+izVFukrEKq10kL5qCCsiT3qJmeLAo+mnNrOVCPU=; b=Nz0EAoWz0IU/5WY3XHQMld9RLIE6u7H0aYgobmmD8kamzGg4mtcs2vPs82+vygFZBt wetvkYu+4j9dTaJ+VCqIfs5TCKyUN4YPJhhpFIH4rkOsDCTQh7BDs7XqOYs50TyyyVFm nC+2yi1kUgxt+ZfZV/8/FqNnFNnAsHoHevE+n702XoJS7fGe0IrVPUkPN0lus3Q4qxdr PX3/2VPJswkQk2VdBHhf6k+P/rPrT1KL0RlchBhA90Jz7wCUp0RRHY8kkO+0NBL5zldr lkh6ZRtsqBJuYMN5eJHnWQKpXysNyQ7MNgZ8/GjmNUq2NRaHwAYPlQKy5K58rmQ7BpyR A2LQ== X-Gm-Message-State: AOAM531sNM8rAlW1WGBQD6c5OKhWmvFn7lvHDDkZeQpPog30lN0stT46 OZ2Sn9M3UNT1e1PT386yBetUxlKU3IzyQDGjJf4= X-Received: by 2002:ac2:58f7:: with SMTP id v23mr4043478lfo.390.1643319497799; Thu, 27 Jan 2022 13:38:17 -0800 (PST) MIME-Version: 1.0 References: <20220124091107.642561-1-hch@lst.de> <20220124091107.642561-3-hch@lst.de> In-Reply-To: <20220124091107.642561-3-hch@lst.de> From: Ryusuke Konishi Date: Fri, 28 Jan 2022 06:38:05 +0900 Message-ID: Subject: Re: [PATCH 02/19] nilfs2: remove nilfs_alloc_seg_bio To: Christoph Hellwig Cc: Jens Axboe , Pavel Begunkov , Mike Snitzer , Konstantin Komarov , Andrew Morton , "Md . Haris Iqbal" , Jack Wang , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Philipp Reisner , Lars Ellenberg , linux-block@vger.kernel.org, device-mapper development , linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-nilfs , ntfs3@lists.linux.dev, xen-devel@lists.xenproject.org, drbd-dev@lists.linbit.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, Jan 24, 2022 at 6:11 PM Christoph Hellwig wrote: > > bio_alloc will never fail when it can sleep. Remove the now simple > nilfs_alloc_seg_bio helper and open code it in the only caller. > > Signed-off-by: Christoph Hellwig > --- > fs/nilfs2/segbuf.c | 31 ++++--------------------------- > 1 file changed, 4 insertions(+), 27 deletions(-) Acked-by: Ryusuke Konishi Thanks! Ryusuke Konishi