Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jonathan Woithe <jwoithe@just42.net>
CC:     Bruce Fields <bfields@fieldses.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] lockd: fix server crash on reboot of client holding
 lock
Thread-Topic: [PATCH 1/2] lockd: fix server crash on reboot of client holding
 lock
Thread-Index: AQHYDLbN5l3eHxKrf0S5rkJdvCtsdaxqht8AgBNBKgCAAEAyAA==
Date:   Tue, 1 Feb 2022 02:10:06 +0000
Message-ID: <2B5F63F2-3B58-4F0E-976F-47EC7317B14A@oracle.com>
References: <20220115081420.GB8808@marvin.atrad.com.au>
 <927EED04-840E-4DA6-B2B1-B604A7577B4E@oracle.com>
 <20220115212336.GB30050@marvin.atrad.com.au>
 <20220116220627.GA19813@marvin.atrad.com.au>
 <1E71316C-9EE8-4C71-ADA1-71E2910CA070@oracle.com>
 <20220117074430.GA22026@marvin.atrad.com.au>
 <20220117220851.GA8494@marvin.atrad.com.au>
 <20220117221156.GB3090@fieldses.org> <20220118220016.GB16108@fieldses.org>
 <6349BB98-FB18-4ABC-A893-1CCB1E5CA3E5@oracle.com>
 <20220131222020.GB12905@marvin.atrad.com.au>
In-Reply-To: <20220131222020.GB12905@marvin.atrad.com.au>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eTh+k+/mZDWAuJ0YrbLhpacrj6aWVcVIAbxn6ErTwlrjBw7WfsTdkndjblGQ?=
 =?us-ascii?Q?SMgMMXrAjbDgJlb9VYEU4d++R/1QPdC0x7Gj3g9ofm8R7FrEGNYxme072t8v?=
 =?us-ascii?Q?5zV7kUElN7j0PLqg3uw9q8veISDhXGY6GA2E+9pkuQX0RW6Io+wa7MiUV7/q?=
 =?us-ascii?Q?sTcCaJ2L5YA5cd05+2TQWI5CMQRvMjibPaOKucTeh7rhBNi5Xpmg+PPJtjj5?=
 =?us-ascii?Q?NygKzd0fVpIObdafeg7Wu4L0IalcRm0mceq4mu0ZkhAQbXTxHtPWfphbgC8T?=
 =?us-ascii?Q?C7S1pD5fIJLPhdo4+Gh9EKIQXsRVG7Dw89YqRcObSgGsdTol4jjscZ7XSIky?=
 =?us-ascii?Q?9oeuuBe/wL4Tq3aop6spZAV8S8wrRebxJHQ+4GkbhiEQjQSx4NR46D4UHNck?=
 =?us-ascii?Q?mgGOalj6KDcwBKJ6esdJ/MmPYSq7Tcqz8E4ugQctSExbzwCQX/wBg/Oq4LjD?=
 =?us-ascii?Q?bVEl0LHxUWspZEkd8wpt90dZw+riwLRJzqgE4TYt+XC0zQ7tsM5kdx5iUUg3?=
 =?us-ascii?Q?d/nS7iepLuDWoL9KoSAqHfZBWo+wiAG8O4ciqgTpjM6KorNHQgUtXcU1LpA+?=
 =?us-ascii?Q?DqaWR4PwYPD4wqzzlkEhSilP8c6JUY5zz6evHSKvxTGFBmH0uJqHAOt6WTy8?=
 =?us-ascii?Q?lraSLhnaLDCvRX2i+RBsEuTCfaAY01stiZxJljBklhhg/a97iiMnbnI9+RU0?=
 =?us-ascii?Q?3F/syW6MTJoGmgVS4usSeTAaKnyuNp/aydm5xEsVgpk1/X+HuHx2zIl38IT3?=
 =?us-ascii?Q?iQRt38j8XALzvkbS0Gme1QTowTQpehv4Kxip9W7Y6o/Nh2gZtpbu9TxAsQUn?=
 =?us-ascii?Q?OxHmVaMJdaf78jbvN0mLOYSs8D/uXg9n5FzDYUfG5palagoR6vHh8kS5WFmM?=
 =?us-ascii?Q?jCqCFjhQ1gI32vhbHu5Zs4XqNj33D1fm9CiHbJQ29W8D61McN19qoOaF2+jP?=
 =?us-ascii?Q?3fduS9T6ZA8uGU0d8hyBp/a/alLWQ/M9U3iB0Lp6hVtLGO08Hm22/WPscdrB?=
 =?us-ascii?Q?oSLyUCTB9F2C96F3SCqVsTP8WMYGfywf0oV8DCEB/kd+gj48jYgtnLbYiA+9?=
 =?us-ascii?Q?96cfzlx8/qfFwrDKdTdHa8HnSHsl91ET9RynHVBWUHny0QRcULZERcd7H8hs?=
 =?us-ascii?Q?jnxaqzWjcjb56T7vIq0sj66lG8y/lvxw/JGK8EPq8l/6jrs6kxMFZeuSvqIy?=
 =?us-ascii?Q?FPQwJlmy8IafGBV4yirzX8UMW28cjfW/sapmxlNhCuS9i/2zOJDTK5rMVGqd?=
 =?us-ascii?Q?p7o2gYy1e5peeGF6uXwof4QjV5MWNRchjJtnlpoogJnkX2f4rcHM8gfe7abO?=
 =?us-ascii?Q?dAbDygfl7cTXCnJQrhmbxsvZizfeRuD7QCLMZnHVxF9KOrU0Xs0O7y0x1KeU?=
 =?us-ascii?Q?MVoo+6BTBJrSVQoWwE7XvoKzDjtw4EVnUKU1G4hXbkgbp224TeXvtbrETicC?=
 =?us-ascii?Q?C2SJ3S5uWHSYv6apAaEdqlioAjDHi2vNLAobCRxV24qTQ8xi8JBxWPN0BLWP?=
 =?us-ascii?Q?/VIhWmEeS3mIkNvZJZC77/e6KN3EymTc4Prjt7TS8YJ+RqDHpqhD13e2Mn7/?=
 =?us-ascii?Q?+9/dkrjjqH5DC7LwWJMlsP3gJu9ft3GSW6XDHs8bL6CmswKpeWu4MMzGD+PL?=
 =?us-ascii?Q?SBNO73K7NnmoYffnLer8khU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1A4542F730E4884B94E15B4282887A0D@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB4858.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8027f8a-583e-449e-7e9a-08d9e527f752
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2022 02:10:06.5031
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Y+6/Ju9kzzdNMWtROHHXR3KpaiJ/1G9xgXctK8MirDUv0mUH19lAuZixIoafoeXcShrDzp6rGbG+Hl75dOFQCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2752
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10244 signatures=673430
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202010011
X-Proofpoint-ORIG-GUID: w11pwL_HwP0QPUMdVOVf1wTkEC0T2iNL
X-Proofpoint-GUID: w11pwL_HwP0QPUMdVOVf1wTkEC0T2iNL
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jan 31, 2022, at 5:20 PM, Jonathan Woithe <jwoithe@just42.net> wrote:
>=20
> On Wed, Jan 19, 2022 at 04:18:10PM +0000, Chuck Lever III wrote:
>>> On Jan 18, 2022, at 5:00 PM, Bruce Fields <bfields@fieldses.org> wrote:
>>>=20
>>> From: "J. Bruce Fields" <bfields@redhat.com>
>>>=20
>>> I thought I was iterating over the array when actually the iteration is
>>> over the values contained in the array?
>>>=20
>>> Ugh, keep it simple.
>>>=20
>>> Symptoms were a null deference in vfs_lock_file() when an NFSv3 client
>>> that previously held a lock came back up and sent a notify.
>>>=20
>>> Reported-by: Jonathan Woithe <jwoithe@just42.net>
>>> Fixes: 7f024fcd5c97 ("Keep read and write fds with each nlm_file")
>>> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
>>> ---
>>> :
>> Hi Bruce, thanks for the fixes. They've passed my basic smoke tests.
>> I've applied both patches for the very next nfsd PR. See:
>>=20
>> git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git for-next
>=20
> OOI, is it expected that these fixes will appear in a 5.15.x stable branc=
h
> patch at some point?  I've looked at the 5.15.17 and 5.15.18 changelogs a=
nd
> they don't appear to be mentioned yet.

These are in linux-next right now. I intend to send a pull request this
week. I was waiting for some other fixes, but those are not going as
quickly as I hoped, so I'm going to send these two along with another
fix that are all ready now.

Once they are in v5.17-rc, they will be picked up automatically and
applied to open stable branches. If they do not apply cleanly, then
someone will have to construct and test a version of the fixes
specifically for each of the stable branches.

--
Chuck Lever