Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9585fff5-5e8e-da40-1ace-32eac137c88e@redhat.com>
Date:   Tue, 1 Feb 2022 08:48:51 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] rpcbind: fix double free in init_transport
Content-Language: en-US
To:     "Dmitry V. Levin" <ldv@altlinux.org>
Cc:     libtirpc-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org
References: <20220129004417.GA10610@altlinux.org>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <20220129004417.GA10610@altlinux.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/28/22 19:44, Dmitry V. Levin wrote:
> $ rpcbind -h 127.0.0.1
> free(): double free detected in tcache 2
> Aborted
> 
> Fixes: a6889bba949b ("Removed resource leaks from src/rpcbind.c")
> Resolves: https://sourceforge.net/p/rpcbind/bugs/6/
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Committed... (tag: rpcbind-1_2_7-rc1)

steved.
> ---
>   src/rpcbind.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/rpcbind.c b/src/rpcbind.c
> index 25d8a90..ecebe97 100644
> --- a/src/rpcbind.c
> +++ b/src/rpcbind.c
> @@ -552,8 +552,10 @@ init_transport(struct netconfig *nconf)
>   				syslog(LOG_ERR, "cannot bind %s on %s: %m",
>   					(hosts[nhostsbak] == NULL) ? "*" :
>   					hosts[nhostsbak], nconf->nc_netid);
> -				if (res != NULL)
> +				if (res != NULL) {
>   					freeaddrinfo(res);
> +					res = NULL;
> +				}
>   				continue;
>   			} else
>   				checkbind++;