Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Frank Filz" <ffilzlnx@mindspring.com>
To:     "'Chuck Lever'" <chuck.lever@oracle.com>, <bfields@fieldses.org>
Cc:     <linux-nfs@vger.kernel.org>
References: <164400374422.1026143.17746475126462213720.stgit@morisot.1015granger.net>
In-Reply-To: <164400374422.1026143.17746475126462213720.stgit@morisot.1015granger.net>
Subject: RE: [PATCH] Permit COMMIT operations to return NFS4_OK
Date:   Fri, 4 Feb 2022 13:02:12 -0800
Message-ID: <0ec101d81a0a$7bdfa880$739ef980$@mindspring.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Content-Language: en-us
Thread-Index: AQIf1eootFfPAesAqllEKesc4wY5pKv0aJIw
Precedence: bulk

> RFC 7530 permits COMMIT to return NFS4ERR_INVAL, but RFC 5661 and =
later do
> not. Allow INVAL as a legacy behavior, but test for OK also.

Do we have a 4.1 test to verify 4.1 and later doesn't return INVAL?

Frank

> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  nfs4.0/servertests/st_commit.py |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/nfs4.0/servertests/st_commit.py =
b/nfs4.0/servertests/st_commit.py
> index 12a0dffa061f..4ef87e69c5d7 100644
> --- a/nfs4.0/servertests/st_commit.py
> +++ b/nfs4.0/servertests/st_commit.py
> @@ -160,4 +160,4 @@ def testCommitOverflow(t, env):
>      res =3D c.write_file(fh, _text, 0, stateid, how=3DUNSTABLE4)
>      check(res, msg=3D"WRITE with how=3DUNSTABLE4")
>      res =3D c.commit_file(fh, 0xfffffffffffffff0, 64)
> -    check(res, NFS4ERR_INVAL, "COMMIT with offset + count overflow")
> +    check(res, [NFS4_OK, NFS4ERR_INVAL], "COMMIT with offset + count
> + overflow")