Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Benjamin Coddington <bcodding@redhat.com>
CC:     Trond Myklebust <trondmy@hammerspace.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: v4 clientid uniquifiers in containers/namespaces
Thread-Topic: v4 clientid uniquifiers in containers/namespaces
Thread-Index: AQHYGqGbn3llxfcWCk+UU34Bdwb7RKyFReOAgAAYOYCAAsQQAIAAHReA
Date:   Mon, 7 Feb 2022 15:49:18 +0000
Message-ID: <DB8B60C8-B772-4604-A841-47F789723D5D@oracle.com>
References: <6CEC5101-0512-4082-81F8-BDFEC5B6DF3A@redhat.com>
 <6ac83db82e838d9d4e1ac10cb13e43c5c12b2660.camel@hammerspace.com>
 <439C77F9-D5AD-4388-B954-3B413C1DF0E2@redhat.com>
 <596C2475-76AA-4616-919C-9C22B6658CA7@redhat.com>
In-Reply-To: <596C2475-76AA-4616-919C-9C22B6658CA7@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?e/LNKoYkgvfCdBFIHmcljeDQ2ha7f3y+dzBQAGMvP/6/0Q5lV9bU3g8cjsvB?=
 =?us-ascii?Q?azrtRj61B4n0mIJZTSdMJCFDRLgoYI16Ml6mO7yJzoTH6/edyoz3HvIZ8Akq?=
 =?us-ascii?Q?BYwgkxexPyu4t4mtQJmNFiGW5l6tbp+502n3Nr0PqDRt9okfycoLRZutP22o?=
 =?us-ascii?Q?5hFdFbxljt+ApYDC+9lccdovA/4AlX+xoVMpkYX6ahQ99s6MBUeu7EZZ9cy3?=
 =?us-ascii?Q?jUJwxXoyQ8qVmSJTnkYe5Bn7H1GreIzd5eviRdX9aGzQ2UFouMfj0zB2TIFG?=
 =?us-ascii?Q?VKYmF2GgTbchuG8hp5CNice5c9ZoTPkX/vgRfZ820OvrKbi2RzgJS/RVdJBg?=
 =?us-ascii?Q?CIjoe0JPiHZMyJH0c25WGxEnPipIXEnIwRNq7CcZhBcRu26KPWAQ2FJccnBm?=
 =?us-ascii?Q?ABiAIPE88YsNIauKfVJja66WyQrru9XInC/cNI3ezBeUcx29RElsp7nKK5ub?=
 =?us-ascii?Q?UfNTdpqJ2LRs5mshth4CfpsdNox9q+EJZ7p9pf6JlZuboV18eunKKcG1xax7?=
 =?us-ascii?Q?l/MYGqBGv97jgu94D+nYA6Ik1y70uAAwlMXzcAtXvzkBdWn6/hpnfzRfs3P6?=
 =?us-ascii?Q?2W6vv7Gmf4Cy/Mp0Ono8M7mpN26h1Vu+rBpmuPHNSjtlamf2nfwcQttRQhO3?=
 =?us-ascii?Q?sDCtJCBSFxGMmEvrFlm+P+nGV1CWL7JIOju6gEq7SbrJVoLtg+zVue51avTf?=
 =?us-ascii?Q?U/25Yzv9DQIscyHaXnQxR/ZllkVGNNLagBvQAERPomX7H875+1fQIvfu2uSk?=
 =?us-ascii?Q?n+7VD4jtteBUUaMRbZWaOh7W1ipkuMl8eilnJhwkJSR+YZPb3W6ZTmFeLWAe?=
 =?us-ascii?Q?G8yMZTFMjSER6xOhJK16Djoi+GdjnDNe1LM73aFP9uu3j7/dG9sBoTv1AcFI?=
 =?us-ascii?Q?zgpt4VDJG7sqfoq+r+tM30f3cchoB6P354YAdHjy8C75YiF3/LwiDs/R57f2?=
 =?us-ascii?Q?TSwFevLytB13Bvoobadn2obPisEhFy9r97f2PE4bJ/O7XKixCKGFPToQVwAQ?=
 =?us-ascii?Q?IbAzlkwCh+crc3FLvbqBa5b+eph14wPZ1VFBdokNQajSffqFQlbVNeHJNU71?=
 =?us-ascii?Q?2lL5CXZXRNbp/JrULLJPBmiGOHQG6z1Yt6rHTHVRN7kZ+5Hbo0IPCSYGwVcS?=
 =?us-ascii?Q?9GMI/78nMihKKsadHRVOhPWIOpbIhC/A1kCq97Q7oheIxXo/JRYxNLL/P6AB?=
 =?us-ascii?Q?jatVpXkOJHQPX+yS0XFc6oknJJYHfgH0JgDp9cz7AHsMvNaGL4J2y2Y7hw3N?=
 =?us-ascii?Q?PXThtQTYdnHjKZD6pXu7MSiZziD4Yu0MSBX3cyQh32Vt5ngo6GFQWMxi8fRW?=
 =?us-ascii?Q?DFD9dpj50HBcQrhbhEaS2BbMVsesI/kk3TqpWMusZxXzW3SHjg84nxf+naTy?=
 =?us-ascii?Q?xuS8OHGN14fmtzBeQDmEcVsbvLenKxKO2Mp4CS7qycIZnZwmMnwR5ZYoX7UO?=
 =?us-ascii?Q?A+j+p/vHnPI/0UmExjU6b6zzIBHWyxg//LqPvAzuTQ8KxJNG2sZyJIz3y/8y?=
 =?us-ascii?Q?uGZD/zf//P+jFKGaZZcaZFBMPsiavsMuimkVIl9hRWqmuoq85bl7yU/Gt69k?=
 =?us-ascii?Q?piUsMgx0et3SisZB0INrIX+/figfKx/sgAh4EoEaoULFib5hsLmg8c0R45Px?=
 =?us-ascii?Q?CPBvX8Z9kwZpRK9wGJt03Fk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C5ADC7902F12C144AB66CED42DDA110D@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB4858.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 445cada2-aafb-4a71-adba-08d9ea5166de
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 15:49:18.7506
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DapsrRpE4puwen5VXMPPLCNHF0o9Qqy3VFArjvEJgAQ8WqSC+D+6aiXDwL0GL2xNWiZx0QfZ6LATYEJ87XcPSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1678
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10251 signatures=673430
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 bulkscore=0
 malwarescore=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202070101
X-Proofpoint-GUID: zNJVAX0orAnkLpudKy9Gt6kcii3frQwT
X-Proofpoint-ORIG-GUID: zNJVAX0orAnkLpudKy9Gt6kcii3frQwT
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Feb 7, 2022, at 9:05 AM, Benjamin Coddington <bcodding@redhat.com> wro=
te:
>=20
> On 5 Feb 2022, at 14:50, Benjamin Coddington wrote:
>=20
>> On 5 Feb 2022, at 13:24, Trond Myklebust wrote:
>>=20
>>> On Sat, 2022-02-05 at 10:03 -0500, Benjamin Coddington wrote:
>>>> Hi all,
>>>>=20
>>>> Is anyone using a udev(-like) implementation with
>>>> NETLINK_LISTEN_ALL_NSID?
>>>> It looks like that is at least necessary to allow the init namespaced
>>>> udev
>>>> to receive notifications on /sys/fs/nfs/net/nfs_client/identifier,
>>>> which
>>>> would be a pre-req to automatically uniquify in containers.
>>>>=20
>>>> I'md interested since it will inform whether I need to send patches
>>>> to
>>>> systemd's udev, and potentially open the can of worms over there.=20
>>>> Yet its
>>>> not yet clear to me how an init namespaced udev process can write to
>>>> a netns
>>>> sysfs path.
>>>>=20
>>>> Another option might be to create yet another daemon/tool that would
>>>> listen
>>>> specifically for these notifications.  Ugh.
>>>>=20
>>>> Ben
>>>>=20
>>>=20
>>> I don't understand. Why do you need a new daemon/tool?
>=20
> Because what we've got only works for the init namespace.
>=20
> Udev won't get kobject notifications because its not using
> NETLINK_LISTEN_ALL_NSIDs.
>=20
> We need to figure out if we want:
>=20
> 1) the init namespace udevd to handle all client_id uniquifiers
> 2) we expect network namespaces to run their own udevd
> 3) or both.
>=20
> I think 2 violates "least surprise", and 3 might not be something anyone
> ever wants.  If they do, we can fix it at that point.
>=20
> So to make 1 work, we can try to change udevd, or maybe just hacking abou=
t
> with nfs_netns_object_child_ns_type will be sufficient.

I agree that 1 seems like the preferred approach, though
I don't have a technical suggestion at this point.

Again, thank you for drilling into this.


--
Chuck Lever