Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <164299573337.26253.7538614611220034049.stgit@noble.brown> <164299611271.26253.2968456569309914722.stgit@noble.brown>
In-Reply-To: <164299611271.26253.2968456569309914722.stgit@noble.brown>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 7 Feb 2022 14:51:17 +0100
Message-ID: <CAMuHMdVYRNnMn38wWcLDC_nFYr1HnRSFJ6DXwD4af=Cmx2J7dA@mail.gmail.com>
Subject: Re: [PATCH 01/23] MM: create new mm/swap.h header file.
To:     NeilBrown <neilb@suse.de>
Cc:     Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna.schumaker@netapp.com>,
        Chuck Lever <chuck.lever@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mel Gorman <mgorman@suse.de>,
        Christoph Hellwig <hch@infradead.org>,
        David Howells <dhowells@redhat.com>,
        "open list:NFS, SUNRPC, AND..." <linux-nfs@vger.kernel.org>,
        Linux MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Neil,

On Mon, Jan 24, 2022 at 5:26 PM NeilBrown <neilb@suse.de> wrote:
> Many functions declared in include/linux/swap.h are only used within mm/
>
> Create a new "mm/swap.h" and move some of these declarations there.
> Remove the redundant 'extern' from the function declarations.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: NeilBrown <neilb@suse.de>

Thanks for your patch!

mm/huge_memory.c: In function ‘__split_huge_page’:
mm/huge_memory.c:2423:16: error: implicit declaration of function
‘swap_address_space’; did you mean ‘exit_swap_address_space’?
[-Werror=implicit-function-declaration]
 2423 |   swap_cache = swap_address_space(entry);
      |                ^~~~~~~~~~~~~~~~~~
      |                exit_swap_address_space

mm/huge_memory.c needs to #include "swap.h", too.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds