Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Benjamin Coddington <bcodding@redhat.com>
CC:     Trond Myklebust <trondmy@hammerspace.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: v4 clientid uniquifiers in containers/namespaces
Thread-Topic: v4 clientid uniquifiers in containers/namespaces
Thread-Index: AQHYGqGbn3llxfcWCk+UU34Bdwb7RKyFReOAgAAYOYCAAsQQAIAAHReAgABAAoCAAEjVgIAAwaaAgAAlXYCAAAwlgIAAA4wA
Date:   Tue, 8 Feb 2022 14:42:03 +0000
Message-ID: <6211BF2A-2A00-4E00-8647-57D829D41E8D@oracle.com>
References: <6CEC5101-0512-4082-81F8-BDFEC5B6DF3A@redhat.com>
 <6ac83db82e838d9d4e1ac10cb13e43c5c12b2660.camel@hammerspace.com>
 <439C77F9-D5AD-4388-B954-3B413C1DF0E2@redhat.com>
 <596C2475-76AA-4616-919C-9C22B6658CA7@redhat.com>
 <DB8B60C8-B772-4604-A841-47F789723D5D@oracle.com>
 <b192022ce73ea690a117d7710b492e83be99df31.camel@hammerspace.com>
 <43990B9C-013C-4E77-AADA-F274ACBE4757@oracle.com>
 <8CCCD806-A467-432C-B7FF-9E83981533EF@redhat.com>
 <c9948f895e91abb76a21609bf629b88bbfcf4d9a.camel@hammerspace.com>
 <CEC36879-0474-44A1-984B-BAE69C168274@redhat.com>
In-Reply-To: <CEC36879-0474-44A1-984B-BAE69C168274@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vMbMSGhLrrSRFiUelmXdcuV1Blefp3Tpia4Xzh9QvXTVD/UIs1eko1AdNQPR?=
 =?us-ascii?Q?EGm02pGcgR38EU8qYEwYXNlb2avlr9mTzoyR5WjmCRRY77APF83gaUZF4g4f?=
 =?us-ascii?Q?RkbnIb5oUwvHQvTNf6eySS7wZ6hXQPFw18DN3WBbfvQcg07IXMqvmMWtqXAH?=
 =?us-ascii?Q?GZU4qbqPvm5pqxp0P7xzzBjeBS8DlSz29+yVBZkFELOQqe4966UL79C1Uytg?=
 =?us-ascii?Q?ezahwQT+Cp4uPVRquJiF84BHoVrd/pk1Eg/A1TGPcqfli8m4GMYOForR/WDC?=
 =?us-ascii?Q?B0x7ns/7WNnUe/6Tm84JPaeNXwakgisFvcgoa22SyBnIA3k0Af8pLAV1RyO+?=
 =?us-ascii?Q?6mxLNOn4ansCuKrN8jPYBimBqyGVvK7cjEyCLr1qrZGLS40jO5WWNCoxWeiS?=
 =?us-ascii?Q?ErrrPbc03XrIihydJ6Dowjqxny+0RbD86X0XPr6KSykQZ59VdqH+tzNXNAut?=
 =?us-ascii?Q?sfLMkU/eqqXWvl3ZCMatiTXA7ikkmHpZX4YvrBpLOYz3I/+1dqwF8gSN2RUQ?=
 =?us-ascii?Q?RLlBTsYVDCwGnw5tz+BzhDi+r3b1ErOawkKQrqXFbB87vEuq7vktuZUgkORF?=
 =?us-ascii?Q?MmKuXeXvRRBfO5kiMMfy4P/5B0j0FX7DuriDACZDLakVH9AM4pGUMq340sBs?=
 =?us-ascii?Q?PMQ6lSHEI2Vb9ZwxMxrRudXjmg6QxZNXu64qmGFX4a9v+QU1WFyOJEUvgUcr?=
 =?us-ascii?Q?Q0eM/g4n28Ov0z0oWfnFjxK8NqNNhJe8Um75VOW8yZA37/ZQzfX+AkTTXJHE?=
 =?us-ascii?Q?kafwDqQTsPb5z7LOAqJ9LOXZ/c/Hg5jlBMiybVkNoNUUSy3Cnx4znREWva8c?=
 =?us-ascii?Q?cLtXje9XHLEb/2jcLZq4cDoDdDFbk3/qE8s1YJcUCywFf165ea6RDZMYYXWY?=
 =?us-ascii?Q?WB+t8jO5QXXXGySi54sjnJ5JCLwrRZONHX1CHeeaXLAJyyIgpW7Jh4We6+KS?=
 =?us-ascii?Q?x4BIo69WzK9IxaAFxAFxyO33Tau5+Hl0X9+relYchBGWFaiVoRmKQ3HmvO+C?=
 =?us-ascii?Q?ZnVCpxt5DKgOpf9HwB7GENYy5Mm43vdSMtzOxJJ2nGC/3ZoJR+6gh+7U46jc?=
 =?us-ascii?Q?WORgFY8ZI3d/iSTXlT8uW9iDjAfrA4mnZKZ3PD2Xt2z91BV6jJlnT2NICKqC?=
 =?us-ascii?Q?1Yc6GfBenvulpC7pTzrQitTXYSPeCndU0wlO8hh/4eoDhG7qXHerivrweOaW?=
 =?us-ascii?Q?71c7ySqkqt9in4LvbJouKnR8RGG9RPDbwYcQr9S/aVK9UI4vFMPCbopbSiea?=
 =?us-ascii?Q?nNPo1SJ81XpzJJpqdkHFTd5Q0wDrPm88s1KjW2JsMJDuSW5ezLbQFy5cEbMC?=
 =?us-ascii?Q?UglVbm9MS83nUvxSrt2+JCx7rxtEGKoUaAxHhK2kjYwWkK1hJzhbM1m3Ld/D?=
 =?us-ascii?Q?KvNyjcUrMKZFbi2sWmR7OBo82nxpwbqkZvxbd936M5xkCkkNWgl/tkVqG6m3?=
 =?us-ascii?Q?Qq1N81Wzai18MUsWNbSAyek7RPCx9QnhvzwqxP0LFIWIpETu8XJ5UO+AhL1R?=
 =?us-ascii?Q?Sqcar53OmaYz786B3sUUCqGy/gPx8b6XlVkQE1VVpPLmb+hl90V6su8d2kpS?=
 =?us-ascii?Q?Suy4awI2YHoF0JnHggmzBE6WG5/WQ/xugNOOuZ0f3PHSlhjl2y8mwMHDN4f9?=
 =?us-ascii?Q?MIeGDqFizfPE//BgX7AvZm8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <51C58E9491FA41408CDF1684643297C9@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB4858.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a1d3dc9-b89b-4327-8f3f-08d9eb112c37
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 14:42:03.7977
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: p1GmlR6/xinigY5vU9cJ9r1fCGSIw4p/cdCcO1ZficYdjq0gTL4xcYJDxdmoBcu+b/Fug6AUfPWrCjiKX07GJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1001MB2121
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10252 signatures=673431
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0
 mlxlogscore=999 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202080090
X-Proofpoint-ORIG-GUID: E3oPTqoLSygy7jDkFR2RBKNYokZGUu4t
X-Proofpoint-GUID: E3oPTqoLSygy7jDkFR2RBKNYokZGUu4t
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Feb 8, 2022, at 9:29 AM, Benjamin Coddington <bcodding@redhat.com> wro=
te:
>=20
> On 8 Feb 2022, at 8:45, Trond Myklebust wrote:
>=20
>>> Can't we just uniquify the namespaced NFS client ourselves, while
>>> still
>>> exposing /sys/fs/nfs/net/nfs_client/identifier within the namespace?=20
>>> That
>>> way if someone want to run udev or use their own method of persistent
>>> id
>>> its available to them within the container so they can.  Then we can
>>> move
>>> forward because the problem of distinguishing clients between the
>>> host
>>> and
>>> netns is automagically solved.
>>=20
>> That could be done.
>=20
> Ok, I'm eyeballing a sha1 of the init namespace uniquifier and
> peernet2id_alloc(new_net, init_net).. but means the NFS client would grow=
 a
> dependency on CRYPTO and CRYPTO_SHA1.

Or you could use siphash instead of SHA-1.

I don't think we should be adding any more SHA-1 to the kernel --
it's deprecated for good reasons.


--
Chuck Lever