Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Benjamin Coddington <bcodding@redhat.com>
CC:     Steve Dickson <steved@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [nfs-utils PATCH] nfs4id: a tool to create and persist nfs4
 client uniquifiers
Thread-Topic: [nfs-utils PATCH] nfs4id: a tool to create and persist nfs4
 client uniquifiers
Thread-Index: AQHYGca9ZpW/pPf5rEWUIwyc/qfEDKyJ14OAgAAE1wCAADSIgIAAHlWAgAAWowCAAorMAIAAH4+A
Date:   Thu, 10 Feb 2022 15:21:32 +0000
Message-ID: <10D2854A-310D-44DD-A31D-83385AD7D87C@oracle.com>
References: <c2e8b7c06352d3cad3454de096024fff80e638af.1643979161.git.bcodding@redhat.com>
 <6f01c382-8da5-5673-30db-0c0099d820b5@redhat.com>
 <33B10EBB-3DD1-45FE-B7D2-D5EA21DFB172@oracle.com>
 <839b09ed-fd21-bda1-0502-d7c6f1fa9e88@redhat.com>
 <32D8EBC9-652A-49D7-B763-A82E2AEF6282@oracle.com>
 <281b1976-9b40-fc53-301a-2846c2ead5aa@redhat.com>
 <13069AB1-28EB-43F6-83BF-41E9B9501C75@redhat.com>
In-Reply-To: <13069AB1-28EB-43F6-83BF-41E9B9501C75@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sILnnbkxq09VyhNBwLAJ80wh4V5rWf51savHKCe4KMGjgacyFW5T+Nr/vmuC?=
 =?us-ascii?Q?kPDcqGUK8UUHqxJ24SPIc6STnWQrhz18E4+K2fTzOTlocIJnno3mGB0ucgx3?=
 =?us-ascii?Q?xIPo4BwJWbIeBy/UW97LHuOSNmt/khqyKka2fyzX0e066vksWq/EfoXFXFzU?=
 =?us-ascii?Q?ENgwYrKTXR08GA589ZebqcCPV1qcwlkazbXNZkXoDefI00MM1zHAVseV4Ijz?=
 =?us-ascii?Q?ILcvKMQe/vH2rTM5QAJs1/vZBbT6OYd1qUHDtZRYDh7453MlYcFtwOUdyaEe?=
 =?us-ascii?Q?8ORrH2Xba1G//rZVeAHnO352YZLO5o+aovRIasig3zSh0kDci79NlX20Qj2D?=
 =?us-ascii?Q?Qj3OR4ZAroftj092KXArjpWLaIY2if1Z+1TBLpL9286qyFC6ViWQg6HmckvL?=
 =?us-ascii?Q?Hq1PHY5CgSsbwHF+ptB4SrhhRPqP0VSn21J64Asac4so57ChYTz1cAcdemB8?=
 =?us-ascii?Q?p0xIN86upGoapqYpjkBlp0ePY1JbvICHXfZHc+vWZq+Ql1QCHSwQuk2oAali?=
 =?us-ascii?Q?i8ryteaBVlG2PjLJkOvCrBp0RJ9yMSLpVy2+vrDMopdaVUyMhFk5SeZJr287?=
 =?us-ascii?Q?72AmRIuj4Pq5eQLQ2A33ZFK6CmOu0s6bn9gBPJt4UUs3AsBx+gjc/XUawBvb?=
 =?us-ascii?Q?GnG1xq8IIyfN9T7aNmsBpip48G7obrhwtBH65l9u45nTUJ3+1W856Mysg8F/?=
 =?us-ascii?Q?+RCuK8jxg7JTSTJHESKAgFop+UwNnmRSSlfpOR91urSMEaP831gmozcsgt9i?=
 =?us-ascii?Q?rnYz6aBN9BtgZsyh2EN+on1lUK7O5h62UGau4jx15e7yGyoMR3niZGw4L9vG?=
 =?us-ascii?Q?n2qCoRgJ0NJ7KAfSNAPr1khRv8CH3oeeGNVPjDUaIsJCs2JpzfeUV7l83cjv?=
 =?us-ascii?Q?TJr/74osgWvct4ntDSDoz7saBkKit5ePrb4NbVRdQdD1qQH1pQrRk9IpkNRI?=
 =?us-ascii?Q?Gpm2W6gs+DwUrb2VvOhYgeRu4CSNBJ3/mBl9CCzmg6MrUad9+l5M0LmvmKub?=
 =?us-ascii?Q?tF2rXVre0z4dAaETIVbKvvZvGJnS70gjOrPkaDtrdybQ8bCiCvmxyfEYbsiS?=
 =?us-ascii?Q?biHnvyYoyht1XtuOnikJgxpy+hni/TEj3Dg2WpvUbHAUMTAcv5U4G3swN95M?=
 =?us-ascii?Q?SSSwfuP5+vth4xHeHAr/ker5wJ+U0hNU9m+Qdt9f8oT+7dY/KeRg92lu3P+1?=
 =?us-ascii?Q?J+VU2vTybpYvp76f61+RUda9Q4X4PTdtPbUEgzLYreNVobTa9eEY/BRC0vL5?=
 =?us-ascii?Q?ShWa62z0SOFhk1KKM4fmx49mFnXem92Ij503Y4Rgi5xGyqqGBfEEErU5Iz53?=
 =?us-ascii?Q?ZiNrxz49LcJYwuQRBJ4rWwHWa6TAwaZWHKwKeXqSQmHIxidIyS7QHm1hV8N/?=
 =?us-ascii?Q?FJaHzxo93QMzpqPZ3kGChCzBFoo7adcMRlbGZhUCu1QPmWQShlEyNXz/XFlR?=
 =?us-ascii?Q?wX1bI/XKG5lLvSA/SIGQUSsNLDayaA+bJTLTtTp1WpL7EMYlpx3GhmE3l3yU?=
 =?us-ascii?Q?WiBNhpG+tqMhgJ0LgM7McKcAhal155X4IVLGzxzeaVA5eyKkoOIh2fVYu7BI?=
 =?us-ascii?Q?E3fda6E4Oq3kTbFdPiR2l5Af9ICPY3RtegMXLspnc2H6Rz6F4X7u8FoPIWoo?=
 =?us-ascii?Q?7HX3liswowToShLqUuWK9Eg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <062482430097E94A91BBDDB9FA06E425@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB4858.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 768cf496-b11c-475b-39a5-08d9eca904a9
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 15:21:32.0994
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iBGQAU1COpt3pfrkkK+w0HOqTFrdXLQB0NVw2WNqGoPRjdD5SpYL1M/ICWeAH+oE5Dbykj5EsYx8HqSogh18dA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4367
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10254 signatures=673431
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 suspectscore=0 adultscore=0 malwarescore=0 bulkscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202100083
X-Proofpoint-GUID: gioPyfLOzS3tSnc4yuLFhtLjPX77-L_f
X-Proofpoint-ORIG-GUID: gioPyfLOzS3tSnc4yuLFhtLjPX77-L_f
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Feb 10, 2022, at 8:28 AM, Benjamin Coddington <bcodding@redhat.com> wr=
ote:
>=20
> On 8 Feb 2022, at 17:39, Steve Dickson wrote:
>=20
>> On 2/8/22 4:18 PM, Chuck Lever III wrote:
>>>=20
>>>=20
>>>> On Feb 8, 2022, at 2:29 PM, Steve Dickson <steved@redhat.com> wrote:
>>>>=20
>>>>=20
>>>>=20
>>>> On 2/8/22 11:21 AM, Chuck Lever III wrote:
>>>>>> On Feb 8, 2022, at 11:04 AM, Steve Dickson <steved@redhat.com> wrote=
:
>>>>>>=20
>>>>>> Hello,
>>>>>>=20
>>>>>> On 2/4/22 7:56 AM, Benjamin Coddington wrote:
>>>>>>> The nfs4id program will either create a new UUID from a random sour=
ce or
>>>>>>> derive it from /etc/machine-id, else it returns a UUID that has alr=
eady
>>>>>>> been written to /etc/nfs4-id.  This small, lightweight tool is suit=
able for
>>>>>>> execution by systemd-udev in rules to populate the nfs4 client uniq=
uifier.
>>>>>>> Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
>>>>>>> ---
>>>>>>>  .gitignore               |   1 +
>>>>>>>  configure.ac             |   4 +
>>>>>>>  tools/Makefile.am        |   1 +
>>>>>>>  tools/nfs4id/Makefile.am |   8 ++
>>>>>>>  tools/nfs4id/nfs4id.c    | 184 +++++++++++++++++++++++++++++++++++=
++++
>>>>>>>  tools/nfs4id/nfs4id.man  |  29 ++++++
>>>>>>>  6 files changed, 227 insertions(+)
>>>>>>>  create mode 100644 tools/nfs4id/Makefile.am
>>>>>>>  create mode 100644 tools/nfs4id/nfs4id.c
>>>>>>>  create mode 100644 tools/nfs4id/nfs4id.man
>>>>>> Just a nit... naming convention... In the past
>>>>>> we never put the protocol version in the name.
>>>>>> Do a ls tools and utils directory and you
>>>>>> see what I mean....
>>>>>>=20
>>>>>> Would it be a problem to change the name from
>>>>>> nfs4id to nfsid?
>>>>> nfs4id is pretty generic, too.
>>>>> Can we go with nfs-client-id ?
>>>> I'm never been big with putting '-'
>>>> in command names... nfscltid would
>>>> be better IMHO... if we actually
>>>> need the 'clt' in the name.
>>>=20
>>> We have nfsidmap already. IMO we need some distinction
>>> with user ID mapping tools... and some day we might
>>> want to manage server IDs too (see EXCHANGE_ID).
>> Hmm... So we could not use the same tool to do
>> both the server and client, via flags?
>>=20
>>>=20
>>> nfsclientid then?
>> You like to type more than I do... You always have... :-)
>>=20
>> But like I started the conversation... the naming is
>> a nit... but I would like to see one tool to set the
>> ids for both the server and client... how about
>> nfsid -s and nfsid -c
>=20
> The tricky thing here is that this little binary isn't going to set
> anything, and we probably never want people to run it from the command li=
ne.
>=20
> A 'nfsid -s' and 'nfsid -c' seem to want to do much more.  I feel they ar=
e
> out of scope for the problem I'm trying to solve:  I need something that
> will generate a unique value, and persist it, suitable for execution in a
> udevd rule.
>=20
> Perhaps we can stop worrying so much about the name of this as I don't th=
ink
> it should be a first-class nfs-utils command, rather just a helper for ud=
ev.
>=20
> And maybe the name can reflect that - "nfsuuid" ?

The client ID can be an arbitrary string, so I think not.


--
Chuck Lever