Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dai Ngo <dai.ngo@oracle.com>
CC:     Jeff Layton <jlayton@redhat.com>,
        Bruce Fields <bfields@fieldses.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH RFC v12 1/3] fs/lock: add new callback, lm_lock_conflict,
 to lock_manager_operations
Thread-Topic: [PATCH RFC v12 1/3] fs/lock: add new callback, lm_lock_conflict,
 to lock_manager_operations
Thread-Index: AQHYHjn6Ujwua4SbTkavmYzo8J2MF6yM1pmAgAACGACAAFdVgIAAAKEA
Date:   Thu, 10 Feb 2022 19:44:03 +0000
Message-ID: <E7CBF516-9DE5-4AC6-AFB1-148188C74699@oracle.com>
References: <1644468729-30383-1-git-send-email-dai.ngo@oracle.com>
 <1644468729-30383-2-git-send-email-dai.ngo@oracle.com>
 <20220210142143.GC21434@fieldses.org>
 <c069bb1b0ec50358fc4d093ebd7482c7484d77b4.camel@redhat.com>
 <47535edd-9761-f729-1d6b-f474a31eeafc@oracle.com>
In-Reply-To: <47535edd-9761-f729-1d6b-f474a31eeafc@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gG4+4cine7fIVBTWt//WFtlUGXhYoCNHdCk3jCuxU0nR1gM7ES4glVkcuePn?=
 =?us-ascii?Q?6o7NymcovXf+r6svjcOL/f8hMqxwAL6S8bh+/NEY4w9MKFQm4aS75zvUiaL6?=
 =?us-ascii?Q?yATDG3+6c7tQA27SSPGj0lgf7A4G3D1B9aj3NCOfXoIsLk5EMK2uWuBuE9UQ?=
 =?us-ascii?Q?RVZ70DaRcfc4qa03mgnYIiaW99iob+oIT5BZld5iTQBYOYCIRJZd4xbSj1Jv?=
 =?us-ascii?Q?Xb2iVZDcTz2o9sQXbR0U4aksu2crbY/miU8cdjP2gsPdiqvzVYYDrZOm4E2v?=
 =?us-ascii?Q?s3pknuULz7lmr6MuSMHzBBJJVIgnhpDBtb4LwU8TphVWU3SpdQd6xUkVzI+G?=
 =?us-ascii?Q?1irjq3pA6MCLEgVF/js0J9X+KcEVKA16ncwlCyTLj1Uhop5pnNwA4clqI9xG?=
 =?us-ascii?Q?i2GiKAMQhPP/si6ibaBqD7UDaWjTWOR5F/7UVFP8zbh05E8DJfkQKWrC0pAL?=
 =?us-ascii?Q?dm2yQwdTRYaEFGChV4AVrZfz3L3AMfwUpMXrle22vH4KmcQ6AO3g+g6p9fNJ?=
 =?us-ascii?Q?ZRHVKO7MvDUoDWqzsCt2P3ZEUcs3mjNM6r5/rR8v2D0LJNWCpYhA3ZHq9NkC?=
 =?us-ascii?Q?fN+U+ZQYpY3w0DogQ+Sk3IwaCpHSJmPPzvS8Q4KSu32qv+psZiVorhtWfbAQ?=
 =?us-ascii?Q?V2yA9W4e1w274FkQK4SeG73KMPdTEMnws+HKnUzT9+ilbzvewi9Iq4ly6nBM?=
 =?us-ascii?Q?aPg70keWhuaUpIC1F7C2xXTESLb0XbsIvrLGYZfdCQbkouX2eBsNaXq8vYgG?=
 =?us-ascii?Q?+WWYo5e1ooVcOkF3q58s+lqrylWaTFD64LWL+T6LERIO0E/hNYbUBLJthe1K?=
 =?us-ascii?Q?n3NNN4pXdLolNkY7+3lGivLDOWhe817XJ07EpGofgPZ7K81DWxbnEUu5fBKG?=
 =?us-ascii?Q?BX64vdCeNF1++baVMyMNV3KRZZtuUjKHhAJzYE4ZoatOwEaWHWoFK7ohCdfS?=
 =?us-ascii?Q?vTKJsvY5XiUrH5KY/m6dgccAa2q11582Au0x5XhbyYbUGVM5lRk2Qy5X01TQ?=
 =?us-ascii?Q?SY4IGB4x0K4evEzxMFSZhrrCf9wBP4dOtzt35nK+A6wr9jVWgz2smZ37//gJ?=
 =?us-ascii?Q?Ao9vlEnnPyZW1JVeWvanXf8nZXimp+Dmjcm+Hna/mLaAUj1pAf3oeADfmfiN?=
 =?us-ascii?Q?XIhbkt/xAlWGQ+WU3N8h3scoGO3RxtWHPCegTiDXKEqsqVs9BJjM5VLLYwvq?=
 =?us-ascii?Q?asWdRAHp/rySm/YPi8nhZGkncC7FOrEd5ipJRI+NVPX8SCDwVJnpbcJx7y4n?=
 =?us-ascii?Q?IBTxc5LTuLo7oIxXQLA8rsxd546RJmWKwm2o+qWLiAV/ATuDDl5n9Js0V4aa?=
 =?us-ascii?Q?rJVDaVpAxrydnG/YQR4gVkZBsPI9b6yDm1Ae6tm+n7mf0OpnD+U1kzmplo+Q?=
 =?us-ascii?Q?3kDNCTcdR/M0pEiv4q4dE7fHq9I1N8fLcrTK4S1pKNbUh6JzdkaCZVxys+oN?=
 =?us-ascii?Q?YLIxyoB9MBhu5af7l6SNkFWunbfLi+P2CRuD66kjzqMpwoKUtuQmrJT/LS8a?=
 =?us-ascii?Q?XWFosx0RXPwi8CGv00lQNxwycVes/R2adC8ow4C/uPSALnauzEgtXXyZN1ta?=
 =?us-ascii?Q?mFnKoBO5bT9roW8HhCSIsu3a835w3CGhuwRQsoeMQ2dlshcMXa5JiIBh8lhQ?=
 =?us-ascii?Q?tq7nKLUrwkI4aVGfOds9Cxk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C2D10CBDF70ABB40B55C1E972393B60F@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB4858.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c163ba58-7f1e-4e0a-0a7d-08d9eccdb155
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 19:44:03.6133
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YIaLPKkuozn/PQoVxhAgc3PCWrvgkXNpAge5gqAlsCEBaOzWrYGOTyX8fh/xsuT06GZOuhNa53dAutgCXpu57Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1269
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10254 signatures=673431
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202100104
X-Proofpoint-GUID: cXPUAkDteflTuC021wVuyav-DkrvCPMX
X-Proofpoint-ORIG-GUID: cXPUAkDteflTuC021wVuyav-DkrvCPMX
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Feb 10, 2022, at 2:41 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>=20
>=20
> On 2/10/22 6:29 AM, Jeff Layton wrote:
>> On Thu, 2022-02-10 at 09:21 -0500, J. Bruce Fields wrote:
>>> Jeff, this table of locking rules seems out of date since 6109c85037e5
>>> "locks: add a dedicated spinlock to protect i_flctx lists".  Are any of
>>> those callbacks still called with the i_lock?  Should that column be
>>> labeled "flc_lock" instead?  Or is that even still useful information?
>>>=20
>>> --b.
>>=20
>> Yeah, that should probably be the flc_lock. I don't think we protect
>> anything in the file locking code with the i_lock anymore.
>=20
> Will replace inode->i_lock with flc_lock in v13.

To be clear, if you're fixing the documentation, that would need
to be a clean-up patch before your 1/3. Thanks!


> -Dai
>=20
>>=20
>>> On Wed, Feb 09, 2022 at 08:52:07PM -0800, Dai Ngo wrote:
>>>> diff --git a/Documentation/filesystems/locking.rst b/Documentation/fil=
esystems/locking.rst
>>>> index d36fe79167b3..57ce0fbc8ab1 100644
>>>> --- a/Documentation/filesystems/locking.rst
>>>> +++ b/Documentation/filesystems/locking.rst
>>>> @@ -439,6 +439,7 @@ prototypes::
>>>>  	void (*lm_break)(struct file_lock *); /* break_lease callback */
>>>>  	int (*lm_change)(struct file_lock **, int);
>>>>  	bool (*lm_breaker_owns_lease)(struct file_lock *);
>>>> +	bool (*lm_lock_conflict)(struct file_lock *);
>>>>    locking rules:
>>>>  @@ -450,6 +451,7 @@ lm_grant:		no		no			no
>>>>  lm_break:		yes		no			no
>>>>  lm_change		yes		no			no
>>>>  lm_breaker_owns_lease:	no		no			no
>>>> +lm_lock_conflict:       no		no			no
>>>>  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D	=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D	=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D	=3D=3D=3D=3D=3D=3D=3D=3D=3D

--
Chuck Lever