Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <47535edd-9761-f729-1d6b-f474a31eeafc@oracle.com>
Date:   Thu, 10 Feb 2022 11:41:47 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH RFC v12 1/3] fs/lock: add new callback, lm_lock_conflict,
 to lock_manager_operations
Content-Language: en-US
To:     Jeff Layton <jlayton@redhat.com>,
        "J. Bruce Fields" <bfields@fieldses.org>
Cc:     chuck.lever@oracle.com, viro@zeniv.linux.org.uk,
        linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
References: <1644468729-30383-1-git-send-email-dai.ngo@oracle.com>
 <1644468729-30383-2-git-send-email-dai.ngo@oracle.com>
 <20220210142143.GC21434@fieldses.org>
 <c069bb1b0ec50358fc4d093ebd7482c7484d77b4.camel@redhat.com>
From:   dai.ngo@oracle.com
In-Reply-To: <c069bb1b0ec50358fc4d093ebd7482c7484d77b4.camel@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmQ1MUpNMjlvV1JSTlZ2Y3pxeXErK2hrdnJOaENaanJWbStZUGxJYzZNbVdy?=
 =?utf-8?B?SnpUMFM2UFpldUxVM2RuaFN0bUtuU3lzWHFKYUx4bWtWYlI4NEhlMFMwNng3?=
 =?utf-8?B?dmNNV0x0ZWVMRHdKWW83WVdreWsyYmtXMk1HYVFOQ0xpKy9ybDhZQi9EdEIz?=
 =?utf-8?B?TXBXQ04xanRiUlhxcFRyTDJrRlRreXdlMGJmR291cTloNHQ1SGFaQ2tDanR0?=
 =?utf-8?B?b2hCM0o0RzNLamNpc0R3T25RbjJvRWJkSktRQmpZbm5EYnlvdVVPOTVwNW45?=
 =?utf-8?B?K3UzMjJzZlBJNExuK21zTklyMXdZVVMvWUcyQ2ZBSThjcmJnWkg3Z21LWjNj?=
 =?utf-8?B?TTE4WUo3eUtiVXVaSStFQWR6Si9HMkFmNk01d3FiRytWWEhTaC9OVHkwNzZ2?=
 =?utf-8?B?dHhPZDNvbG55KzZ0YThYVDBGcGVYTjU0NUxOMFdvZ0JoVkJtQkduRzBEOE5C?=
 =?utf-8?B?WjlFcjN1ZGUzRTZQMU1YR0RzNG4yUE9FMlprdXh4QmZLblFxblp2UXBiRXBQ?=
 =?utf-8?B?M1ZsWEhFUjUxUG9kaDN0UVkzeE9tMnV2UCtKajRrZENzZjNvWFkvOEs3MU1a?=
 =?utf-8?B?SzhUYVByVUdFem44QnIzWGpRL3A0bXB3WWxSa2xLN1RhNkNlM3FFYS80MjZn?=
 =?utf-8?B?Q2RPMDZqaHBjY2orWDRLRGtQcWtUTzIxTjQrN3R3cFk1WWpQbVlmdXZoQlZh?=
 =?utf-8?B?SmIrZmptdFNDMUNFbG41K0hNTlF3OXhmTk1mbmIrK3Q3MGp2M2NNcG1ITG5w?=
 =?utf-8?B?Y0VNT2FoVkhOc1k0LzVCQURIQUV3YXFsU1NzRko3cDY1Nkg2ajRPd3RWaS92?=
 =?utf-8?B?YmgzMW50Q1REb0hNOXdVcERiV0l4YXRJdWhWc1VucFpLUzZaam0wbSthZElV?=
 =?utf-8?B?V1BaNmF5VEorWm1xVVlQaVRBQjVleGwxYngva3NISlc3MnM1U2hsc2RVZVNu?=
 =?utf-8?B?WjBuMnY4TW00dmVscmJFYWhRcUdZZWVVeUpYSXZ5K0FVL2hPRm9NWnlhcDI3?=
 =?utf-8?B?TFgwZ2t3RXNyWGovL2NvaGxOaHhsNmlNRUFtZzc3bjdKcnhNbC91VTJlSVho?=
 =?utf-8?B?cldWcEoxQnV2TXprNTRGUWRKUHNyTHBWSElvWDBiSW1MUm5wTThVZkoxKyt6?=
 =?utf-8?B?VU42c2Z6bS9GYk5WRUp5bjNjRjQwMDRDUno3VkN0S1R1RTJQNEFFYmZKWk9J?=
 =?utf-8?B?ZElRVnVjU2JaQUxSSE5oUXVkYU5ZSmxUbGpIQnBlZ1NqbXBadU8zQ2twMmxJ?=
 =?utf-8?B?VHVBVy8vazNobXAxbkNybGpZVWxPS2c4SGREVXdSa2c4dy9BditBeDg0SjB6?=
 =?utf-8?B?T2ZUcDY0bHB0b1FUaFY0ek9hZTZ1dm1oNElhdGJVVnR3K3FzRGRweXplaThu?=
 =?utf-8?B?MzdrTGgrbUZ5eWxFcm1ybHBxc1preVgvSnJnYU1ZRkpENkpMSzh0ckFjOXly?=
 =?utf-8?B?OHdBMTBxVUpFSUUwRFU2cGJUcXo2Y1J0ZzZqV2Mvai9CRHYrQU53bkdvSk52?=
 =?utf-8?B?Zmk4YWRBTjlmMFIxV2w2ZGwxVngrU0t3dytjSWY5eW50VTdMdFYvRi9RbXpS?=
 =?utf-8?B?b1BEbDRJZkwrOHRGWkxJL0dDN0JqR2RkcUl2WWFkSEd6TmFYUWF1M0EwajJF?=
 =?utf-8?B?TEN6U0hDWUVsUWcrajArd0tlaEFJMVJ5NVVJZnNBcXRVZXg1WUpqSXdLekQx?=
 =?utf-8?B?TzVTZTVtMm9DSVpVaDk0UmhLSmhXTEdETldNMmRkS0tkcUNOdEdOeFljSU4z?=
 =?utf-8?B?aysxT3o4SEFodmNxSjNpUFFYejVkQm8zN0doR3dGTmIzbVVkZTEvMjVnTEVR?=
 =?utf-8?B?RVQzSzlaOG05d1ZHQnZjY2hNbXlVUXdxakkyVDZ0Q2VCUGVxU1FhWVNNOVda?=
 =?utf-8?B?YWZMNGZDUWdJNkV1MzA3WGVRbkFLRW9NQ3ErS1ZrbHVRVU4zSW1vMzRmZWg1?=
 =?utf-8?B?bGpMMmlRM2pLejQzU1crT0htaDlPKy91YjBKL1kremtpMzFFZUdKbVI5UDh1?=
 =?utf-8?B?WVhBckhBRnBLcTAxRjBBTFdoVStmdlNwMEhFY3NMcFFjN25Ybndrak9IQVV1?=
 =?utf-8?B?bk5rSDkyNU9VNjlNVEFiekdObisvTnp0bmI0QXB1N1paQWRCZm1taVJCQlZN?=
 =?utf-8?B?WkNjdnlvVzIvU253UXUvUjJFUnBsZnlSQURmUkRIWUk3RnN4RTltQnZaYkdM?=
 =?utf-8?Q?pxxLg/FTczOjp4AW/bfJhQM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8589ae0-47c1-42a8-1d7e-08d9eccd614c
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 19:41:49.8214
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GS37SHMYh/lQICQGKgsF0r7SxJqjRu7q6/tatzHGK4ulC6csTYg5/l9Q3NkYbb4BjJzkuS++956FD6mZMlSJnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4906
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10254 signatures=673431
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202100104
X-Proofpoint-GUID: gUnel8r1nyBmd0Iffc5fWYjwhrOPnGXN
X-Proofpoint-ORIG-GUID: gUnel8r1nyBmd0Iffc5fWYjwhrOPnGXN
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


On 2/10/22 6:29 AM, Jeff Layton wrote:
> On Thu, 2022-02-10 at 09:21 -0500, J. Bruce Fields wrote:
>> Jeff, this table of locking rules seems out of date since 6109c85037e5
>> "locks: add a dedicated spinlock to protect i_flctx lists".  Are any of
>> those callbacks still called with the i_lock?  Should that column be
>> labeled "flc_lock" instead?  Or is that even still useful information?
>>
>> --b.
>
> Yeah, that should probably be the flc_lock. I don't think we protect
> anything in the file locking code with the i_lock anymore.

Will replace inode->i_lock with flc_lock in v13.

-Dai

>
>> On Wed, Feb 09, 2022 at 08:52:07PM -0800, Dai Ngo wrote:
>>> diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst
>>> index d36fe79167b3..57ce0fbc8ab1 100644
>>> --- a/Documentation/filesystems/locking.rst
>>> +++ b/Documentation/filesystems/locking.rst
>>> @@ -439,6 +439,7 @@ prototypes::
>>>   	void (*lm_break)(struct file_lock *); /* break_lease callback */
>>>   	int (*lm_change)(struct file_lock **, int);
>>>   	bool (*lm_breaker_owns_lease)(struct file_lock *);
>>> +	bool (*lm_lock_conflict)(struct file_lock *);
>>>   
>>>   locking rules:
>>>   
>>> @@ -450,6 +451,7 @@ lm_grant:		no		no			no
>>>   lm_break:		yes		no			no
>>>   lm_change		yes		no			no
>>>   lm_breaker_owns_lease:	no		no			no
>>> +lm_lock_conflict:       no		no			no
>>>   ======================	=============	=================	=========