Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp817341pxb; Thu, 17 Feb 2022 15:41:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJx7Hw7yk25Wybe2QZlW9Awxdn0cm42OmsfhJXpNKRdzwiwZkh65Zo/SaQTgbjuLtsG9K8gs X-Received: by 2002:a05:6a00:1a42:b0:4c9:f270:1f39 with SMTP id h2-20020a056a001a4200b004c9f2701f39mr5186730pfv.50.1645141273122; Thu, 17 Feb 2022 15:41:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645141273; cv=none; d=google.com; s=arc-20160816; b=Ayal+tjBt1BvYqrfdAPodqmMMtgLke6oJDLoWlJ5oTA1iV/ovyMzHc64ezsva29MUr f0WV8bXQ+QfFVEhEdAVD8QfKNfmc5OOnJ8SohHycWLSejemlbKShKh34/AXcyIiFu+hL AW8itCNSf4ROez3C1o5yEopwR/RQo/C5IRmBSGi5MZornDEmUPfF9d4oUclmavdMymlc JQI5qla4+fnZO1C0DRYz9ihBZawynV7lcKI8ketA1dV7Kmc2LNnuqsdoNkG43uwakMmX RuxHnUQ7F9H8i32NHFa/ODGg8v41qYQXNtqHNlc8DZsaKibFe1QBxxJZZgdXGEgYEmio pgLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:references:in-reply-to:subject :cc:to:from:mime-version:content-transfer-encoding:dkim-signature :dkim-signature; bh=D6xH+GLNf2HcdpkX5IOFaVo/1N9mwwBlgA9AlaXPurg=; b=BSuhENSeHPfqWMCKjA893ixMD/a7O+vB0XvePdQh5NFdQo1MZ+2na/5TL9oebRhEkO fyMm5c1r6O+kGMt8vf5aepLrBtxxc5RX39ZPE7jH39rwsq6sdYF1J8qDPh1sGHU8VrsX RoqPFYqL9pPtpMKlf5hFfGsx7S88/glLQH0d9pjmNXIzpPAkHQwIzt0uRwjPeyUHqie7 R1O9GYCG67G1q1IWEa9lqag7UxKcUiv6PCkOMppjFToKFN47+TJOfJ2GRNP2538opC2s arTZ2NaTNT2SCCwi02CRZ7hrH8vTttyXAChdT1x+DCeCd6IF6I/+YiEpvvZJLmEP4Frb VkFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="xO5v918/"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id u12si24982564plf.186.2022.02.17.15.41.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Feb 2022 15:41:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="xO5v918/"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D187C4132E; Thu, 17 Feb 2022 15:18:43 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241522AbiBQWhA (ORCPT + 99 others); Thu, 17 Feb 2022 17:37:00 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:53476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232023AbiBQWg6 (ORCPT ); Thu, 17 Feb 2022 17:36:58 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA29116921D for ; Thu, 17 Feb 2022 14:36:43 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 098A7210DC; Thu, 17 Feb 2022 22:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1645137402; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D6xH+GLNf2HcdpkX5IOFaVo/1N9mwwBlgA9AlaXPurg=; b=xO5v918/kvUGhN31oDstJ/BnDiF2GBHne9gxEutY/f+fIwb+xn4KtcpcUoO3iF0z36MRdl RlNHc8sNulYFRoQklL38tD3F8WmIOpYm2nDP3eeRg3/AB0qzNnEVwAYIGD2RTAf5UXDYYk S5vN2+t2GXffc+ZItlVKOnJBPstNd8g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1645137402; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D6xH+GLNf2HcdpkX5IOFaVo/1N9mwwBlgA9AlaXPurg=; b=LYS4bf0BjTdPjWlbVGIaFs0K0IIt9kYM+XASrDJg2ezxKcf2xY5+BUyNSXyLE+DZMOfKXe Byb5guMPrWMDJUBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 31B7B13BE1; Thu, 17 Feb 2022 22:36:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +ROvN/jNDmJkEgAAMHmgww (envelope-from ); Thu, 17 Feb 2022 22:36:40 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 From: "NeilBrown" To: "Chuck Lever" Cc: linux-nfs@vger.kernel.org Subject: Re: [PATCH v2 0/8] Clean up struct svc_serv_ops In-reply-to: <164511349417.1361.12607852846407534019.stgit@klimt.1015granger.net> References: <164511349417.1361.12607852846407534019.stgit@klimt.1015granger.net> Date: Fri, 18 Feb 2022 09:36:37 +1100 Message-id: <164513739771.10228.8490335253199789553@noble.neil.brown.name> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Fri, 18 Feb 2022, Chuck Lever wrote: > Here is the completed series of patches to remove struct > svc_serv_ops, as suggested by Neil Brown. The original material was > introduced several years ago when we planned to convert the RPC > server to use work queues. That work was never completed. > > Removal now is to eliminate some unnecessary virtual functions > and to pave the way for the possibility of dynamic nfsd thread > management. > > The full set of patches has been provisionally applied to my > for-next branch to enable broad testing. Comments welcome. All looks good - lots of nice cleanups there. Thanks, NeilBrown