Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20220208215232.491780-1-anna@kernel.org>
 <20220208215232.491780-5-anna@kernel.org>
User-agent: mu4e 1.7.0; emacs 27.2
From:   Su Yue <l@damenly.su>
To:     Anna Schumaker <anna@kernel.org>
Cc:     fstests@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 4/4] generic/633: Check if idmapped mounts are supported
 before running
Date:   Sat, 19 Feb 2022 16:40:09 +0800
In-reply-to: <20220208215232.491780-5-anna@kernel.org>
Message-ID: <wnhr451v.fsf@damenly.su>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
Precedence: bulk


On Tue 08 Feb 2022 at 16:52, Anna Schumaker <anna@kernel.org> 
wrote:

> From: Anna Schumaker <Anna.Schumaker@Netapp.com>
>
> This appears to have been missed when the test was added.
>
It's removed on purpose to also verify idmapped mounts unrelated 
tests.

Generic/633 fails on NFS because of setgid inheritance behavior of 
NFS.
Already reported it to the community[1].

[1]: 
https://lore.kernel.org/linux-nfs/OS3PR01MB770539462BE3E7959DAF8B5789389@OS3PR01MB7705.jpnprd01.prod.outlook.com/T/#u

--
Su
> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
> ---
>  tests/generic/633 | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/633 b/tests/generic/633
> index 382806471223..6750117735f7 100755
> --- a/tests/generic/633
> +++ b/tests/generic/633
> @@ -15,6 +15,7 @@ _begin_fstest auto quick atime attr cap 
> idmapped io_uring mount perms rw unlink
>  # real QA test starts here
>
>  _supported_fs generic
> +_require_idmapped_mounts
>  _require_test
>
>  echo "Silence is golden"