X-Received: by 2002:a17:906:7e52:b0:6b8:e7db:f725 with SMTP id z18-20020a1709067e5200b006b8e7dbf725mr1325916ejr.225.1645655836946; Wed, 23 Feb 2022 14:37:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645655836; cv=none; d=google.com; s=arc-20160816; b=T00HxcI92SofhxbGl9kC/lePr40bx9SE2PLu39pp0FM0jR97P/sChmK+t+RP9BCBZR Wv9iPKWQjar5m10O9v/iaNSImafq9xE3jc9QRMEymlrs6m8lMcM6oxK7iHMIMJjc0131 BtFZ23QGNqplQjAiNov9AZSz6JdIQCZv06KkqfD3C0eIOoQ9gxHME4tIpC70fGuh55af BfrPfL3Ulj6lC7Qz8PKYKZdOSWZj7NEuSkCqc1U8oMX0Pm18xggm3WLyFOAdaEMovL1+ gGaNbfRHZrV/SX2w5dhcTdmSsaZMKFUYy97q5p0ZuQ3Cehnl4U8iXuPLyxCct1CuTF+J PghQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:subject :from:references:cc:to:content-language:user-agent:mime-version:date :message-id; bh=zDd2ySjd2nWVRmuoxGDXA9ox9rR1Z4EUXU6fVAxpPec=; b=r3uQy87m6GENrRpvsoj6PpYHyuoSF9hattZVFaALjGBWQ5LYEnHyfvWW9yZ2jGL8S2 qBZzXQNqRZJn+6ArOuocCCiO5rK0Pm8js/Ab2sBcWMsuhg9LFvd5HHgAwlsExp+zbUba UvznbLYc/BfVuZdPjIWwDqWPuzbrqpVco53cqfb/a3cjrZWYGAHJ3LwrH+UcqIJEfhcF neqqfjIqx5+dUIsQ0cT99ZgdsgvwKzGlweOsw8ELwcdgmakOA+w/KPO0nkdm0JZ1EH4p vdG8O0JzD8a7wkMxi9oWZaEL93zDZDW76l+VsbwgPOHIRpkyZH0wnd1wdzwuOI7iA6Xi qqWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gb41si521203ejc.395.2022.02.23.14.36.51; Wed, 23 Feb 2022 14:37:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243691AbiBWWZV (ORCPT + 99 others); Wed, 23 Feb 2022 17:25:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231311AbiBWWZT (ORCPT ); Wed, 23 Feb 2022 17:25:19 -0500 Received: from cc-smtpout2.netcologne.de (cc-smtpout2.netcologne.de [89.1.8.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C42443DA67 for ; Wed, 23 Feb 2022 14:24:50 -0800 (PST) Received: from cc-smtpin3.netcologne.de (cc-smtpin3.netcologne.de [89.1.8.203]) by cc-smtpout2.netcologne.de (Postfix) with ESMTP id 6EC2512661; Wed, 23 Feb 2022 23:24:48 +0100 (CET) Received: from nas2.garloff.de (xdsl-89-0-168-136.nc.de [89.0.168.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by cc-smtpin3.netcologne.de (Postfix) with ESMTPSA id 8331311DC2; Wed, 23 Feb 2022 23:24:42 +0100 (CET) Received: from [192.168.155.202] (unknown [192.168.155.10]) by nas2.garloff.de (Postfix) with ESMTPSA id 083AAB3B131A; Wed, 23 Feb 2022 23:24:33 +0100 (CET) Message-ID: <691bc46a-637c-5bc7-add9-d6da2f429750@garloff.de> Date: Wed, 23 Feb 2022 23:24:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: Olga Kornievskaia Cc: "Kornievskaia, Olga" , "linux-nfs@vger.kernel.org" , "Schumaker, Anna" , Trond Myklebust , Greg Kroah-Hartman References: <50bd4b4d-3730-4048-fcce-6c79dfe70acf@garloff.de> <8957291b-ecd1-931e-5d0c-7ef20c401e5d@garloff.de> <10d55787-7b97-8636-9426-73fdeda0a122@garloff.de> <6401c5e1-8f05-5644-9bea-207640a21b77@garloff.de> From: Kurt Garloff Subject: Re: 6f283634 / 1976b2b3 breaks NFS (QNAP/Linux kNFSD) In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-NetCologne-Spam: L X-Rspamd-Queue-Id: 8331311DC2 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hi Olga, On 23/02/2022 18:56, Olga Kornievskaia wrote: > On Wed, Feb 23, 2022 at 8:20 AM Kurt Garloff wrote: >> Hi Olga, >> >> any updates? Were you able to investigate the traces? >> >> Breaking NFS mounts from Qnap (knfsd with 3.4.6 kernel here, >> though Qnap might have patched it),is not something that >> should happen with a -stable kernel update, even if the problem >> would be on the Qnap side, which would not be completely >> surprising. >> >> So I think we should revert this patch at least for -stable, >> unless we understand what's going on and have a better fix >> than a plain revert. > I haven't commented on your ask of requesting a revert in the stable > version. I'm not sure what the philosophy there. I don't see why we > can't ask for this feature to only be available from the kernel > version it has been accepted into and not before. If you think the > kernel version that you want to use will always be before this feature > was accepted, then asking folks responsible for "stable" kernels seems > like a good idea. At the time of inclusion to stable, I wasn't aware > of the broken legacy server implementations out there. I guess Greg would need to comment on the detailed policies for stable kernels. One of the goals for sure is to avoid regressions. If that causes bugs not to be fixable or features not to be available, than that's a price that might need to be accepted. A regression is just many many times worse than an unfixed issue, twice so for something that claims to be stable. So, if we are relatively sure that no NFSv4.2 server has the kernel-3.4.6-knfsd Qnap (NFSv4.1) misbehavior, my change that masks the new features for NFS Cologne, Germany