Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <1431b3c8-e003-c223-37a9-c2d3791705d1@redhat.com>
Date:   Wed, 23 Feb 2022 11:48:42 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] idmapd: Fix error status when nfs-idmapd exits
Content-Language: en-US
To:     Wenchao Hao <haowenchao@huawei.com>, linux-nfs@vger.kernel.org
Cc:     Zhiqiang Liu <liuzhiqiang26@huawei.com>, linfeilong@huawei.com,
        yanglongkang@h-partners.com
References: <20220218012732.1549586-1-haowenchao@huawei.com>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <20220218012732.1549586-1-haowenchao@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2/17/22 8:27 PM, Wenchao Hao wrote:
> nfs-idmapd.service would report following error when stopped:
> 
> Feb 17 07:32:05 fedora systemd[1]: Starting NFSv4 ID-name mapping service...
> Feb 17 07:32:05 fedora rpc.idmapd[1198]: Setting log level to 0
> Feb 17 07:32:05 fedora systemd[1]: Started NFSv4 ID-name mapping service.
> Feb 17 07:32:11 fedora rpc.idmapd[1198]: exiting on signal 15
> Feb 17 07:32:11 fedora systemd[1]: Stopping NFSv4 ID-name mapping service...
> Feb 17 07:32:11 fedora systemd[1]: nfs-idmapd.service: Main process exited, code=exited, status=1/FAILURE
> Feb 17 07:32:11 fedora systemd[1]: nfs-idmapd.service: Failed with result 'exit-code'.
> Feb 17 07:32:11 fedora systemd[1]: Stopped NFSv4 ID-name mapping service.
> 
> commit 93e8f092(idmapd: Add graceful exit and resource cleanup)
> redirected SIGTERM, so when executing "systemctl stop nfs-idmapd", the
> main() of idmapd would running to tail to return, while it returned 1
> which considered as error by systemd.
> 
> So here just return 0 in main().
> 
> Signed-off-by: Wenchao Hao <haowenchao@huawei.com>
Committed (tag: nfs-utils-2-6-2-rc2)

steved.
> ---
>   utils/idmapd/idmapd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/idmapd/idmapd.c b/utils/idmapd/idmapd.c
> index e2c160e8..e79c124d 100644
> --- a/utils/idmapd/idmapd.c
> +++ b/utils/idmapd/idmapd.c
> @@ -474,7 +474,7 @@ main(int argc, char **argv)
>   		event_free(svrdirev);
>   	event_base_free(evbase);
>   
> -	return 1;
> +	return 0;
>   }
>   
>   static void