Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dc3daf5f-cd51-f03a-3042-e6659c3d3c90@redhat.com>
Date:   Mon, 28 Feb 2022 15:25:16 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] systemd: Fix format-overflow warning
Content-Language: en-US
From:   Steve Dickson <steved@redhat.com>
To:     Linux NFS Mailing list <linux-nfs@vger.kernel.org>
References: <20220223202120.126170-1-steved@redhat.com>
In-Reply-To: <20220223202120.126170-1-steved@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2/23/22 3:21 PM, Steve Dickson wrote:
> rpc-pipefs-generator.c:35:23: error: '%s' directive output between 0 and 2147483653 bytes may exceed minimum required size of 4095 [-Werror=format-overflow=]
>     35 |         sprintf(path, "%s/%s", dirname, pipefs_unit);
>        |                       ^
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed... (tag: nfs-utils-2-6-2-rc3)

steved.
> ---
>   systemd/rpc-pipefs-generator.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/systemd/rpc-pipefs-generator.c b/systemd/rpc-pipefs-generator.c
> index c24db56..7b2bb4f 100644
> --- a/systemd/rpc-pipefs-generator.c
> +++ b/systemd/rpc-pipefs-generator.c
> @@ -28,11 +28,12 @@ static int generate_mount_unit(const char *pipefs_path, const char *pipefs_unit,
>   {
>   	char	*path;
>   	FILE	*f;
> +	size_t size = (strlen(dirname) + 1 + strlen(pipefs_unit));
>   
> -	path = malloc(strlen(dirname) + 1 + strlen(pipefs_unit));
> +	path = malloc(size);
>   	if (!path)
>   		return 1;
> -	sprintf(path, "%s/%s", dirname, pipefs_unit);
> +	snprintf(path, size, "%s/%s", dirname, pipefs_unit);
>   	f = fopen(path, "w");
>   	if (!f)
>   	{