Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Trond Myklebust <trondmy@hammerspace.com>
To:     "anna@kernel.org" <anna@kernel.org>,
        "chenxiaosong2@huawei.com" <chenxiaosong2@huawei.com>,
        "smayhew@redhat.com" <smayhew@redhat.com>
CC:     "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        "liuyongqiang13@huawei.com" <liuyongqiang13@huawei.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "yi.zhang@huawei.com" <yi.zhang@huawei.com>,
        "zhangxiaoxu5@huawei.com" <zhangxiaoxu5@huawei.com>
Subject: Re: [PATCH -next 2/2] nfs: nfs_file_write() check writeback errors
 correctly
Thread-Topic: [PATCH -next 2/2] nfs: nfs_file_write() check writeback errors
 correctly
Thread-Index: AQHYMIz1p4vLG8/+bkijBHRG64iku6yxB1oA
Date:   Sat, 5 Mar 2022 17:12:46 +0000
Message-ID: <461aafe64a56836b8d248556052f8d00b6d37731.camel@hammerspace.com>
References: <20220305124636.2002383-1-chenxiaosong2@huawei.com>
         <20220305124636.2002383-3-chenxiaosong2@huawei.com>
In-Reply-To: <20220305124636.2002383-3-chenxiaosong2@huawei.com>
Accept-Language: en-US, en-GB
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?N3ZnYi9sOGR5aENYeWpMVVBTWG9zNnFuN2VBSGN5dUNlbXVxcGV1TE02QmZB?=
 =?utf-8?B?V01qRityTUkzek5oOGh6SnNWbEFxVjl2N241NUw5b21Na1NRc0pPTjR5UXNh?=
 =?utf-8?B?VEh1SjRXcEY2RlhBTW1uUCs5OG5IWThVR01POTJoRjhIdmZjQXFLYlh3ZmMv?=
 =?utf-8?B?TkpIM0ovYzZoZFFBVWxRWGl3Yys1YVYxaDNMN1V1My9zcXNWQzlpVVY0Q1pl?=
 =?utf-8?B?akpKam1VcThnWW9WczJyRUdHZFZSQUQxWWhnL2tUZU5qOEZCdmwyN3ptMkhn?=
 =?utf-8?B?NHRwOTRpRFgvcDNTVFk5Sk50cFJYenBIMmFLS2lNY1o5ZGNUZ04xaEM5OWR4?=
 =?utf-8?B?dm9nMWM5dUk5dTlDNHRZaGhMbTlrQ1hrK0xUNVhmam1YNUh3NE1FaW0ydnVw?=
 =?utf-8?B?ckd1bzZtUDBFcGNYSStRYmgxVnJCcHNiRW0yWXZXZ28vVi8vaHFjaml6bU9y?=
 =?utf-8?B?Q01zNC9hcUQ3YlU3SVBDQWVjQXJ5VCtlRnpNVFN0dGpnVFNuYjFyQ1ZqVDA1?=
 =?utf-8?B?WXNhQjMwMHBaOFYwcXN5V0xsY0g5eFRCVDNNOWR3U0xGVWwyL1ZFek9KRUpX?=
 =?utf-8?B?cVI3UURPaE01TDJGV25JYXV0YXp1eVBYbUpFNExvajMvRWwvaldtelBpcVhz?=
 =?utf-8?B?Z3JYL2oxemg0Z2x3UVpHL3I2ZWt1SE92a3gxclJzRHJVV3N4ZTQrSDFyeUJl?=
 =?utf-8?B?ajlxNStXY0hIT2o0Q2N3ZVVOcGtSczFwRmJJa3RqSTFIdmFNRDlqcisvbmRa?=
 =?utf-8?B?R0g5U09NdnNETVRBcTNLemZEd2NEQnVDWHdOSllJZkdPbmJCUUZDOUNyaXNr?=
 =?utf-8?B?QTAySWVZSklYNmE2NFZBaitSQlQyRFhRaEpJR2pud1l4TkVRUmFmS0V1dDNl?=
 =?utf-8?B?NGxBWUkrOGIyYlJpMllOOFNZZjlqR0pFZ1pvZHdaK0JQWGtPN2h5eFdYaFJN?=
 =?utf-8?B?Q0NuM2RzZXNSalRrTmF6ajllaTM3RzFEQ2JRT3BwRUFPaVh3Vm1ldGVpQytW?=
 =?utf-8?B?YzlOakpmVTlYWXBYVGVobGdaVXNpQ0RTRHBnQ3hhUTVmNlhnemttRjFYeDFn?=
 =?utf-8?B?S1lXWGRFSHNqUjBqRm9CL21TQjZNaU1pckF5M2lqRzRUb2dCTG85bTQzZ00w?=
 =?utf-8?B?N3k3ZXEyUDU5WmhoVWgvcmNVUFBzYTYyYndyeFk1bEZjeGNRbzlYWEt3RnQx?=
 =?utf-8?B?TElTNjFRNlRISG0rRXAzY3VSQ3NEOS9qNVExNDlkS1hQOGpCZ1B3NlRqVUVR?=
 =?utf-8?B?RU9Dc0dhQjU5d2p0ZkVZZmtOQ0FTczk0aHE1MTZWYy9YdFpnVmhPSUFtNWt4?=
 =?utf-8?B?M2dKN054THAzdzhLQVpVMzlzV1RBdXJFZVpCQ3R5WjZVQWdKajhMb2kyTTdT?=
 =?utf-8?B?YTgva2xoUjlPOFJidEVGM0h6c3RVelJyakFyN1NKdFhSZFZ1SW40a1BoRGhr?=
 =?utf-8?B?aXlyQUhYMS9SYytxMWZhdXJqUWRoUG9qV0p1NHdXaWdDTDlKSnFHNVJra3RH?=
 =?utf-8?B?bWxZNW9rUzlIbnBCc1JJK01zb292TGkybVlkblVvTCtPVzZESTA5TmUrSkNq?=
 =?utf-8?B?ZFJ6VjlPemVZWFFRcVVyN0FjUzBXOUZkLzhTT1g4a0V5OEZrWThDU21LSEl0?=
 =?utf-8?B?VWY1akx3MEZqOEJtK2huOE5GbVg3bEtRdTRxUjNiTVVPKzdXY0cvOHl1WElm?=
 =?utf-8?B?dEljdkJrbmRhdHlNNENMaGd4cXdKcFZMYzF0clhNcjFWSk5kVGE4MFc1b0VT?=
 =?utf-8?B?RmxJc3RtWGRiQXhtd0d6dy9tbjd5N21oS3ZVa2xFUDBUWjgwOFRYOE00YVRw?=
 =?utf-8?B?dDhxbHg3ODJndjA2ckVkUXY3UGpja1FlT3pPVnJ4RTFCM0ZHbmZ1MktobEtO?=
 =?utf-8?B?ZS90MkRZbjgxVzBZeG5oMWt1ZGpHSzNDeFpmOEhlUFRKdkFicFU3Z205cjky?=
 =?utf-8?B?cXBvOGNyQjJ3L3lTcVdpRmdjc1dnbml3ZVBRbXVpYnVBdFhrTE9nN0owZmhH?=
 =?utf-8?B?dFc1TkVJUnBRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <09E61835B5527643A84A27BC6AD722DE@namprd13.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: hammerspace.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR13MB5084.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f6f8ba3-f33a-456b-c6a5-08d9fecb5e55
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2022 17:12:46.3193
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0d4fed5c-3a70-46fe-9430-ece41741f59e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5NGXzprpgu5VVcfME8ORaaDSLPQZ5y4jDrEobEcRuqGOiqL1Vc305ESCEjpShUg2HhtSLMz85+oqgWpXNn1mWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3061
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

T24gU2F0LCAyMDIyLTAzLTA1IGF0IDIwOjQ2ICswODAwLCBDaGVuWGlhb1Nvbmcgd3JvdGU6DQo+
IElmIG5vYm9keSBoYXMgc2VlbiB0aGUgd3JpdGViYWNrIGVycm9yIHlldCwgdGhlbg0KPiBmaWxl
bWFwX3NhbXBsZV93Yl9lcnIoKQ0KPiBhbHdheXMgcmV0dXJuIDAuIEV2ZW4gaWYgdGhlcmUgaXMg
bm8gbmV3IHdyaXRlYmFjayBlcnJvciBiZXR3ZWVuDQo+IGZpbGVtYXBfc2FtcGxlX3diX2Vycigp
IGFuZCBmaWxlbWFwX2NoZWNrX3diX2VycigpLA0KPiBmaWxlbWFwX2NoZWNrX3diX2VycigpIHdp
bGwgcmV0dXJuIHRoZSBvbGQgZXJyb3IuDQo+IA0KPiBGaXggdGhpcyBieSB1c2luZyBmaWxlLT5m
X21hcHBpbmctPndiX2VyciBhcyB0aGUgb2xkIGVycm9yLg0KPiANCj4gRml4ZXM6IGNlMzY4NTM2
ZGQ2MSAoIm5mczogbmZzX2ZpbGVfd3JpdGUoKSBzaG91bGQgY2hlY2sgZm9yDQo+IHdyaXRlYmFj
ayBlcnJvcnMiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBDaGVuWGlhb1NvbmcgPGNoZW54aWFvc29uZzJA
aHVhd2VpLmNvbT4NCj4gLS0tDQo+IMKgZnMvbmZzL2ZpbGUuYyB8IDQgKystLQ0KPiDCoDEgZmls
ZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0t
Z2l0IGEvZnMvbmZzL2ZpbGUuYyBiL2ZzL25mcy9maWxlLmMNCj4gaW5kZXggODNkNjNiY2U5NTk2
Li44NzYzZjg5YzE3NmEgMTAwNjQ0DQo+IC0tLSBhL2ZzL25mcy9maWxlLmMNCj4gKysrIGIvZnMv
bmZzL2ZpbGUuYw0KPiBAQCAtNjM1LDcgKzYzNSw3IEBAIHNzaXplX3QgbmZzX2ZpbGVfd3JpdGUo
c3RydWN0IGtpb2NiICppb2NiLCBzdHJ1Y3QNCj4gaW92X2l0ZXIgKmZyb20pDQo+IMKgDQo+IMKg
wqDCoMKgwqDCoMKgwqBuZnNfY2xlYXJfaW52YWxpZF9tYXBwaW5nKGZpbGUtPmZfbWFwcGluZyk7
DQo+IMKgDQo+IC3CoMKgwqDCoMKgwqDCoHNpbmNlID0gZmlsZW1hcF9zYW1wbGVfd2JfZXJyKGZp
bGUtPmZfbWFwcGluZyk7DQo+ICvCoMKgwqDCoMKgwqDCoHNpbmNlID0gZmlsZS0+Zl9tYXBwaW5n
LT53Yl9lcnI7DQo+IMKgwqDCoMKgwqDCoMKgwqBuZnNfc3RhcnRfaW9fd3JpdGUoaW5vZGUpOw0K
PiDCoMKgwqDCoMKgwqDCoMKgcmVzdWx0ID0gZ2VuZXJpY193cml0ZV9jaGVja3MoaW9jYiwgZnJv
bSk7DQo+IMKgwqDCoMKgwqDCoMKgwqBpZiAocmVzdWx0ID4gMCkgew0KPiBAQCAtNjY5LDcgKzY2
OSw3IEBAIHNzaXplX3QgbmZzX2ZpbGVfd3JpdGUoc3RydWN0IGtpb2NiICppb2NiLCBzdHJ1Y3QN
Cj4gaW92X2l0ZXIgKmZyb20pDQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZ290
byBvdXQ7DQo+IMKgDQo+IMKgwqDCoMKgwqDCoMKgwqAvKiBSZXR1cm4gZXJyb3IgdmFsdWVzICov
DQo+IC3CoMKgwqDCoMKgwqDCoGVycm9yID0gZmlsZW1hcF9jaGVja193Yl9lcnIoZmlsZS0+Zl9t
YXBwaW5nLCBzaW5jZSk7DQo+ICvCoMKgwqDCoMKgwqDCoGVycm9yID0gZXJyc2VxX2NoZWNrKCZm
aWxlLT5mX21hcHBpbmctPndiX2Vyciwgc2luY2UpOw0KPiDCoMKgwqDCoMKgwqDCoMKgaWYgKG5m
c19uZWVkX2NoZWNrX3dyaXRlKGZpbGUsIGlub2RlLCBlcnJvcikpIHsNCj4gwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqBpbnQgZXJyID0gbmZzX3diX2FsbChpbm9kZSk7DQo+IMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgaWYgKGVyciA8IDApDQoNCkhtbS4uLiBXaHkgaXNu
J3QgdGhpcyBjb25zaWRlcmVkIGEgYnVnIHdpdGggZmlsZW1hcF9zYW1wbGVfd2JfZXJyKCk/IElm
DQp3aGF0IHlvdSBzYXkgaXMgdHJ1ZSwgdGhlbiBkb19kZW50cnlfb3BlbigpIGNvdWxkIGJlIHBp
Y2tpbmcgdXANCmV4aXN0aW5nIGVycm9ycyBmcm9tIHRoZSBmaWxlc3lzdGVtIGFuZCBmcm9tIHRo
ZSBpbm9kZSBhbmQgcHJvcGFnYXRpbmcNCnRoZW0gdG8gcmFuZG9tIHByb2Nlc3Nlcy4NCg0KSXQg
YmFzaWNhbGx5IG1lYW5zIGV2ZXJ5b25lIHdobyBjYXJlcyBhYm91dCBjb3JyZWN0bmVzcyBvZiB0
aGUgZXJyb3INCnJldHVybiB2YWx1ZXMgbmVlZHMgdG8gZG8gYSBmc3luYygpIGltbWVkaWF0ZWx5
IGFmdGVyIG9wZW4oKSBpbiBvcmRlcg0KdG8gc3luYyB1cCB0aGUgdmFsdWUgaW4gZmlsZS0+Zl93
Yl9lcnIuDQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWlu
ZXIsIEhhbW1lcnNwYWNlDQp0cm9uZC5teWtsZWJ1c3RAaGFtbWVyc3BhY2UuY29tDQoNCg0K