Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp551792pxp; Wed, 9 Mar 2022 08:03:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJyS8Ry1yZGev1uvdzRM4XAtxA45Dp8W+boIKoA9QTrFmkDGKIBurzpqpQeEpOadnWMix6ZU X-Received: by 2002:a63:2004:0:b0:375:ed63:ab4c with SMTP id g4-20020a632004000000b00375ed63ab4cmr325336pgg.255.1646841827977; Wed, 09 Mar 2022 08:03:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646841827; cv=none; d=google.com; s=arc-20160816; b=juFTA6CDx2aP7YVx8Z+xt+k2D/oMsjC016YJ/9oqEciOewRHjRPjMBUK51o207uYJt cB5qIbM4ax5V+QHmusk/SDRbx6UxnVrQV78thE3e4I7qmGrUOlchoX3WEjM9Nd5e87Ph RJMWWAnjFtSAm6OGIcOzVst3FywMH3qcTGtCr5SVl/9+zVfIniRiNj2vJaPJOpn//pNf /iIr5O+2vwUa5m0P5AdRLBna00Exrrpg2gtsAqynKe81DFgpgwaCOyUAHNeeAy6RNQ24 Q7YZAiLK2Lmwhvwol93fIK/t4yiTv22aRfVErGzXINAeEsnwEHdPsB7CTAdvCSjBDiR2 Rumw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=QxS/WDQr3tUQMEh78l2OAofG/jJPLXvvMADs/iNJnek=; b=adT+2p9xldXskjRCWVcMb5wC4bJz40JcSVrDQYsUNufrjsJf6Ne3p8X25JYps4MF1u WyidCjgBY+l+gAET/ebqlFo4/55aDk2Y50XUpuutIWxN/2JmERTqb0aZKi98Clr3Xx0d nHHlKZ5gCi6rpJkEXF4gN6w9HdiJeSf5aRucaXOw41lVeaf6c9g15NYL/QUkYkAc5x7K CcKA7oUjgr7LzQsPvgUBTbhPt2MWzVeQXD2gPiyCe7YEWFD0/thCKLXT+vWlSrPTnlmc gK9URH2Nn63EKxy/HTOomsxmsvpSj27JtA2KwSfa3XYximQcckUUnoHIrTU1XG52LfoY LcVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=a+r3TTlY; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t7-20020a17090ad50700b001bf101ee560si2202251pju.173.2022.03.09.08.03.17; Wed, 09 Mar 2022 08:03:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=a+r3TTlY; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234051AbiCIPus (ORCPT + 99 others); Wed, 9 Mar 2022 10:50:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229962AbiCIPup (ORCPT ); Wed, 9 Mar 2022 10:50:45 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9F42313197A for ; Wed, 9 Mar 2022 07:49:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646840985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QxS/WDQr3tUQMEh78l2OAofG/jJPLXvvMADs/iNJnek=; b=a+r3TTlY2shctpd+A2HHUW3izU0ub/HyxXXVEDDvcQ91jYT4GyF5XvjPMiIOovT10RGq1i HumgB8SQtyMZ7Us0O6OBb4b9u1T+mZ3dgPjwz8eLbksMntL4gtajqVfDdLQQE7MHT/fTR0 3eUipjVu+qNJeug8o2Jgftp56HGhTdA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-563-fKjxpOpmPaS5naFCbwTcEA-1; Wed, 09 Mar 2022 10:49:42 -0500 X-MC-Unique: fKjxpOpmPaS5naFCbwTcEA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C6004FC80; Wed, 9 Mar 2022 15:49:39 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id C291D804CD; Wed, 9 Mar 2022 15:49:18 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <164678185692.1200972.597611902374126174.stgit@warthog.procyon.org.uk> <164678192454.1200972.4428834328108580460.stgit@warthog.procyon.org.uk> To: Jeff Layton Cc: dhowells@redhat.com, linux-cachefs@redhat.com, Anna Schumaker , Steve French , Dominique Martinet , David Wysochanski , Ilya Dryomov , Jeffle Xu , Linus Torvalds , linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 02/19] netfs: Generate enums from trace symbol mapping lists MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1712591.1646840957.1@warthog.procyon.org.uk> Date: Wed, 09 Mar 2022 15:49:17 +0000 Message-ID: <1712592.1646840957@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Jeff Layton wrote: > Should you undef EM and E_ here after creating these? Maybe. So far it hasn't mattered... David