Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1080144pxp; Wed, 9 Mar 2022 20:41:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJzNXm4ISJGbvBBk7+f95pcWlONgEbWYr9lp/MiQtRkmylsOz0l/AqztPuAPkZDij7AhpuE7 X-Received: by 2002:a50:da89:0:b0:413:adb1:cf83 with SMTP id q9-20020a50da89000000b00413adb1cf83mr2528022edj.158.1646887278338; Wed, 09 Mar 2022 20:41:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646887278; cv=none; d=google.com; s=arc-20160816; b=RDMxQ1hbT17odH9tusg4afr30gNdQ3tSoE9dHN16/VQ9XbD9L/5jmxHpV1j6CO75uk dka0gFh6sI+yvW6RdiK3BLNca/IDvQPNrCtnutynVTT663+jRfocgpgxP3Zhg1EUA7f4 0Rqdd4ebNGX14ky206vpXsvGAuZniaZYXHXF9B46j9VjFN2Pp/sVOjEbENE+ylli7MWN 0epIFj94SzkyNT+JKKFUZX+KzVqveg9armOjop/4epBGSUsqyuV/pjuH+rDw898OAQtP Rbu7Nf6a59UpiQi5yPy9Jw6Z3csMmO3DfKszzg8ijajd9LJOJdABY8m0Vxm5vX0hjpcI ylCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=adZIRKIeUQC70rP6i8RINGH95H//gobpEVLKpxC7e2E=; b=d9zzxJx2XsZfyR1Nbrf07GBAgn0Q4qD5wA7GDoSukapDjBbyhlO47rjkQoALuXjzs4 bIv8MbtkC1SaUncMApHr95IfFC7ACYasRFYjRcoqcVdtl+FfiLKtRQ0lNvpKwqCYkEYl fG7x3refPDhzTnBTEnSPnyX5lhc0BV1T0rOc1QvmaNLoq4nuFzP2zvrJfB030lYXAhdz 6uaRyfRab0sSnxTfNAfmiKfrmORMUDD7QBcu0v70de3DI7K/U5ErWIlqUWtkJcgjgNaV 6WA0QVqtDdM/YuiMHMa6nj0GiGNN+KqY2GmmcALyaEQJ0CtCi47lEKJzUv8HrfU7kdLG njsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v18-20020a1709062f1200b006d0a26d4e61si2026303eji.771.2022.03.09.20.40.53; Wed, 09 Mar 2022 20:41:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233998AbiCJBl3 (ORCPT + 99 others); Wed, 9 Mar 2022 20:41:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232929AbiCJBl2 (ORCPT ); Wed, 9 Mar 2022 20:41:28 -0500 Received: from out30-57.freemail.mail.aliyun.com (out30-57.freemail.mail.aliyun.com [115.124.30.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBEF79BAE6; Wed, 9 Mar 2022 17:40:27 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R261e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0V6m1KrN_1646876422; Received: from 30.225.24.63(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0V6m1KrN_1646876422) by smtp.aliyun-inc.com(127.0.0.1); Thu, 10 Mar 2022 09:40:23 +0800 Message-ID: <3e942459-bb15-6322-10ae-dbadb09dd72c@linux.alibaba.com> Date: Thu, 10 Mar 2022 09:40:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2 01/19] fscache: export fscache_end_operation() Content-Language: en-US To: Jeff Layton , David Howells , linux-cachefs@redhat.com Cc: Anna Schumaker , Steve French , Dominique Martinet , David Wysochanski , Ilya Dryomov , Linus Torvalds , linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <164678185692.1200972.597611902374126174.stgit@warthog.procyon.org.uk> <164678190346.1200972.7453733431978569479.stgit@warthog.procyon.org.uk> <9132b97b5e52fec9c2838b31739175619df3e752.camel@kernel.org> From: JeffleXu In-Reply-To: <9132b97b5e52fec9c2838b31739175619df3e752.camel@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 3/9/22 11:26 PM, Jeff Layton wrote: > On Tue, 2022-03-08 at 23:25 +0000, David Howells wrote: >> From: Jeffle Xu >> >> Export fscache_end_operation() to avoid code duplication. >> >> Besides, considering the paired fscache_begin_read_operation() is >> already exported, it shall make sense to also export >> fscache_end_operation(). >> > > Not what I think of when you say "exporting" but the patch itself looks > fine. > Yes, maybe "fscache: make fscache_end_operation() generally available" as David said shall be better... -- Thanks, Jeffle