Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dai Ngo <dai.ngo@oracle.com>
CC:     Bruce Fields <bfields@fieldses.org>,
        Jeff Layton <jlayton@redhat.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH RFC v15 11/11] NFSD: Show state of courtesy clients in
 client info
Thread-Topic: [PATCH RFC v15 11/11] NFSD: Show state of courtesy clients in
 client info
Thread-Index: AQHYMCkx0/hr3YEM/0Sucgyj906cvKy3hEEA
Date:   Wed, 9 Mar 2022 20:14:32 +0000
Message-ID: <E1AF0991-A682-4B98-A62F-3FE55349E30F@oracle.com>
References: <1646440633-3542-1-git-send-email-dai.ngo@oracle.com>
 <1646440633-3542-12-git-send-email-dai.ngo@oracle.com>
In-Reply-To: <1646440633-3542-12-git-send-email-dai.ngo@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4jCqmqGeVuorQ3IXt2Xrb/WDkdnv4u6+Y0683WRkeabKB5YWsKpQPiAultD7?=
 =?us-ascii?Q?DoJf17QGhNoJQSwmETmhIaA8REPNIDcvDj3/R5GlrFhS3VFMLtK9zrA4jJeH?=
 =?us-ascii?Q?oCpp9BOlML1o1D1WiUoo7dYV+72Rifuv2k7dYYWKHOImMgx2aV1iUgCRy1sA?=
 =?us-ascii?Q?4r/buIzNIYJhD8+0KgvEkLqFSCfjxE/h6I4KPhshePR3hrL9ZSfcXla4a7zW?=
 =?us-ascii?Q?3Hzdyh3dl+lGH5LVHuXWmz95NmFmoami8HPVTupIw2aOpMRl4TI2iWMvPSBL?=
 =?us-ascii?Q?ELmdWt1dYikhlV/Emlf64rqHreRF60vVfdgy+gEgT4/lCbhsSrtEjZ9Nu2E4?=
 =?us-ascii?Q?2ahA6APd/jqcmxGJLuOyvQ7ENcR5QvvjunNFjKVx1l/i3Y9Wdft+Acj9vrPa?=
 =?us-ascii?Q?Gd1+0SL627+FAbHIZC0sx5bOEdoEigUtXrz0hgKsLcI2/PFPiAtS0RGVsjmm?=
 =?us-ascii?Q?INGonYghcg1CMYO8/GilA9L6ka1+XiJ5ZJqrETMXF4aTcZxDuguUAls9vQk8?=
 =?us-ascii?Q?aLF6mCeKJLUIsQ5u9IMpjeIX5UaZpfSZ7FYmt6cw9I7UbJD2oZH2Abar61HF?=
 =?us-ascii?Q?zAucpjv12IPjJoTgC9ZkTOVmREEyVWDW4XIbZklsJKXdOuiH+q6TACGoR2Uz?=
 =?us-ascii?Q?xLzsGbJeG72Y3dNw11TmxM/pe4dC266/cGjg+TEB7Qbyshe4HEgBVJKppk8Z?=
 =?us-ascii?Q?He2/qHnDa3afuqGmQrpcYhNZ/xjrIEgBr4J92N9qoju3Kd87c6XUhUF6FF56?=
 =?us-ascii?Q?TGQF5Bo7UG+XDZzyIVS2fifd8XyudAWt2HBIpzXJK8phGkllkTD7esGnYlmh?=
 =?us-ascii?Q?hvu9R+bmNxynoTOJ4A3qqn3D2SiXWTbZI9UGGqLhDwcRnxTFDRNPxpviksxT?=
 =?us-ascii?Q?wNSTs5MGHCiEsrBRyM362wXLHZSyICMJrgekKNvHCCui/lyJiq4oe8NhPPKx?=
 =?us-ascii?Q?HjVNth3ZTtvOuW+S2CFfzc5IUUU0mT5AxWi7tp2j5tuGgf54YscZBOwsPRli?=
 =?us-ascii?Q?Ryq2TMiPP9mCtCKiwYqdBV/j4n8wZvLa1NsVbULssrqtW4VTH//ZP6Zblh2r?=
 =?us-ascii?Q?v6IIMf7tzS2uRqyUAp3I4I+HPsaXd32OLaz5zIdWxMR2vbZNceL4qizc0EbD?=
 =?us-ascii?Q?L7XTCKQAuGGKuGds2ziitrIjM9KOYMO09jPEOw0wM8SEsn6bOxHuqEQwWHDQ?=
 =?us-ascii?Q?Vq4JcPdf6bG4A7ztmrTbL6NNAgAIjwpMNRWAUXBvttsnmQBkDAfYZrBCWXPl?=
 =?us-ascii?Q?/RauKA4X3EddXhLjj8aktAIwH1L52BH8oAboKYPUm6+4qZ2m+TSoIU3C37qz?=
 =?us-ascii?Q?sUEOBxZ+eOvVKYHvpeiXQOZIuM6Qo94MRXoeptd5NadgdPjjs8x4N8Qi7LVh?=
 =?us-ascii?Q?ZfQZgBFR2pODwrEqAiUBujAcOsnulhNCxBguQsF+9N4yem14nZ4IjFyEVFSC?=
 =?us-ascii?Q?rY7gMLPKNMgJTlBHQJPs+HKlvxPyc4/dU2VWLmaDOdu07DfY9i35boxU6sVT?=
 =?us-ascii?Q?qhIIJ8+l1tKuxqPWvdup7d2MxlhML4nAA9yLEb4F5ZVVpqoJLh3u9Jv6XVII?=
 =?us-ascii?Q?cZ18P/hLWTUtx5bT9SNuxJsxBPsoEA4Jj8e+uejI6Ejja+2XVrF2jsnByVBT?=
 =?us-ascii?Q?fkgPMbJH+x6ar7LVPun/8GE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <205681B8B66AE34A8C0B1C3941BDA96D@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54754bf0-14a2-4861-3576-08da02096cce
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2022 20:14:32.9122
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rSvB0dLQrbb/AEX3mX5EtxpJBI4pq0K0rlGSZ3iSjF+TxVJBrXgW2B2zY4rv7fSAFePhpKPsaWYEUaul+tQt4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3584
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10281 signatures=692062
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0
 suspectscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203090105
X-Proofpoint-GUID: yhuqFhZuw0l5S2koAD-Kb8GguGGDRS7y
X-Proofpoint-ORIG-GUID: yhuqFhZuw0l5S2koAD-Kb8GguGGDRS7y
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Mar 4, 2022, at 7:37 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>=20
> Update client_info_show to show state of courtesy client
> and time since last renew.
>=20
> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
> ---
> fs/nfsd/nfs4state.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>=20
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index bced09014e6b..ed14e0b54537 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -2439,7 +2439,8 @@ static int client_info_show(struct seq_file *m, voi=
d *v)
> {
> 	struct inode *inode =3D m->private;
> 	struct nfs4_client *clp;
> -	u64 clid;
> +	u64 clid, hrs;
> +	u32 mins, secs;
>=20
> 	clp =3D get_nfsdfs_clp(inode);
> 	if (!clp)
> @@ -2451,6 +2452,12 @@ static int client_info_show(struct seq_file *m, vo=
id *v)
> 		seq_puts(m, "status: confirmed\n");
> 	else
> 		seq_puts(m, "status: unconfirmed\n");
> +	seq_printf(m, "courtesy client: %s\n",
> +		test_bit(NFSD4_CLIENT_COURTESY, &clp->cl_flags) ? "yes" : "no");

I'm wondering if it would be more economical to combine this
output with the status output just before it so we have only
one of:

	seq_puts(m, "status: unconfirmed\n");

	seq_puts(m, "status: confirmed\n");

or

	seq_puts(m, "status: courtesy\n");


> +	hrs =3D div_u64_rem(ktime_get_boottime_seconds() - clp->cl_time,
> +				3600, &secs);
> +	mins =3D div_u64_rem((u64)secs, 60, &secs);
> +	seq_printf(m, "time since last renew: %02ld:%02d:%02d\n", hrs, mins, se=
cs);

Thanks, this seems more friendly than what was here before.

However if we replace the fixed courtesy timeout with a
shrinker, I bet some courtesy clients might lie about for
many more that 99 hours. Perhaps the left-most format
specifier could be just "%lu" and the rest could be "%02u".

(ie, also turn the "d" into "u" to prevent ever displaying
a negative number of time units).


> 	seq_printf(m, "name: ");
> 	seq_quote_mem(m, clp->cl_name.data, clp->cl_name.len);
> 	seq_printf(m, "\nminor version: %d\n", clp->cl_minorversion);
> --=20
> 2.9.5
>=20

--
Chuck Lever