Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dai Ngo <dai.ngo@oracle.com>
CC:     Bruce Fields <bfields@fieldses.org>,
        Jeff Layton <jlayton@redhat.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH RFC v15 11/11] NFSD: Show state of courtesy clients in
 client info
Thread-Topic: [PATCH RFC v15 11/11] NFSD: Show state of courtesy clients in
 client info
Thread-Index: AQHYMCkx0/hr3YEM/0Sucgyj906cvKy3hEEAgAAKNICAAGnRgIAAwe6A
Date:   Thu, 10 Mar 2022 14:43:54 +0000
Message-ID: <FFD71A62-084E-49D2-ADB2-8D7D4463E875@oracle.com>
References: <1646440633-3542-1-git-send-email-dai.ngo@oracle.com>
 <1646440633-3542-12-git-send-email-dai.ngo@oracle.com>
 <E1AF0991-A682-4B98-A62F-3FE55349E30F@oracle.com>
 <c5a82f64-d1a5-3ec5-2bbf-4bd596840cf2@oracle.com>
 <ba8b4983-804d-607f-325e-c9be24c23fcb@oracle.com>
In-Reply-To: <ba8b4983-804d-607f-325e-c9be24c23fcb@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4l/a+222Kl0BWy6WJZmq82n6N6191vjilVqAE0QfnczfY4H5Q++EMs6LO4Lg?=
 =?us-ascii?Q?gSSY1mmBKCE1RMcMjMHiHvj3jzGIrl4XfzFjR5j+45KAr3r1/78K1IU2LdaK?=
 =?us-ascii?Q?GnqNUBgWdK8uGXyi/fm05yrQUWQ6gPd1QtEHxr2jl6PLZOZvNHq67S7PEdUN?=
 =?us-ascii?Q?TOqcPLNnQvv1ET09p3dO6e8a3fuD283X61QNirFTbemXnMg7rbdSwO4SDuex?=
 =?us-ascii?Q?MBcFnDit3UJxL1QmU23ft79A1ROp5txrz9GaJnMBioU/ymEmr6LGBAcaPOb9?=
 =?us-ascii?Q?zeVWoPwjJjKZubIicon1/ygZq3fFIY6psMGrdX0kS8+7Sg2GzBJbTbFeBql6?=
 =?us-ascii?Q?FtPJltZQrr4HMf0dt181P6dLGP1A30xuycTR/2avwcGTStE5JHKirHYb/Fnl?=
 =?us-ascii?Q?84VVhxY9jEJ5yoSeYZsD8T0eaoFuNMpyo1l12yJZy0uyw5+BE6hGUm8Hv3zE?=
 =?us-ascii?Q?p/a3yBZ5TVyYt78rShQI0deMA6mELyNeqPS4XIyAdBd3pf2GG8kYnadMisel?=
 =?us-ascii?Q?hhqT55jxPhtG9cVjVJQO7FAqytT2W3A+NPfik6ILBj7ZiOVO1oP0wqr2DkMe?=
 =?us-ascii?Q?pyj2rGghAyrzCJwWCauiT0H4g1hk0KKlkDQn7SXxtUS41Hw9o3nYC56wsv6Z?=
 =?us-ascii?Q?HiCfHlky/oTAHmj1jxx2yiaYOZ3Sh5ZhFhCo9DaOWfufACaAzMZvl1PKgMdO?=
 =?us-ascii?Q?LG8LIr+jpVMHAQQMSCxYg+eoGkMfXMQHab5fEWDAur8/oGHSW8aTY3PGBfE7?=
 =?us-ascii?Q?TE91mqVN0inV/83BymnC8x5QsYhbrFZ+p2/VZiATF20/XU3jNIAQeM4YbJaC?=
 =?us-ascii?Q?NidLOmEwi6ecFDJD8sUCkKZ7lCPzXgFvPTp2cIatNFfRg/xU91BFQGz04zbi?=
 =?us-ascii?Q?d9C98SChls3/INUteqEi/JRUsOO2boTpkn8nCVIA3fBdcNIQpv+CzFJcvIQ6?=
 =?us-ascii?Q?yk+Bl72vJdVl1UQAch3LUSJuUlCqovtixet+Vrwpr6kgiauAMSi5wGGLXUos?=
 =?us-ascii?Q?Mzx/zBKtIDRp1HLaKIelOm/X+WzM3yJvnxy8s/DCn++1FnaHDbDBX3IwGbJe?=
 =?us-ascii?Q?kRFoxtyo7paXP/LmtbTHlJU+WQ5mxuHeSSrEzcQ16CSfUOVcGLN9yefwFSr4?=
 =?us-ascii?Q?VSdymP3mu1hrIBEntrVKUNcn634T3cRUfL0K7WNIGVV2M5BFdoIUsGMYe3M8?=
 =?us-ascii?Q?JF1cOjXzk/JwrZtALikonZSvEXVgvJbLWftnV4ivl6PBb31jH7wTDxpN0NtM?=
 =?us-ascii?Q?RuLaCR1e6YEktj0m9U/rpax/sRp0SdzpOw11woO3LAY72m5kVG5YE+DQfatF?=
 =?us-ascii?Q?r4b1cb3EBXkntKmUwZqXE1pXcEcr6iSc2Dm5mJ/2du+vD7eEkYLCAjaKms1N?=
 =?us-ascii?Q?VoWaO9rAla4rk1TbGWit2U6FUtAnQgw9iLJrqr2BiefHL1m9V4qG0VXAi4f4?=
 =?us-ascii?Q?UE7iz+SSUjBDKjLk/wDaf+BBryKzIqexTA+OoqNj+3KQZuPlrk1M/pO1+V5n?=
 =?us-ascii?Q?u4UbFFJx3A8x2AavWHRbszNAnP0KidEhBTXuUkegpwKbPTTrhTtjpckg1OTQ?=
 =?us-ascii?Q?sgfNNj96nzqrWLrDYxVTtebRzQfDi1hrXWLP33G578n4ym1ZC7ohPl/kiMAO?=
 =?us-ascii?Q?KMt40U5YWC+twUcRJjbYRoM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2DB194AF049CC046B33046DD9FA6C887@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bc58bc4-7346-4bfc-3bcd-08da02a46692
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2022 14:43:54.4160
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XnI26AFWYbQZpqwQfL7ndA3xRK8qZoKt0XIHxyIZBdRdOIyBYM85dMZ4NSmM5fKCHGCVWqyRQQC7Rmx7Q2yySQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5588
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10281 signatures=692062
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 mlxscore=0
 bulkscore=0 mlxlogscore=999 spamscore=0 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203100079
X-Proofpoint-ORIG-GUID: bLYdCYEF6gseWwqIFGsJhRLILO7cXBhK
X-Proofpoint-GUID: bLYdCYEF6gseWwqIFGsJhRLILO7cXBhK
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Mar 9, 2022, at 10:09 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>=20
>=20
> On 3/9/22 12:51 PM, dai.ngo@oracle.com wrote:
>>=20
>> On 3/9/22 12:14 PM, Chuck Lever III wrote:
>>>=20
>>>> On Mar 4, 2022, at 7:37 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>>>>=20
>>>> Update client_info_show to show state of courtesy client
>>>> and time since last renew.
>>>>=20
>>>> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
>>>> ---
>>>> fs/nfsd/nfs4state.c | 9 ++++++++-
>>>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>>>=20
>>>> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
>>>> index bced09014e6b..ed14e0b54537 100644
>>>> --- a/fs/nfsd/nfs4state.c
>>>> +++ b/fs/nfsd/nfs4state.c
>>>> @@ -2439,7 +2439,8 @@ static int client_info_show(struct seq_file *m, =
void *v)
>>>> {
>>>>     struct inode *inode =3D m->private;
>>>>     struct nfs4_client *clp;
>>>> -    u64 clid;
>>>> +    u64 clid, hrs;
>>>> +    u32 mins, secs;
>>>>=20
>>>>     clp =3D get_nfsdfs_clp(inode);
>>>>     if (!clp)
>>>> @@ -2451,6 +2452,12 @@ static int client_info_show(struct seq_file *m,=
 void *v)
>>>>         seq_puts(m, "status: confirmed\n");
>>>>     else
>>>>         seq_puts(m, "status: unconfirmed\n");
>>>> +    seq_printf(m, "courtesy client: %s\n",
>>>> +        test_bit(NFSD4_CLIENT_COURTESY, &clp->cl_flags) ? "yes" : "no=
");
>>> I'm wondering if it would be more economical to combine this
>>> output with the status output just before it so we have only
>>> one of:
>>>=20
>>>     seq_puts(m, "status: unconfirmed\n");
>>>=20
>>>     seq_puts(m, "status: confirmed\n");
>>>=20
>>> or
>>>=20
>>>     seq_puts(m, "status: courtesy\n");
>>=20
>> make sense, will fix.
>=20
> On second thought, I think it's safer to keep this the same
> since there might be scripts out there that depend on it.

The "status:" information was added just a year ago by
472d155a0631 ("nfsd: report client confirmation status
in "info" file"). I don't see any concern in recent commit
history about making the information in this file
machine-readable or backwards-compatible.

Therefore IMO it should be safe and acceptable to use:

  status: confirmed|unconfirmed|courtesy


> -Dai
>=20
>>=20
>>>=20
>>>=20
>>>> +    hrs =3D div_u64_rem(ktime_get_boottime_seconds() - clp->cl_time,
>>>> +                3600, &secs);
>>>> +    mins =3D div_u64_rem((u64)secs, 60, &secs);
>>>> +    seq_printf(m, "time since last renew: %02ld:%02d:%02d\n", hrs, mi=
ns, secs);
>>> Thanks, this seems more friendly than what was here before.
>>>=20
>>> However if we replace the fixed courtesy timeout with a
>>> shrinker, I bet some courtesy clients might lie about for
>>> many more that 99 hours. Perhaps the left-most format
>>> specifier could be just "%lu" and the rest could be "%02u".
>>>=20
>>> (ie, also turn the "d" into "u" to prevent ever displaying
>>> a negative number of time units).
>>=20
>> will fix.
>>=20
>> I will wait for your review of the rest of the patches before
>> I submit v16.
>>=20
>> Thanks,
>> -Dai
>>=20
>>>=20
>>>=20
>>>>     seq_printf(m, "name: ");
>>>>     seq_quote_mem(m, clp->cl_name.data, clp->cl_name.len);
>>>>     seq_printf(m, "\nminor version: %d\n", clp->cl_minorversion);
>>>> --=20
>>>> 2.9.5
>>>>=20
>>> --=20
>>> Chuck Lever
>>>=20
>>>=20
>>>=20

--
Chuck Lever