Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <c5a82f64-d1a5-3ec5-2bbf-4bd596840cf2@oracle.com>
Date:   Wed, 9 Mar 2022 12:51:03 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH RFC v15 11/11] NFSD: Show state of courtesy clients in
 client info
Content-Language: en-US
To:     Chuck Lever III <chuck.lever@oracle.com>
Cc:     Bruce Fields <bfields@fieldses.org>,
        Jeff Layton <jlayton@redhat.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
References: <1646440633-3542-1-git-send-email-dai.ngo@oracle.com>
 <1646440633-3542-12-git-send-email-dai.ngo@oracle.com>
 <E1AF0991-A682-4B98-A62F-3FE55349E30F@oracle.com>
From:   dai.ngo@oracle.com
In-Reply-To: <E1AF0991-A682-4B98-A62F-3FE55349E30F@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MENUL1dqaWRhaUNyYTJUZmFYM2lxU3pVTkkyUjNjR3JoR3hpYnYrQ3VVTGtz?=
 =?utf-8?B?akl6TkU0WXJwUjNiUmt6dHJBaGExY2IybUVBVCsxNE8zSGFMSHJCWVdZRDly?=
 =?utf-8?B?djkrbHhOUm9RV2kwemlOWjN1WmJoTWtmR2dxRzNnZnllYXE2OStGdVBKOC9h?=
 =?utf-8?B?Q2lrRUdZSlJxemdIZHRxRkhzam13S0k5OElMcmVROExGRnd6R3lNaG1FWEpO?=
 =?utf-8?B?MnIyTkdVQ1o4SHB2Vm1rSXY3NVlocGJ0K2lteUF1Y005NG9SZ3VSbVN2TC9Y?=
 =?utf-8?B?TTJUYUtMKzJXK3N6L1BNbzMyRmZBcFozUG9RRHB0MU9iVXp1LzZOQmpZN2tW?=
 =?utf-8?B?RXE5QTVzY1dSZFFENExleWxnUmlaS3ozb1dVclBwdHQ2cTBWamFRbWxQNWZX?=
 =?utf-8?B?c2Jpb0xMT1NieHpaaWMzVXhXZmM3eVp3bXFrNDNQbDQvLzVJaG1PdmQ3YlU4?=
 =?utf-8?B?RHFIQUJXSTBEQjh4UVFmZWQ3QWhDUExjOWh5RlFGWk1nR1pMQXh4dDh3TUN5?=
 =?utf-8?B?VjBPWFpGRnNMMFZxTTJNZ2QxUWtUUFRNdnpiQWFUellJL1ZtN1RYVmxWTDRQ?=
 =?utf-8?B?eGtZcjFrVDI2YTJSUWY0Y0dvUC9wczBIL3FUeVJRa1llYjBBZE1kZFN3cnlF?=
 =?utf-8?B?aTlpZ1liS205cUdrWnJyNy9RdlpLZVdhQU14S3pzckdYWDFxMzJOREtFTGNM?=
 =?utf-8?B?K2JsclY4NDBIWk1BMi8zVUpmaTcyYk1WNUNIRUFTaGlTajd5MTdLWUVtVDlI?=
 =?utf-8?B?L2pqaS9HaXBuMjI4UTFVaVZ6Skpsd1ZGY2pGeGZJK1VvRys0b0NyVWRES2ZC?=
 =?utf-8?B?VzlqelNOVEcwSHZUTFNmakdlVzJZUEwvVFp3c3VzTVh0NXFaaWxrSGRpQWlW?=
 =?utf-8?B?VytPMDc2UFc0bnBZUUxycHk1NG84ajdONS9ZWjdDLzZQeUgvRUFnZUVyUmRi?=
 =?utf-8?B?aWlEbWd0dVpobk1YSWpoN2gwOFJMVjh6eG50dVU4UUJFOHNzdENrV1ptL0ta?=
 =?utf-8?B?K01QWE8rTUp3NEZPZnoxUWpqSk5Cd2lvc3ZzM0krVXpnazA5eFhINytiNGdn?=
 =?utf-8?B?NkFTakxYcnJoVWdHcGZYOXQraFIyVm9DSU4xVG5aR3N5WTdpR0RjS1BtUW5n?=
 =?utf-8?B?aGJZWmNhbDRYZENsZ3YxMmNQRTZQMkU0ZHlDcTRVVksxL1lnVTJPWU9WS3dk?=
 =?utf-8?B?SGhaRnhZbWU0Zk1uMkEzbVBpejZmMFQvV3FaVzdqd21tMms4M2VUWGdVV2xp?=
 =?utf-8?B?Wld5QlFvb1hPeTlYNzhpUHJVYWNGY3Vxa21xb2pZK1FpaWJGSDlmOGVseWF3?=
 =?utf-8?B?RmtSQjc5bDNvUmVoTFI4VzdBTzhqbFVCV2FxQUJwMkZrSDgwQSs1RDVZTzZq?=
 =?utf-8?B?bmtIa254TUt6SDZLR21Mak9Zb3hsb01KZkVpSzBNMUhxbWN1Vkp4RXZOSUN3?=
 =?utf-8?B?MWpMNGw0c3ZoSTR6STJlZ20waFRlRkNNdXAxN0lLckpzdXJ5WDMvUmJXcFZa?=
 =?utf-8?B?ektMUlRNSEpZaVlTV2F6ZTYrSXAvMWtOWE5CbGpWMjVjTEtlVWNXSThZdW5M?=
 =?utf-8?B?QklOSnhZNm1CWmxPTEhOY2hPdXVrZzZjb0w5dmdTdnUzY0xYTWlYaVhreEI1?=
 =?utf-8?B?YlNQYjZRR0FBUGRsbkxNbWdUdmVINTV1TGlIR001K2VxMFZjWUFYemVWOHJh?=
 =?utf-8?B?QTRML2lxVERaTkM1NHlKdWJyUzNxZGtQbkJGOUNseHNVVHI5SUdHVEZXOXZB?=
 =?utf-8?B?VWFreW5GRHE1dXdud3dNN1RTa1N6alVDUHkzbG5rNkNkQUlmYloyaW5EVWtD?=
 =?utf-8?B?SXhzNEJFeUJ5VG9qYm9EKzBrWXhNSUF2OSs3dC9YOEdFU3RHVzdNY0tTM2Vi?=
 =?utf-8?B?Vzd4OHNtay9obzJtc3FJZERaa21xVUkwcVVGQ3hRU2poQzJNbGtmejZHT3Zi?=
 =?utf-8?B?dURPeGp2RlRCc2NRaDFhU0JhOFpDYjAzazZOKzNuMlBoZ2NoNHo1UlA2YTFN?=
 =?utf-8?B?UnBhV2V6cTBjUFpXVjdCMVFhUDRuNHNIRVdnT2p4Mk00dDFsN1o5QU5MYXE4?=
 =?utf-8?B?SkJaREdOK2NBU2k0NEcxN1c5UzJnRi9JZHpwQmU3VlN3YlV4dnVJM1UweURW?=
 =?utf-8?B?SzdpUUE4QkJqUEloU0EyVjJtUmxXV0s0dXNJRFdxWjJDdGtFS3ZTNDVvTkYy?=
 =?utf-8?Q?J5+xg2F/hZN7cZLtBpkckns=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52ddb1ea-5c6e-4017-f4e5-08da020e8859
X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4270.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2022 20:51:06.8005
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YsBaqNbZ4/qSsd7Z8kzig6qgEWHPPE6XfvQJWa6L5nYvH5E+Pg66xbVmYaZjGVK3tzZtrKuy2msOseZ7tRcKtQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4787
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10281 signatures=692062
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0
 phishscore=0 bulkscore=0 adultscore=0 malwarescore=0 suspectscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203090107
X-Proofpoint-ORIG-GUID: vVCEZjFiXi0nxjRBpDEdEVD2u1uJErsO
X-Proofpoint-GUID: vVCEZjFiXi0nxjRBpDEdEVD2u1uJErsO
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


On 3/9/22 12:14 PM, Chuck Lever III wrote:
>
>> On Mar 4, 2022, at 7:37 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>>
>> Update client_info_show to show state of courtesy client
>> and time since last renew.
>>
>> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
>> ---
>> fs/nfsd/nfs4state.c | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
>> index bced09014e6b..ed14e0b54537 100644
>> --- a/fs/nfsd/nfs4state.c
>> +++ b/fs/nfsd/nfs4state.c
>> @@ -2439,7 +2439,8 @@ static int client_info_show(struct seq_file *m, void *v)
>> {
>> 	struct inode *inode = m->private;
>> 	struct nfs4_client *clp;
>> -	u64 clid;
>> +	u64 clid, hrs;
>> +	u32 mins, secs;
>>
>> 	clp = get_nfsdfs_clp(inode);
>> 	if (!clp)
>> @@ -2451,6 +2452,12 @@ static int client_info_show(struct seq_file *m, void *v)
>> 		seq_puts(m, "status: confirmed\n");
>> 	else
>> 		seq_puts(m, "status: unconfirmed\n");
>> +	seq_printf(m, "courtesy client: %s\n",
>> +		test_bit(NFSD4_CLIENT_COURTESY, &clp->cl_flags) ? "yes" : "no");
> I'm wondering if it would be more economical to combine this
> output with the status output just before it so we have only
> one of:
>
> 	seq_puts(m, "status: unconfirmed\n");
>
> 	seq_puts(m, "status: confirmed\n");
>
> or
>
> 	seq_puts(m, "status: courtesy\n");

make sense, will fix.

>
>
>> +	hrs = div_u64_rem(ktime_get_boottime_seconds() - clp->cl_time,
>> +				3600, &secs);
>> +	mins = div_u64_rem((u64)secs, 60, &secs);
>> +	seq_printf(m, "time since last renew: %02ld:%02d:%02d\n", hrs, mins, secs);
> Thanks, this seems more friendly than what was here before.
>
> However if we replace the fixed courtesy timeout with a
> shrinker, I bet some courtesy clients might lie about for
> many more that 99 hours. Perhaps the left-most format
> specifier could be just "%lu" and the rest could be "%02u".
>
> (ie, also turn the "d" into "u" to prevent ever displaying
> a negative number of time units).

will fix.

I will wait for your review of the rest of the patches before
I submit v16.

Thanks,
-Dai

>
>
>> 	seq_printf(m, "name: ");
>> 	seq_quote_mem(m, clp->cl_name.data, clp->cl_name.len);
>> 	seq_printf(m, "\nminor version: %d\n", clp->cl_minorversion);
>> -- 
>> 2.9.5
>>
> --
> Chuck Lever
>
>
>