Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Trond Myklebust <trondmy@hammerspace.com>,
        Dan Carpenter <dan.carpenter@oracle.com>
CC:     "anna@kernel.org" <anna@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH v2] NFSD: prevent integer overflow on 32 bit systems
Thread-Topic: [PATCH v2] NFSD: prevent integer overflow on 32 bit systems
Thread-Index: AQHYOIIiG1b4nLELAUOop5poNWiQ3KzAoJWAgAACdACAAAKQAA==
Date:   Tue, 15 Mar 2022 16:39:58 +0000
Message-ID: <5AC86875-3CBC-4DA7-BAB2-46DA35324842@oracle.com>
References: <20220315153406.GA1527@kili>
 <C81665CA-D2FB-45EC-BE01-7384B567356B@oracle.com>
 <6229c1c4ab4b82d59503b8c5cd4d909f0e165e2e.camel@hammerspace.com>
In-Reply-To: <6229c1c4ab4b82d59503b8c5cd4d909f0e165e2e.camel@hammerspace.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RK2l/s+l6XBtsMtx5/gVMhoPePDRUIgq10cvLp7ELpKFax1YmsOcG1kdM3Az?=
 =?us-ascii?Q?P1qjXbXT0GWRq+204ZJZ3ZaW9t72HmIJMxWB/5Ybk4py2Gb3Lg4lar1Y/TIH?=
 =?us-ascii?Q?S/zhvAj3F2zomnQFpONeXtshLl00ubJZLqv1L8Uwhpa9w/SkuyqOjO7iVPd6?=
 =?us-ascii?Q?y5ivqGOxGxZELdT4O+TOyMVhybp0Fp50Ls4ZMGopw4PW+bG0aZSJJg5bsGBJ?=
 =?us-ascii?Q?6PLNZaF8nCICcL3NLww1sqfmUGIOhgi60+eNQxNmYrwm5WRvWIj+vI48NVBa?=
 =?us-ascii?Q?UfRAbziK3XcqG+YCCiJLhGUQ0Q2xTjbwiMwoYNqkjLcbPVPt3vW0zEVZk5NA?=
 =?us-ascii?Q?RJfR+MEiUDNuCPhjg4VpctOIMAqlJEvQOjX6zMq4dFAL0toa9e49LeFk3oxa?=
 =?us-ascii?Q?iGyH/c/i0ng2btkfjn42tYa6w/r/ldyWNbebnA3kXlMrlaknBgvLj/8M0Sw9?=
 =?us-ascii?Q?qwvkhbdBjGtoEAtnP7+BZRNP7xBDu+/c2CNGUT0hbhHNW1X2Qi0dBGi87Vic?=
 =?us-ascii?Q?CW5u1IhkpgBwO0I+GOrNFEmUWevkk0qxyFKAMYTumPI905ebZa/xn0vyGMZu?=
 =?us-ascii?Q?Nji5pc+HgGQrIj+BPK26CbpAbZ9INi7qsY74LCJFOUNBEckZYtv8WqurYVMF?=
 =?us-ascii?Q?L3IQuVBK8L6jiZCHJVBrn+8Ytz+X6dENZRbBSqJcKntidd23TklDt+pJD4Ab?=
 =?us-ascii?Q?b3c0YDiK0mfcD6mgW0+FJWezQNgfJ/NyvBXYTyFtvWwlQyKto/KgRpWbNM1j?=
 =?us-ascii?Q?ihKOeZjVn8afKHyQD2T5BjxHQi+bXwlEzPyxQD9zT0lgX8vtSsohjmdzo1S5?=
 =?us-ascii?Q?gC81mlTtRPcPOufjX01cOhHROvTuh2lSWDWbqIKC8Kr5G6HhbnKRUhOZRPY4?=
 =?us-ascii?Q?TOfZqXYLEL5Ugxju0Ds+ck6Pf0VcUC3ytgcan4LimcsPnpnYCcVa+787rc/U?=
 =?us-ascii?Q?2pRy3Tq2026f85t9eZ6R8QrLQ8rAvFlITpNDI859+cY1+j37gWpXS49aYiHW?=
 =?us-ascii?Q?5pbDPL24F5i3aLlvXrdU5MBYIGMUWdDeubR5CH43Jx7SqdbMkg1IRqvU+k3z?=
 =?us-ascii?Q?9aPCwKmNTgs50AgalxOAvBENYEZWRVMrlPfcgeykU6cS9+vW+fN4w/NEU1mX?=
 =?us-ascii?Q?+H8Q62jmjLo7nT1l3krfuJJzHpW2dFaGwrvmbUzH3P8w/ZjAxxidWs+foua4?=
 =?us-ascii?Q?CianW7zZuggjEoVlz05eN3fFU3YfuHgzvkjk1suEkoM/voIvcYh3Htki6IY2?=
 =?us-ascii?Q?3kqq+J3uHAcq9AGHSLKDFTiIgkMrCuvBhTJgdLQbQYtEhPi9ZwVYkKMKgcIa?=
 =?us-ascii?Q?xn8LsDqb69w1aVOK6er0ftSzOLng10B4T1Ss6hTnUfxnUwvNncoJ56MEX/s+?=
 =?us-ascii?Q?XVbzgfROHAKEGHY0EBhp1368hL+vmFKOMRnokymZX6nN0j+d7PEyct9Eu41T?=
 =?us-ascii?Q?mezVauXAE7qoi2u/63i3EWDBjv/8qJ0IoUhHYkL0vvaCmT99+TzRgg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <642259286CD92949AA72C30CFB9D2F8B@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b93b9889-cee0-4054-bf44-08da06a271c3
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2022 16:39:58.8375
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uqxg5Xx1jac3FDmzYlKAGLs1bcm70SrOFEhhLh49eX+D3dggt2n7r2ObRVPm5Y5o5KXrRk3XbCMa/SbIns92UA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB3893
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10287 signatures=693139
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 suspectscore=0 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203150103
X-Proofpoint-ORIG-GUID: ooNUHeEoz5dH0EbrYuxBwIv2FhrGBt6t
X-Proofpoint-GUID: ooNUHeEoz5dH0EbrYuxBwIv2FhrGBt6t
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Mar 15, 2022, at 12:30 PM, Trond Myklebust <trondmy@hammerspace.com> w=
rote:
>=20
> On Tue, 2022-03-15 at 16:22 +0000, Chuck Lever III wrote:
>>=20
>>=20
>>> On Mar 15, 2022, at 11:34 AM, Dan Carpenter
>>> <dan.carpenter@oracle.com> wrote:
>>>=20
>>> On a 32 bit system, the "len * sizeof(*p)" operation can have an
>>> integer overflow.
>>>=20
>>> c: stable@vger.kernel.org
>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>=20
>> Trond, this patch was To: me, but either you or I can take this.
>> Please let me know your preference.
>>=20
>=20
> I don't mind either way. If you've got it applied already, then let's
> send it through your tree.

I've applied this one and "prevent underflow in nfssvc_decode_writeargs".
Thanks, Trond and Dan!


--
Chuck Lever