Received-SPF: softfail (google.com: domain of transitioning linux-nfs-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <29e96a0c-302f-5f13-0e8e-66b0a9e0cf9c@oracle.com>
Date:   Wed, 16 Mar 2022 10:46:22 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH RFC v16 01/11] fs/lock: add helper
 locks_owner_has_blockers to check for blockers
Content-Language: en-US
To:     Chuck Lever III <chuck.lever@oracle.com>
Cc:     Bruce Fields <bfields@fieldses.org>,
        Jeff Layton <jlayton@redhat.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
References: <1647051215-2873-1-git-send-email-dai.ngo@oracle.com>
 <1647051215-2873-2-git-send-email-dai.ngo@oracle.com>
 <31F7D9C2-7DFE-48B0-9464-7042208521D5@oracle.com>
From:   dai.ngo@oracle.com
In-Reply-To: <31F7D9C2-7DFE-48B0-9464-7042208521D5@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N003RjhuZE53M2pnVk9sa3lmb2dDTmFueGRrbkg4MDRZcXl5RW9yQmJ6U3NX?=
 =?utf-8?B?WXpxK3VicHlYUzY1eElZaUVHS0x3SVJsVDN1TmppQmRIcGlUMTlkSHFVZGVH?=
 =?utf-8?B?MnNxM3lVazhpbXU5QXlhOWR6eDZpaFhSWDNkYW5yQ1I3NW5QV2FUVGlPVW1B?=
 =?utf-8?B?UE1vLzlwZHZ6S0EvcnFlbnR6bExzc0l1eDhMSFVTQVJHSFdhOGt5S1Z6Ully?=
 =?utf-8?B?cmZSb08zTXRJcFhuaEt6ZUkrTnhhSlowNCtWNHYyNFZFT0YxT0NYQlQwY1Jh?=
 =?utf-8?B?eHpiMTQrOGZMN2ljY1FmcW5VcUtLNWdUSXFyOWh3L044TVl6ZHAwUm91TDc3?=
 =?utf-8?B?VFluWU93TkMzZ0oxcWpkWVpIOXZycjNldEhRWFB5V0pMTVZaTGZXN0ZhNmY0?=
 =?utf-8?B?VEhMeWJXaW1GY3dHcGVWVEZZTmZlTkRRTVpwVHVPemxaeDJoSG1XbXZXeitJ?=
 =?utf-8?B?NXo4UmdlQ1lVZDJjNlNhaEdlZU45L1hBYW1sRDVrMzZlMlR4cGppOGdlTy93?=
 =?utf-8?B?RFF2RjBHY3FsMWp2T0ZHWXgyQXA1WGFMQkxSRDE5VENQK0hyQ29PUFlFTlNk?=
 =?utf-8?B?SmpFWEIrT0RoWnhlV2lYMUpjZjMvcnFvNWQ1eTVPaWZSRWVySmR3UFlYNld2?=
 =?utf-8?B?UmVMV2ROTFB3OWJBS2hEU2wzVUFRbUE4d0ZBMnA1dG5uemFiVWlTSlZXT21C?=
 =?utf-8?B?QWk2YzhaTFI2c2ZsZ3QzVUI5akgzVWZ1L01MRGNjRThjYXNSRU93T2tnVTRq?=
 =?utf-8?B?R1IvRWg5OEtIdGU5Q3kyZ3J1NUNoSWV5Sm9ZU2RXMnpTVVJHblZ5UXJWUmpL?=
 =?utf-8?B?MEpYbHJlRHRxL1BlTUgrWkJkOWRZNENmMnlXaVVhNURLMTNoYTJLeGx2NlpS?=
 =?utf-8?B?STM4TVIwaENJdmhtMnVpb2xadGR5MG9SR3A0SHBBaXVIMEhtRWFyYVZQVSt4?=
 =?utf-8?B?bTQ2KzVrWVhjZ1NTYmpiOGE3R0RTL1hvdUJXdDNhM2svZXVJRkdJdlJEZjFa?=
 =?utf-8?B?aGhjRTVYSUFGczhmTkl6dEo2OTAwSVZGKzAzRmdKQi96MFdaMlAwN1dNTzU5?=
 =?utf-8?B?NVcrZ2lVOWJlelhvUHpKbDU2OE1PN0htWno3WWphei9OZHZOcmQxWkZVdjI1?=
 =?utf-8?B?TU1xVnZRYWNjcDR1WWM1UHlqN0tna3ZBdTl3YjhHSE5vdWZvNVAxV2NHWXpS?=
 =?utf-8?B?S1RVbDBwTkVZdzk1N1dURzlxeG1meDNaUjZXdy9ER2xrT1ZCcWQ5R2JqOGNH?=
 =?utf-8?B?ZTNEV1ZOR0xMRU1TdCtOUGFKc2ZGTDRWdFQ0QWFybHdqd0VaRVh1bWhUbGpH?=
 =?utf-8?B?eEl2UkxvME04RjhobkJTbkxHdjhJQ3FGV0ZGWDJQUWtHU0ZJYWdiSjJhR0ww?=
 =?utf-8?B?KzQ5a0pXbGJyUlA3aTc3cm42Q1ljRHhDczFhbFhiWEZ6QzBQZy9NR3I3YUR5?=
 =?utf-8?B?SUhnSkxhTmVnRW1NL1NFMWtxVUhqS2FFcTJ0TXdRYStJOXJvSjM2R2hNejJv?=
 =?utf-8?B?emlZRHVZS2FXVkF0Y1hyMlNxckRscU95MjBjNktZZDhhUTloQWt3bFJKVEtE?=
 =?utf-8?B?NXIraHJKQWhXMzhFeU9QRkRpcEdMSzdqVWhWRFlLakhPNnZFeVA5VmJzZlQx?=
 =?utf-8?B?QmpqTElaak8yQ2VLTm5meE0yQlhrajN3QUpJVDZqMzc5dVNUU0ZsTlhEdGYw?=
 =?utf-8?B?b3BadnVDWTFqT3RPOXNzRWFwVkZqbHJpOWR3Ly8yTys2TG1WRVhwZGdtdTJK?=
 =?utf-8?B?WXRKU0hqZUNtWVBvY1dHOUZwck52MkNscVlLTlBhNm1hUVJGL2x2WUhhcE1l?=
 =?utf-8?B?M1crS1p2OEI2c3JkNk1XMjlxTktXSGRyQkRsNWxPc3lGR2FTNmJPQUFFS1ds?=
 =?utf-8?B?b3ZjWHFOOFBxeU12djBKUkt2ZTZrZ3dvYktrZkhVR1MyMXJMWDBCYXZSd2Ew?=
 =?utf-8?Q?aaao3T9iA34k1xXlq4sKpVNxeetSH8xy?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f97b6eec-1c3d-4659-78c9-08da0774e424
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2022 17:46:25.3573
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 56sFKM97PnGHVihC2cX9qFP0HEWMzzfd2ixKrH4YInm2rK+tsQkZYgb8JKVJ3qVumTCyKcvMIAejxTDdS0JB/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1001MB2075
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10288 signatures=693715
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 phishscore=0
 suspectscore=0 mlxscore=0 adultscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203160105
X-Proofpoint-ORIG-GUID: Cur6PMXa75Vi-Dj6quJ6j8CbNURpgYCV
X-Proofpoint-GUID: Cur6PMXa75Vi-Dj6quJ6j8CbNURpgYCV
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hi Chuck,

On 3/16/22 7:27 AM, Chuck Lever III wrote:
>
>> On Mar 11, 2022, at 9:13 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>>
>> Add helper locks_owner_has_blockers to check if there is any blockers
>> for a given lockowner.
>>
>> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
>> ---
>> fs/locks.c         | 28 ++++++++++++++++++++++++++++
>> include/linux/fs.h |  7 +++++++
>> 2 files changed, 35 insertions(+)
>>
>> diff --git a/fs/locks.c b/fs/locks.c
>> index 050acf8b5110..53864eb99dc5 100644
>> --- a/fs/locks.c
>> +++ b/fs/locks.c
>> @@ -300,6 +300,34 @@ void locks_release_private(struct file_lock *fl)
>> }
>> EXPORT_SYMBOL_GPL(locks_release_private);
>>
>> +/**
>> + * locks_owner_has_blockers - Check for blocking lock requests
>> + * @flctx: file lock context
>> + * @owner: lock owner
>> + *
>> + * Return values:
>> + *   %true: @owner has at least one blocker
>> + *   %false: @owner has no blockers
>> + */
>> +bool locks_owner_has_blockers(struct file_lock_context *flctx,
>> +		fl_owner_t owner)
>> +{
>> +	struct file_lock *fl;
>> +
>> +	spin_lock(&flctx->flc_lock);
>> +	list_for_each_entry(fl, &flctx->flc_posix, fl_list) {
>> +		if (fl->fl_owner != owner)
>> +			continue;
>> +		if (!list_empty(&fl->fl_blocked_requests)) {
>> +			spin_unlock(&flctx->flc_lock);
>> +			return true;
>> +		}
>> +	}
>> +	spin_unlock(&flctx->flc_lock);
>> +	return false;
>> +}
>> +EXPORT_SYMBOL_GPL(locks_owner_has_blockers);
>> +
>> /* Free a lock which is not in use. */
>> void locks_free_lock(struct file_lock *fl)
>> {
>> diff --git a/include/linux/fs.h b/include/linux/fs.h
>> index 831b20430d6e..da8ae38f471c 100644
>> --- a/include/linux/fs.h
>> +++ b/include/linux/fs.h
>> @@ -1200,6 +1200,8 @@ extern void lease_unregister_notifier(struct notifier_block *);
>> struct files_struct;
>> extern void show_fd_locks(struct seq_file *f,
>> 			 struct file *filp, struct files_struct *files);
>> +extern bool locks_owner_has_blockers(struct file_lock_context *flctx,
>> +			fl_owner_t owner);
>> #else /* !CONFIG_FILE_LOCKING */
>> static inline int fcntl_getlk(struct file *file, unsigned int cmd,
>> 			      struct flock __user *user)
>> @@ -1335,6 +1337,11 @@ static inline int lease_modify(struct file_lock *fl, int arg,
>> struct files_struct;
>> static inline void show_fd_locks(struct seq_file *f,
>> 			struct file *filp, struct files_struct *files) {}
>> +extern bool locks_owner_has_blockers(struct file_lock_context *flctx,
>> +			fl_owner_t owner)
> Here's the problem, Dai.
>
> This empty function needs to be declared "static inline" not "extern".

Yes, I also found it last night with the 2nd notice from
kernel test robot. Fix in v17.

-Dai

>
>
>> +{
>> +	return false;
>> +}
>> #endif /* !CONFIG_FILE_LOCKING */
>>
>> static inline struct inode *file_inode(const struct file *f)
>> -- 
>> 2.9.5
>>
> --
> Chuck Lever
>
>
>