Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@redhat.com>
CC:     Bruce Fields <bfields@fieldses.org>, Dai Ngo <dai.ngo@oracle.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH RFC v17 01/11] fs/lock: add helper
 locks_owner_has_blockers to check for blockers
Thread-Topic: [PATCH RFC v17 01/11] fs/lock: add helper
 locks_owner_has_blockers to check for blockers
Thread-Index: AQHYOdLAmpfjykEdNkWH0VGWaQHNA6zDrNMA
Date:   Thu, 17 Mar 2022 15:04:02 +0000
Message-ID: <3273032A-27F8-4F80-AFAC-45A4F29B45D4@oracle.com>
References: <1647503028-11966-1-git-send-email-dai.ngo@oracle.com>
 <1647503028-11966-2-git-send-email-dai.ngo@oracle.com>
In-Reply-To: <1647503028-11966-2-git-send-email-dai.ngo@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8/JuVRpuBaOdvWnWqDyjeYQ73ktvjw60pe/QtXhdDTnqe2nManexILyXQjzE?=
 =?us-ascii?Q?HR1pVeIMH3Dg5hUTCFcAzKEiQVw4YlEOLpqVLB90z38JBakhihFe/kbkuwMS?=
 =?us-ascii?Q?XXlPR+z5b9InWCieMoRWNSg8i3kgUr3Ig33gkYPDo+DC27xN6nJLKDrDIELe?=
 =?us-ascii?Q?mip66cpFLhzUW+iv7Uvs0VTZZy1ugQnLsaxlWpjcaDhJCV2/wXPWRJAHuHsp?=
 =?us-ascii?Q?d1kLwQm+LBlh+54G+0bk9/z26a1xbodei9r2MInjNqIilnwOhOBLC4ImU3Oo?=
 =?us-ascii?Q?Hx1NhzDPnldNjIsjHRVpM09reh1/M+qtdowKN8rwXD/bQmPHR/N2wDZ84Bp2?=
 =?us-ascii?Q?dXAG75nfGgsU0vH7VtELKPYvwVCB2VgdV+WlyImwry6rccukcnZ4O4Kr/mJa?=
 =?us-ascii?Q?RqoPEXesb2ZzgStziCpX4uKMKSQXxx2slbtZAmxcwUVavxqOfHcVqBdgz0yi?=
 =?us-ascii?Q?H/aBerAoJS4rpYQ9V680YDNWZSGEXzy4FlnjgcwlN5YeJmGtQxbrytPjU13d?=
 =?us-ascii?Q?NGZ7bZ8f+nffZvC/2S8a012AC4pf8gjfKhnHfTSr3SND1S3DEzL3paBeVR9J?=
 =?us-ascii?Q?biU+Ub4xII81hNErAGXXsKcwB4anKNcQsJDLieP8W7E6R9q3s5l+RyYThBHc?=
 =?us-ascii?Q?NGtfJxHq0gYntEYulGKjKqEwRd4Ktq92RxEoW1YEl71uHeGKrkai/atJ9Im+?=
 =?us-ascii?Q?BVnKy+DFW8V78eHgoQbjv3M+/gc9JEs2+DksxfRHbnwJgU2i0Asceiip2dxG?=
 =?us-ascii?Q?KQQPhdDuASN+5eGOV8VWiPJkQjMQtRhdCH1h9nWg23a1bKJZ4PaS1DFvV8L4?=
 =?us-ascii?Q?DfbKibMbgFW3L5ApyrMssTF5G3BfZu0hyxOOqyVf/BrspmaciwXlRTEVLi+V?=
 =?us-ascii?Q?B84sZ5Jvb0i4S8kQ3Z4FbvuOhYJ8JsLyf4TKJLpaOFZQzelb/t4hWMIt6Iql?=
 =?us-ascii?Q?/oWarOiS/OBg1j6IerTfZ8mfgRNTokO+rtUMUSfAbYeWOf0vgtudCCWNzj4c?=
 =?us-ascii?Q?/rObejFyk6a4IcG34y8eAv5XZOcmukWQbL5Rs7q5yQasZKecJgeCX+CwZD3N?=
 =?us-ascii?Q?F0j1oms3C8Gweb72ExmSvEs2KP2US3Ibf5JauVc1CtylW4GMbFT1gklrCJhh?=
 =?us-ascii?Q?ezMkggJ6V8LS2Ylfslkrf8HOJHrwFrXJg7sPMy/39rufT+MC1ick7KZeM+8W?=
 =?us-ascii?Q?P81McFyF4UtSFb8nCG+dkEeUbw4BiTPdAjdz2xF9X3uSEAA+P5q2kZlWm8Um?=
 =?us-ascii?Q?u5gF7DWzwZgzpGAdKVZKYvBS00VmabnHQcwLvuZ96dsC0UxELDZB9ld2RHYp?=
 =?us-ascii?Q?RvVVMb+lYMnU26egnEs6dMB34sC9aCDXNzjZChsEEotPt5IpWpqAkzxNPNy+?=
 =?us-ascii?Q?jRdnQd5uo1iwb9YiHFwB6UX5D88AvI32u0Ru8r4XX3lt60mwKYCiB9W9qp+S?=
 =?us-ascii?Q?4uzcNEMSzIiIAs827HU4ccHwMXukZPiaYl4AUIYTyrz2O6Yb43N/cA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B5A13FC569DA6E47BA5E8A20FE01C378@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c01756e8-beb0-4670-2422-08da08275f7e
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Mar 2022 15:04:02.4258
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YUDgmjNCLrA+yDsCRcOdJqwb8IkVDgXdPq12WDhcnGRSXir5K7Kf9jrf5bl74994bqkEc2fNeWOO+F+za/AqNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4513
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10289 signatures=693715
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 bulkscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203170088
X-Proofpoint-GUID: 8U5xwNo0LJnd89qAitcNDYzvAiLhvl9K
X-Proofpoint-ORIG-GUID: 8U5xwNo0LJnd89qAitcNDYzvAiLhvl9K
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Mar 17, 2022, at 3:43 AM, Dai Ngo <dai.ngo@oracle.com> wrote:
>=20
> Add helper locks_owner_has_blockers to check if there is any blockers
> for a given lockowner.
>=20
> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>

Hi Jeff, can we get an R-b or Acked from you for this one?


> ---
> fs/locks.c         | 28 ++++++++++++++++++++++++++++
> include/linux/fs.h |  7 +++++++
> 2 files changed, 35 insertions(+)
>=20
> diff --git a/fs/locks.c b/fs/locks.c
> index 050acf8b5110..53864eb99dc5 100644
> --- a/fs/locks.c
> +++ b/fs/locks.c
> @@ -300,6 +300,34 @@ void locks_release_private(struct file_lock *fl)
> }
> EXPORT_SYMBOL_GPL(locks_release_private);
>=20
> +/**
> + * locks_owner_has_blockers - Check for blocking lock requests
> + * @flctx: file lock context
> + * @owner: lock owner
> + *
> + * Return values:
> + *   %true: @owner has at least one blocker
> + *   %false: @owner has no blockers
> + */
> +bool locks_owner_has_blockers(struct file_lock_context *flctx,
> +		fl_owner_t owner)
> +{
> +	struct file_lock *fl;
> +
> +	spin_lock(&flctx->flc_lock);
> +	list_for_each_entry(fl, &flctx->flc_posix, fl_list) {
> +		if (fl->fl_owner !=3D owner)
> +			continue;
> +		if (!list_empty(&fl->fl_blocked_requests)) {
> +			spin_unlock(&flctx->flc_lock);
> +			return true;
> +		}
> +	}
> +	spin_unlock(&flctx->flc_lock);
> +	return false;
> +}
> +EXPORT_SYMBOL_GPL(locks_owner_has_blockers);
> +
> /* Free a lock which is not in use. */
> void locks_free_lock(struct file_lock *fl)
> {
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 831b20430d6e..2057a9df790f 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -1200,6 +1200,8 @@ extern void lease_unregister_notifier(struct notifi=
er_block *);
> struct files_struct;
> extern void show_fd_locks(struct seq_file *f,
> 			 struct file *filp, struct files_struct *files);
> +extern bool locks_owner_has_blockers(struct file_lock_context *flctx,
> +			fl_owner_t owner);
> #else /* !CONFIG_FILE_LOCKING */
> static inline int fcntl_getlk(struct file *file, unsigned int cmd,
> 			      struct flock __user *user)
> @@ -1335,6 +1337,11 @@ static inline int lease_modify(struct file_lock *f=
l, int arg,
> struct files_struct;
> static inline void show_fd_locks(struct seq_file *f,
> 			struct file *filp, struct files_struct *files) {}
> +static inline bool locks_owner_has_blockers(struct file_lock_context *fl=
ctx,
> +			fl_owner_t owner)
> +{
> +	return false;
> +}
> #endif /* !CONFIG_FILE_LOCKING */
>=20
> static inline struct inode *file_inode(const struct file *f)
> --=20
> 2.9.5
>=20

--
Chuck Lever