Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Thomas Haynes <loghyr@hammerspace.com>
CC:     Bill Wendling <morbo@google.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "llvm@lists.linux.dev" <llvm@lists.linux.dev>
Subject: Re: [PATCH v2] nfsd: use correct format characters
Thread-Topic: [PATCH v2] nfsd: use correct format characters
Thread-Index: AQHYOi7VDYQCL/xF8UKwiKHmI8bB76zEPeKAgAAAX4A=
Date:   Thu, 17 Mar 2022 23:47:08 +0000
Message-ID: <4AF48752-1CEC-48D1-A296-47C0393F24A4@oracle.com>
References: <20220316213122.2352992-1-morbo@google.com>
 <20220317184222.2476811-1-morbo@google.com>
 <BEEEADA0-C8E6-44E5-A350-09F35662436B@hammerspace.com>
In-Reply-To: <BEEEADA0-C8E6-44E5-A350-09F35662436B@hammerspace.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g5BUGbKUXjn3Bhj1J9ehfGiooAAYi7YD6reVIWuKCx4x7mDLuH7LMIcrpKFw?=
 =?us-ascii?Q?bXndp+uaPjsiJ3+PBjm4JllEZnQb7xnP1agGS6DVGDi7YvKlfPx6RBC3EDY3?=
 =?us-ascii?Q?aPXYtoCMBD2o2PmtYvkJLV3D9Pw0ajYrXl8rryGbEReKxzMVz4n0j+TDOv7a?=
 =?us-ascii?Q?hIWJeAofNJT7h30yCD81SkFLldAckVbwsOpo17ZvlJvCw6pnyICFV1JPv8mb?=
 =?us-ascii?Q?YjvwxfuDiKqLaAfE3x03ceD01FFGrXQSLIFpncPLFJAGoiL1lpzeF0ghTTE8?=
 =?us-ascii?Q?GlnLgZurTYD0HAQ8adeW2BQKSZ5WVxMOW0t8wBxWi3JWtE0uFu6xLDhQyNat?=
 =?us-ascii?Q?HkG8PsAGVaVFLBtO9APhz6B+01etAK8tUIm5IvKjxW4NPsBrz5M/tlnSHWas?=
 =?us-ascii?Q?aoig6GgVH2rfK+kGTLzsnAmDb2SWPTDX9M8M+c+s9W2FjSqW/y3X1BmYKVoG?=
 =?us-ascii?Q?nkrHpkxBqBqUr/2NFMvlaT5A7QEyzSMJ8YZvY+Tx7zfVb2tfzKp1+1RVvtaB?=
 =?us-ascii?Q?24w8yifRVSC7Zuvp/eQZknWLepr88Nlw/7bk232t7Hv1jiU1nXe60z9AVqV6?=
 =?us-ascii?Q?F5NRJ4AbQSo7LN8MZL9UJJtFyL41JP1/avbX4G0eZxGFnsw/5/VyY/yJgtQ/?=
 =?us-ascii?Q?8touWRikIok6HyWDk7vVRILMLwICDjbfOjjIEH42pMA70ILG3GcA/AIPyKdT?=
 =?us-ascii?Q?tsnZOgS0a3E4zK8NiJuWUtIaKVXlvgYZikh7Vcao723ZzbI0FgSaCdmxDUHF?=
 =?us-ascii?Q?KkVKpWzdxTd4RzEfcwM/46AaoBH27B7HyjtzKCcE4Ur5WQ1S0EjgSsJO3ATS?=
 =?us-ascii?Q?KGrwBXcpL+lkh8J2jERK/8hYFWQ/SZ/aU7K7HSfZhieX4dsdQ+dqT1BnoqWO?=
 =?us-ascii?Q?4e5PrW2cnXq0HXThDUw1ET+mlyCP5qidbSFnXNuWXSp5S5iRaa4DH7ONa28w?=
 =?us-ascii?Q?3AYIN3tCc7SvU7EaWumBH0rt6ge0/OpN8h+ifM9u12Wb9B/Dh3qtBpd0Ntri?=
 =?us-ascii?Q?F5r9r/HyfkPAOKF3G9V9Q4yduZt8xDyDedzhzTc2qy2w4Ub2zsyRmdmJEJ9G?=
 =?us-ascii?Q?SNiFDW78HWZvETEEoSZCEuWBhd9OujW3BZcKgI8jtJW91GDhuRxiecIo6eI3?=
 =?us-ascii?Q?sHmXC5aI5CB82b3S17nWIToDmjfVTz9mQ6Q0UpjFS5HxOB281MJHE34aNiIN?=
 =?us-ascii?Q?bYAneAPtQkticoyGHBPSzf5mH6NjlV9CmpoG2k62Tf+DYUSATpnfmFvQohnX?=
 =?us-ascii?Q?bm9QHBLrUS24BkDryY8MQ3E/MNout1dleyByQK4L5Dk7PahCr9vws5xcO+A6?=
 =?us-ascii?Q?ryTIR26XXgIt+9snrAWQEyF5LMVjZl3fz1agVBwjkCaEcZCN6XNGk9ecQ0nu?=
 =?us-ascii?Q?nGFQ+IxekzfeYW1SPQvy4a43zsCRPFsy6mR+Di29wWGa8s0aWdiol0f5gxYa?=
 =?us-ascii?Q?tHHQi/1xbmDrj7zCF1diI0DeFUXEqz05atngQNJIk7mNfyTIZkBllQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <25E648296285EA41A9337697371C2F28@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e6188951-a7b1-44d8-1ef2-08da087072d3
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Mar 2022 23:47:08.1675
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TEJFupBRemYxwLBvZz4zOy8+M4Y/evocj3V0YMIW6YWY03+8Yvo1m2y2bexdp0pfb9Tsft7RiMw1MWYMgz74dA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1884
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10289 signatures=693715
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 phishscore=0
 suspectscore=0 mlxscore=0 adultscore=0 spamscore=0 mlxlogscore=988
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203170130
X-Proofpoint-GUID: O7CXCa_Z8_gXiyAotGN4qI9I_XHKPH-0
X-Proofpoint-ORIG-GUID: O7CXCa_Z8_gXiyAotGN4qI9I_XHKPH-0
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Mar 17, 2022, at 7:45 PM, Thomas Haynes <loghyr@hammerspace.com> wrote=
:
>=20
>=20
>=20
>> On Mar 17, 2022, at 11:42 AM, Bill Wendling <morbo@google.com> wrote:
>>=20
>> [You don't often get email from morbo@google.com. Learn why this is impo=
rtant at http://aka.ms/LearnAboutSenderIdentification.]
>>=20
>> When compiling with -Wformat, clang emits the following warnings:
>>=20
>> fs/nfsd/flexfilelayout.c:120:27: warning: format specifies type 'unsigne=
d
>> char' but the argument has type 'int' [-Wformat]
>>                         "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
>>                             ~~~~              ^~~~~~~~~
>>                             %d
>> fs/nfsd/flexfilelayout.c:120:38: warning: format specifies type 'unsigne=
d
>> char' but the argument has type 'int' [-Wformat]
>>                         "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
>>                                  ~~~~                    ^~~~~~~~~~~
>>                                  %d
>>=20
>> The types of these arguments are unconditionally defined, so this patch
>> updates the format character to the correct ones for ints and unsigned
>> ints.
>>=20
>> Link: https://github.com/ClangBuiltLinux/linux/issues/378
>> Signed-off-by: Bill Wendling <morbo@google.com>
>> ---
>> v2 - Fixed "Link" to be a valid URL.
>> ---
>> fs/nfsd/flexfilelayout.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/fs/nfsd/flexfilelayout.c b/fs/nfsd/flexfilelayout.c
>> index 2e2f1d5e9f62..070f90ed09b6 100644
>> --- a/fs/nfsd/flexfilelayout.c
>> +++ b/fs/nfsd/flexfilelayout.c
>> @@ -117,7 +117,7 @@ nfsd4_ff_proc_getdeviceinfo(struct super_block *sb, =
struct svc_rqst *rqstp,
>>=20
>>        da->netaddr.addr_len =3D
>>                snprintf(da->netaddr.addr, FF_ADDR_LEN + 1,
>> -                        "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
>> +                        "%s.%d.%d", addr, port >> 8, port & 0xff);
>>=20
>>        da->tightly_coupled =3D false;
>>=20
>> --
>> 2.35.1.723.g4982287a31-goog
>>=20
>=20
>=20
> Reviewed-by: Tom Haynes <loghyr@hammerspace.com>

Perfect, thanks!

--
Chuck Lever